From c0257dd7ae9c8899b49c05ef74d9c5a91ee71d4f Mon Sep 17 00:00:00 2001 From: Furquan Shaikh Date: Wed, 2 May 2018 23:29:04 -0700 Subject: ifdtool: Add a list of known platforms that support IFD_VERSION_2 ifdtool has relied on one of the fields within FCBA(read_freq) to determine whether a platform supports IFD_VERSION_1 or IFD_VERSION_2. However, newer platforms like GLK and CNL do not have read_freq field in FCBA and so the value of these bits cannot be used as an indicator to distinguish IFD versions. In the long run, we need to re-write ifdtool to have a better mapping of SoC to IFD fields. But until that is done, this change adds a list of platforms that we know do not support read_freq field but still use IFD_VERSION_2. This change also updates GLK and CNL to pass in platform parameter to ifdtool. BUG=b:79109029, b:69270831 Change-Id: I36c49f4dcb480ad53b0538ad12292fb94b0e3934 Signed-off-by: Furquan Shaikh Reviewed-on: https://review.coreboot.org/26023 Tested-by: build bot (Jenkins) Reviewed-by: Aaron Durbin --- util/ifdtool/ifdtool.h | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) (limited to 'util/ifdtool/ifdtool.h') diff --git a/util/ifdtool/ifdtool.h b/util/ifdtool/ifdtool.h index ad299a94f8..ef85555e06 100644 --- a/util/ifdtool/ifdtool.h +++ b/util/ifdtool/ifdtool.h @@ -22,7 +22,9 @@ enum ifd_version { }; enum platform { - PLATFORM_APOLLOLAKE, + PLATFORM_APL, + PLATFORM_CNL, + PLATFORM_GLK, PLATFORM_SKLKBL, }; -- cgit v1.2.3