From 85ea91ae3cee3496905626f3d864a1eedfc55f95 Mon Sep 17 00:00:00 2001 From: Bora Guvendik Date: Tue, 12 Feb 2019 13:07:45 -0800 Subject: util/ifdtools: Make EC region readable to BIOS/CPU Allow EC region to be readable by BIOS/CPU so that flashrom can read it. BUG=b:123199222 TEST=Build coreboot with CONFIG_LOCK_MANAGEMENT_ENGINE set, run firmware_LockedME test. Change-Id: I306c74a0893355e57632a22a712b1f4fdaa19306 Signed-off-by: Bora Guvendik Reviewed-on: https://review.coreboot.org/c/31377 Tested-by: build bot (Jenkins) Reviewed-by: Duncan Laurie --- util/ifdtool/ifdtool.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'util/ifdtool') diff --git a/util/ifdtool/ifdtool.c b/util/ifdtool/ifdtool.c index 85623fd3cb..a97f352bdf 100644 --- a/util/ifdtool/ifdtool.c +++ b/util/ifdtool/ifdtool.c @@ -969,8 +969,8 @@ static void lock_descriptor(const char *filename, char *image, int size) case PLATFORM_CNL: case PLATFORM_ICL: case PLATFORM_SKLKBL: - /* CPU/BIOS can read descriptor, BIOS and GbE. */ - fmba->flmstr1 |= 0xb << rd_shift; + /* CPU/BIOS can read descriptor, BIOS, EC and GbE. */ + fmba->flmstr1 |= 0x10b << rd_shift; /* CPU/BIOS can write BIOS and Gbe. */ fmba->flmstr1 |= 0xa << wr_shift; /* ME can read descriptor, ME and GbE. */ -- cgit v1.2.3