From 011b0b3af8426d4e9372eef86f16620038f04a1c Mon Sep 17 00:00:00 2001 From: Patrick Georgi Date: Wed, 26 Aug 2015 12:16:54 +0200 Subject: cbfstool: update warning on cbfstool extract We have tons of file types now that can be safely extracted. It's pretty much only stages and payloads that aren't. Change-Id: Ibf58a2c721f863d654537850c6f93d68a8a5bbeb Signed-off-by: Patrick Georgi Reviewed-on: http://review.coreboot.org/11360 Tested-by: build bot (Jenkins) Reviewed-by: Aaron Durbin --- util/cbfstool/cbfs_image.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) (limited to 'util') diff --git a/util/cbfstool/cbfs_image.c b/util/cbfstool/cbfs_image.c index 315cbe5573..e71d598a7b 100644 --- a/util/cbfstool/cbfs_image.c +++ b/util/cbfstool/cbfs_image.c @@ -645,8 +645,12 @@ int cbfs_export_entry(struct cbfs_image *image, const char *entry_name, entry_name, cbfs_get_entry_addr(image, entry), get_cbfs_entry_type_name(ntohl(entry->type)), ntohl(entry->len)); - if (ntohl(entry->type) != CBFS_COMPONENT_RAW) { - WARN("Only 'raw' files are safe to extract.\n"); + if (ntohl(entry->type) == CBFS_COMPONENT_STAGE) { + WARN("Stages are extracted in SELF format.\n"); + } + + if (ntohl(entry->type) == CBFS_COMPONENT_PAYLOAD) { + WARN("Payloads are extracted in SELF format.\n"); } buffer.data = CBFS_SUBHEADER(entry); -- cgit v1.2.3