diff options
| author | Leif Lindholm <leif.lindholm@linaro.org> | 2016-02-10 16:38:26 +0000 |
|---|---|---|
| committer | Leif Lindholm <leif.lindholm@linaro.org> | 2016-02-26 16:50:22 +0000 |
| commit | 41501f18fdc003f973460057e36fa097dca3e571 (patch) | |
| tree | 2e493906a60db746e614bb009ede586b5d58ab9d | |
| parent | 2a77a37ea43d8269a4320301e2f77b45f59a3ac1 (diff) | |
| download | edk2-platforms-41501f18fdc003f973460057e36fa097dca3e571.tar.xz | |
ArmPlatformPkg: PL061 - drop pointless initialize function
PL061Initialize() did not actually do anything other than call
PL061Identify() - so cut out the middle man.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Leif Lindholm <leif.lindholm@linaro.org>
Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Reviewed-by: Ryan Harkin <ryan.harkin@linaro.org>
| -rw-r--r-- | ArmPlatformPkg/Drivers/PL061GpioDxe/PL061Gpio.c | 27 |
1 files changed, 1 insertions, 26 deletions
diff --git a/ArmPlatformPkg/Drivers/PL061GpioDxe/PL061Gpio.c b/ArmPlatformPkg/Drivers/PL061GpioDxe/PL061Gpio.c index c8125fd0e0..45897ca753 100644 --- a/ArmPlatformPkg/Drivers/PL061GpioDxe/PL061Gpio.c +++ b/ArmPlatformPkg/Drivers/PL061GpioDxe/PL061Gpio.c @@ -57,31 +57,6 @@ PL061Identify ( return EFI_SUCCESS;
}
-EFI_STATUS
-PL061Initialize (
- VOID
- )
-{
- EFI_STATUS Status;
-
- // Check if the PL061 GPIO module exists on board
- Status = PL061Identify();
- if (EFI_ERROR (Status)) {
- Status = EFI_DEVICE_ERROR;
- goto EXIT;
- }
-
- // Do other hardware initialisation things here as required
-
- // Disable Interrupts
- //if (MmioRead8 (PL061_GPIO_IE_REG) != 0) {
- // // Ensure interrupts are disabled
- //}
-
- EXIT:
- return Status;
-}
-
/**
Routine Description:
@@ -298,7 +273,7 @@ PL061InstallProtocol ( //
ASSERT_PROTOCOL_ALREADY_INSTALLED (NULL, &gEmbeddedGpioProtocolGuid);
- Status = PL061Initialize();
+ Status = PL061Identify();
if (EFI_ERROR(Status)) {
return EFI_DEVICE_ERROR;
}
|