diff options
| author | Qiu Shumin <shumin.qiu@intel.com> | 2015-12-21 05:09:23 +0000 |
|---|---|---|
| committer | shenshushi <shenshushi@Edk2> | 2015-12-21 05:09:23 +0000 |
| commit | aa6f7931e4d05aefd9d501257de5f941e78e4312 (patch) | |
| tree | 56d5831d2368e8e74b578fc511ace2c1f5672aff | |
| parent | 5ba9f065a5cd401330281763fae1135961cfd8c4 (diff) | |
| download | edk2-platforms-aa6f7931e4d05aefd9d501257de5f941e78e4312.tar.xz | |
ShellPkg: Refine the code format.
1. Add function header comment.
2. Non-Boolean comparisons should explicitly use a compare operator.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Qiu Shumin <shumin.qiu@intel.com>
Reviewed-by: Ruiyu Ni <ruiyu.ni@intel.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@19424 6f19259b-4bc3-4df7-8a09-765794883524
| -rw-r--r-- | ShellPkg/Application/Shell/ShellManParser.c | 23 |
1 files changed, 21 insertions, 2 deletions
diff --git a/ShellPkg/Application/Shell/ShellManParser.c b/ShellPkg/Application/Shell/ShellManParser.c index f12775f865..6c1849199c 100644 --- a/ShellPkg/Application/Shell/ShellManParser.c +++ b/ShellPkg/Application/Shell/ShellManParser.c @@ -15,7 +15,26 @@ #include "Shell.h"
-CHAR16 EFIAPI InternalShellCharToUpper (IN CHAR16 Char);
+/**
+ Convert a Unicode character to upper case only if
+ it maps to a valid small-case ASCII character.
+
+ This internal function only deal with Unicode character
+ which maps to a valid small-case ASCII character, i.e.
+ L'a' to L'z'. For other Unicode character, the input character
+ is returned directly.
+
+ @param Char The character to convert.
+
+ @retval LowerCharacter If the Char is with range L'a' to L'z'.
+ @retval Unchanged Otherwise.
+
+**/
+CHAR16
+EFIAPI
+InternalShellCharToUpper (
+ IN CHAR16 Char
+ );
/**
Verifies that the filename has .MAN on the end.
@@ -630,7 +649,7 @@ ManFileFindTitleSection( // Do not pass any leading path information that may be present to IsTitleHeader().
//
Start = StrLen(Command);
- while (Start
+ while ((Start != 0)
&& (*(Command + Start - 1) != L'\\')
&& (*(Command + Start - 1) != L'/')
&& (*(Command + Start - 1) != L':')) {
|