Searching for files starts on an 8 byte aligned boundary after the end of the Extended Header if it exists.

Signed-off-by: lzeng14
Reviewed-by: lgao4

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@13143 6f19259b-4bc3-4df7-8a09-765794883524

3 files changed, 42 insertions, 12 deletions

diff --git a/IntelFrameworkModulePkg/Universal/FirmwareVolume/FwVolDxe/FwVol.c b/IntelFrameworkModulePkg/Universal/FirmwareVolume/FwVolDxe/FwVol.c
index a3e507afd0..c3878968d4 100644
--- a/IntelFrameworkModulePkg/Universal/FirmwareVolume/FwVolDxe/FwVol.c
+++ b/IntelFrameworkModulePkg/Universal/FirmwareVolume/FwVolDxe/FwVol.c
@@ -4,7 +4,7 @@
   Layers on top of Firmware Block protocol to produce a file abstraction

   of FV based files.

 

-  Copyright (c) 2006 - 2011, Intel Corporation. All rights reserved.<BR>

+  Copyright (c) 2006 - 2012, Intel Corporation. All rights reserved.<BR>

 

   This program and the accompanying materials

   are licensed and made available under the terms and conditions

@@ -194,6 +194,7 @@ FvCheck (
   EFI_FVB_ATTRIBUTES_2                FvbAttributes;

   EFI_FV_BLOCK_MAP_ENTRY              *BlockMap;

   EFI_FIRMWARE_VOLUME_HEADER          *FwVolHeader;

+  EFI_FIRMWARE_VOLUME_EXT_HEADER      *FwVolExtHeader;

   UINT8                               *FwCache;

   LBA_ENTRY                           *LbaEntry;

   FREE_SPACE_ENTRY                    *FreeSpaceEntry;

@@ -349,14 +350,23 @@ FvCheck (
   //

   // go through the whole FV cache, check the consistence of the FV

   //

-  Ptr           = (UINT8 *) (UINTN) (FvDevice->CachedFv + FvDevice->FwVolHeader->HeaderLength);

-  TopFvAddress  = (UINT8 *) (UINTN) (FvDevice->CachedFv + FvDevice->FwVolHeader->FvLength - 1);

+  if (FvDevice->FwVolHeader->ExtHeaderOffset != 0) {

+    //

+    // Searching for files starts on an 8 byte aligned boundary after the end of the Extended Header if it exists.

+    //

+    FwVolExtHeader = (EFI_FIRMWARE_VOLUME_EXT_HEADER *) (UINTN) (FvDevice->CachedFv + FvDevice->FwVolHeader->ExtHeaderOffset);

+    Ptr = (UINT8 *) FwVolExtHeader + FwVolExtHeader->ExtHeaderSize;

+    Ptr = (UINT8 *) ALIGN_POINTER (Ptr, 8);

+  } else {

+    Ptr = (UINT8 *) (UINTN) (FvDevice->CachedFv + FvDevice->FwVolHeader->HeaderLength);

+  }

+  TopFvAddress = (UINT8 *) (UINTN) (FvDevice->CachedFv + FvDevice->FwVolHeader->FvLength);

 

   //

   // Build FFS list & Free Space List here

   //

-  while (Ptr <= TopFvAddress) {

-    TestLength = TopFvAddress - Ptr + 1;

+  while (Ptr < TopFvAddress) {

+    TestLength = TopFvAddress - Ptr;

 

     if (TestLength > sizeof (EFI_FFS_FILE_HEADER)) {

       TestLength = sizeof (EFI_FFS_FILE_HEADER);

@@ -370,7 +380,7 @@ FvCheck (
       FreeSize  = 0;

 

       do {

-        TestLength = TopFvAddress - Ptr + 1;

+        TestLength = TopFvAddress - Ptr;

 

         if (TestLength > sizeof (EFI_FFS_FILE_HEADER)) {

           TestLength = sizeof (EFI_FFS_FILE_HEADER);

@@ -382,7 +392,7 @@ FvCheck (
 

         FreeSize += TestLength;

         Ptr += TestLength;

-      } while (Ptr <= TopFvAddress);

+      } while (Ptr < TopFvAddress);

 

       FreeSpaceEntry = AllocateZeroPool (sizeof (FREE_SPACE_ENTRY));

       if (FreeSpaceEntry == NULL) {

diff --git a/MdeModulePkg/Core/Dxe/FwVol/FwVol.c b/MdeModulePkg/Core/Dxe/FwVol/FwVol.c
index 66b7673872..1cee6a9ba0 100644
--- a/MdeModulePkg/Core/Dxe/FwVol/FwVol.c
+++ b/MdeModulePkg/Core/Dxe/FwVol/FwVol.c
@@ -294,6 +294,7 @@ FvCheck (
   EFI_STATUS                            Status;

   EFI_FIRMWARE_VOLUME_BLOCK_PROTOCOL    *Fvb;

   EFI_FIRMWARE_VOLUME_HEADER            *FwVolHeader;

+  EFI_FIRMWARE_VOLUME_EXT_HEADER        *FwVolExtHeader;

   EFI_FVB_ATTRIBUTES_2                  FvbAttributes;

   EFI_FV_BLOCK_MAP_ENTRY                *BlockMap;

   FFS_FILE_LIST_ENTRY                   *FfsFileEntry;

@@ -410,7 +411,7 @@ FvCheck (
 

   //

   // go through the whole FV cache, check the consistence of the FV.

-  // Make a linked list off all the Ffs file headers

+  // Make a linked list of all the Ffs file headers

   //

   Status = EFI_SUCCESS;

   InitializeListHead (&FvDevice->FfsFileListHeader);

@@ -418,7 +419,16 @@ FvCheck (
   //

   // Build FFS list

   //

-  FfsHeader = (EFI_FFS_FILE_HEADER *) FvDevice->CachedFv;

+  if (FwVolHeader->ExtHeaderOffset != 0) {

+    //

+    // Searching for files starts on an 8 byte aligned boundary after the end of the Extended Header if it exists.

+    //

+    FwVolExtHeader = (EFI_FIRMWARE_VOLUME_EXT_HEADER *) (FvDevice->CachedFv + (FwVolHeader->ExtHeaderOffset - FwVolHeader->HeaderLength));

+    FfsHeader = (EFI_FFS_FILE_HEADER *) ((UINT8 *) FwVolExtHeader + FwVolExtHeader->ExtHeaderSize);

+    FfsHeader = (EFI_FFS_FILE_HEADER *) ALIGN_POINTER (FfsHeader, 8);

+  } else {

+    FfsHeader = (EFI_FFS_FILE_HEADER *) (FvDevice->CachedFv);

+  }

   TopFvAddress = FvDevice->EndOfCachedFv;

   while ((UINT8 *) FfsHeader < TopFvAddress) {

 

diff --git a/MdeModulePkg/Core/Pei/FwVol/FwVol.c b/MdeModulePkg/Core/Pei/FwVol/FwVol.c
index bcf8335a27..d0375be92e 100644
--- a/MdeModulePkg/Core/Pei/FwVol/FwVol.c
+++ b/MdeModulePkg/Core/Pei/FwVol/FwVol.c
@@ -1,7 +1,7 @@
 /** @file

   Pei Core Firmware File System service routines.

   

-Copyright (c) 2006 - 2011, Intel Corporation. All rights reserved.<BR>

+Copyright (c) 2006 - 2012, Intel Corporation. All rights reserved.<BR>

 This program and the accompanying materials                          

 are licensed and made available under the terms and conditions of the BSD License         

 which accompanies this distribution.  The full text of the license may be found at        

@@ -229,7 +229,8 @@ FindFileEx (
   IN OUT    EFI_PEI_FV_HANDLE        *AprioriFile  OPTIONAL

   )

 {

-  EFI_FIRMWARE_VOLUME_HEADER           *FwVolHeader;

+  EFI_FIRMWARE_VOLUME_HEADER            *FwVolHeader;

+  EFI_FIRMWARE_VOLUME_EXT_HEADER        *FwVolExtHeader;

   EFI_FFS_FILE_HEADER                   **FileHeader;

   EFI_FFS_FILE_HEADER                   *FfsFileHeader;

   UINT32                                FileLength;

@@ -262,7 +263,16 @@ FindFileEx (
   // start from the FileHeader.

   //

   if ((*FileHeader == NULL) || (FileName != NULL)) {

-    FfsFileHeader = (EFI_FFS_FILE_HEADER *)((UINT8 *)FwVolHeader + FwVolHeader->HeaderLength);

+    if (FwVolHeader->ExtHeaderOffset != 0) {

+      //

+      // Searching for files starts on an 8 byte aligned boundary after the end of the Extended Header if it exists.

+      //

+      FwVolExtHeader = (EFI_FIRMWARE_VOLUME_EXT_HEADER *) ((UINT8 *) FwVolHeader + FwVolHeader->ExtHeaderOffset);

+      FfsFileHeader = (EFI_FFS_FILE_HEADER *) ((UINT8 *) FwVolExtHeader + FwVolExtHeader->ExtHeaderSize);

+      FfsFileHeader = (EFI_FFS_FILE_HEADER *) ALIGN_POINTER (FfsFileHeader, 8);

+    } else {

+      FfsFileHeader = (EFI_FFS_FILE_HEADER *)((UINT8 *) FwVolHeader + FwVolHeader->HeaderLength);

+    }

   } else {

     if (IS_FFS_FILE2 (*FileHeader)) {

       if (!IsFfs3Fv) {