diff options
| author | Laszlo Ersek <lersek@redhat.com> | 2014-03-03 08:40:52 +0000 |
|---|---|---|
| committer | jljusten <jljusten@6f19259b-4bc3-4df7-8a09-765794883524> | 2014-03-03 08:40:52 +0000 |
| commit | 96b5f3977773b71702f67d99f5b758c1a184d2bf (patch) | |
| tree | 5a97f386d00176e7ead67140111f980d562c812a | |
| parent | 847e4c3477d3ecb7362c3b31fe9889384557e8ae (diff) | |
| download | edk2-platforms-96b5f3977773b71702f67d99f5b758c1a184d2bf.tar.xz | |
OvmfPkg: QemuVideoDxe: eliminate useless Private->HardwareNeedsStarting
Currently, QemuVideoGraphicsOutputQueryMode() reports EFI_NOT_STARTED when
this boolean field is set.
However, QemuVideoGraphicsOutputQueryMode() is only available to callers
after the GOP interface has been installed. That in turn implies that the
following partial call tree has succeeded without errors:
QemuVideoControllerDriverStart()
QemuVideoGraphicsOutputConstructor()
QemuVideoGraphicsOutputSetMode(... 0 ...)
HardwareNeedsStarting = FALSE
InstallMultipleProtocolInterfaces(... GOP ...)
That is, when QemuVideoGraphicsOutputQueryMode() is reached,
HardwareNeedsStarting is always FALSE.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Laszlo Ersek <lersek@redhat.com>
Reviewed-by: Jordan Justen <jordan.l.justen@intel.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@15286 6f19259b-4bc3-4df7-8a09-765794883524
| -rw-r--r-- | OvmfPkg/QemuVideoDxe/Gop.c | 7 | ||||
| -rw-r--r-- | OvmfPkg/QemuVideoDxe/Qemu.h | 1 |
2 files changed, 0 insertions, 8 deletions
diff --git a/OvmfPkg/QemuVideoDxe/Gop.c b/OvmfPkg/QemuVideoDxe/Gop.c index 1b7db329b9..912947c2ff 100644 --- a/OvmfPkg/QemuVideoDxe/Gop.c +++ b/OvmfPkg/QemuVideoDxe/Gop.c @@ -114,10 +114,6 @@ Routine Description: Private = QEMU_VIDEO_PRIVATE_DATA_FROM_GRAPHICS_OUTPUT_THIS (This);
- if (Private->HardwareNeedsStarting) {
- return EFI_NOT_STARTED;
- }
-
if (Info == NULL || SizeOfInfo == NULL || ModeNumber >= This->Mode->MaxMode) {
return EFI_INVALID_PARAMETER;
}
@@ -209,8 +205,6 @@ Routine Description: This->Mode->Info
);
- Private->HardwareNeedsStarting = FALSE;
-
return EFI_SUCCESS;
}
@@ -331,7 +325,6 @@ QemuVideoGraphicsOutputConstructor ( }
Private->GraphicsOutput.Mode->MaxMode = (UINT32) Private->MaxMode;
Private->GraphicsOutput.Mode->Mode = GRAPHICS_OUTPUT_INVALIDE_MODE_NUMBER;
- Private->HardwareNeedsStarting = TRUE;
Private->LineBuffer = NULL;
//
diff --git a/OvmfPkg/QemuVideoDxe/Qemu.h b/OvmfPkg/QemuVideoDxe/Qemu.h index 38d68729a0..78e182e6bf 100644 --- a/OvmfPkg/QemuVideoDxe/Qemu.h +++ b/OvmfPkg/QemuVideoDxe/Qemu.h @@ -111,7 +111,6 @@ typedef struct { UINTN MaxMode;
QEMU_VIDEO_MODE_DATA *ModeData;
UINT8 *LineBuffer;
- BOOLEAN HardwareNeedsStarting;
QEMU_VIDEO_VARIANT Variant;
} QEMU_VIDEO_PRIVATE_DATA;
|