diff options
| author | qhuang8 <qhuang8@6f19259b-4bc3-4df7-8a09-765794883524> | 2007-11-06 01:38:25 +0000 |
|---|---|---|
| committer | qhuang8 <qhuang8@6f19259b-4bc3-4df7-8a09-765794883524> | 2007-11-06 01:38:25 +0000 |
| commit | ebc1ca5a1ba99ec41d09c65bef739bff884e129b (patch) | |
| tree | 85eb3a4fd6a2664e29fc1a0ab47d19cf47a2ede5 | |
| parent | 518d395c3bee7dd36ae372171ea403cabfe73bfd (diff) | |
| download | edk2-platforms-ebc1ca5a1ba99ec41d09c65bef739bff884e129b.tar.xz | |
Fix two issues:
1. EDK II StrnCpy does not necessarily "0" terminate destination string if the source string length is larger than "n". Caller needs to terminate it itself.
2. The definition of EFI_HII_CALLBACK_PACKET has been changed to follow framework HII spec 0.92, we need to change the corresponding code correctly.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@4270 6f19259b-4bc3-4df7-8a09-765794883524
| -rw-r--r-- | IntelFrameworkModulePkg/Universal/SetupBrowserDxe/InputHandler.c | 14 | ||||
| -rw-r--r-- | IntelFrameworkModulePkg/Universal/SetupBrowserDxe/Presentation.c | 2 |
2 files changed, 9 insertions, 7 deletions
diff --git a/IntelFrameworkModulePkg/Universal/SetupBrowserDxe/InputHandler.c b/IntelFrameworkModulePkg/Universal/SetupBrowserDxe/InputHandler.c index bd0c853a05..3c0a0785ab 100644 --- a/IntelFrameworkModulePkg/Universal/SetupBrowserDxe/InputHandler.c +++ b/IntelFrameworkModulePkg/Universal/SetupBrowserDxe/InputHandler.c @@ -290,7 +290,7 @@ ReadPassword ( SecondEntry = TRUE;
} else if (Status == EFI_NOT_READY) {
Error:
- if (Packet != NULL) {
+ if (Packet != NULL && Packet->String != NULL) {
//
// Upon error, we will likely receive a string to print out
// Display error popup
@@ -403,7 +403,7 @@ Error: //
if (Confirmation) {
if (EFI_ERROR (Status)) {
- if (Packet->String == NULL) {
+ if (Packet == NULL || Packet->String == NULL) {
WidthOfString = GetStringWidth (gConfirmError);
ScreenSize = MAX (WidthOfString, GetStringWidth (gPressEnter)) / 2;
CreatePopUp (ScreenSize, 4, &NullCharacter, gConfirmError, gPressEnter, &NullCharacter);
@@ -513,12 +513,14 @@ Error: //
default:
if ((StringPtr[0] == CHAR_NULL) && (Key.UnicodeChar != CHAR_BACKSPACE)) {
+ StringPtr[0] = Key.UnicodeChar;
+ StringPtr[1] = CHAR_NULL;
if (!Confirmation) {
- StrnCpy (StringPtr, &Key.UnicodeChar, 1);
- StrnCpy (TempString, &Key.UnicodeChar, 1);
+ TempString[0] = Key.UnicodeChar;
+ TempString[1] = CHAR_NULL;
} else {
- StrnCpy (StringPtr, &Key.UnicodeChar, 1);
- StrnCpy (TempString2, &Key.UnicodeChar, 1);
+ TempString2[0] = Key.UnicodeChar;
+ TempString2[1] = CHAR_NULL;
ConfirmationComplete = FALSE;
}
} else if ((GetStringWidth (StringPtr) / 2 <= (UINTN) (MenuOption->ThisTag->Maximum - 1) / 2) &&
diff --git a/IntelFrameworkModulePkg/Universal/SetupBrowserDxe/Presentation.c b/IntelFrameworkModulePkg/Universal/SetupBrowserDxe/Presentation.c index 3452a8d5a2..074b009514 100644 --- a/IntelFrameworkModulePkg/Universal/SetupBrowserDxe/Presentation.c +++ b/IntelFrameworkModulePkg/Universal/SetupBrowserDxe/Presentation.c @@ -1236,7 +1236,7 @@ Returns: Selection->ThisTag->StorageWidth
);
- if (Packet != NULL) {
+ if (Packet != NULL && Packet->String != NULL) {
//
// Upon error, we will likely receive a string to print out
//
|