diff options
| author | Dandan Bi <dandan.bi@intel.com> | 2017-01-19 16:53:41 +0800 |
|---|---|---|
| committer | Hao Wu <hao.a.wu@intel.com> | 2017-01-20 15:40:59 +0800 |
| commit | 058cd03b5857e917a8a6d77ec4707ff77a441ca8 (patch) | |
| tree | e13956d2ae0de29b6e9ebfb4ce75c0f7f85e3c59 | |
| parent | 6d11b822a3a68b810f0ceb26ea107ad0e984052a (diff) | |
| download | edk2-platforms-058cd03b5857e917a8a6d77ec4707ff77a441ca8.tar.xz | |
MdePkg: Avoid Non-Boolean type used as Boolean
Cc: Brijesh Singh <brijesh.singh@amd.com>
Cc: Leo Duran <leo.duran@amd.com>
Cc: Liming Gao <liming.gao@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Dandan Bi <dandan.bi@intel.com>
Reviewed-by: Liming Gao <liming.gao@intel.com>
| -rw-r--r-- | MdePkg/Library/BaseIoLibIntrinsic/IoLibIpf.c | 12 | ||||
| -rw-r--r-- | MdePkg/Library/DxeIoLibCpuIo2/DxeCpuIo2LibInternal.h | 1 | ||||
| -rw-r--r-- | MdePkg/Library/SmmIoLibSmmCpuIo2/IoLib.c | 12 |
3 files changed, 12 insertions, 13 deletions
diff --git a/MdePkg/Library/BaseIoLibIntrinsic/IoLibIpf.c b/MdePkg/Library/BaseIoLibIntrinsic/IoLibIpf.c index e388549b3c..b84134b757 100644 --- a/MdePkg/Library/BaseIoLibIntrinsic/IoLibIpf.c +++ b/MdePkg/Library/BaseIoLibIntrinsic/IoLibIpf.c @@ -282,7 +282,7 @@ IoReadFifo8 ( UINT8 *Buffer8;
Buffer8 = (UINT8 *)Buffer;
- while (Count--) {
+ while (Count-- > 0) {
*Buffer8++ = IoRead8 (Port);
}
}
@@ -315,7 +315,7 @@ IoReadFifo16 ( UINT16 *Buffer16;
Buffer16 = (UINT16 *)Buffer;
- while (Count--) {
+ while (Count-- > 0) {
*Buffer16++ = IoRead16 (Port);
}
}
@@ -348,7 +348,7 @@ IoReadFifo32 ( UINT32 *Buffer32;
Buffer32 = (UINT32 *)Buffer;
- while (Count--) {
+ while (Count-- > 0) {
*Buffer32++ = IoRead32 (Port);
}
}
@@ -381,7 +381,7 @@ IoWriteFifo8 ( UINT8 *Buffer8;
Buffer8 = (UINT8 *)Buffer;
- while (Count--) {
+ while (Count-- > 0) {
IoWrite8 (Port, *Buffer8++);
}
}
@@ -414,7 +414,7 @@ IoWriteFifo16 ( UINT16 *Buffer16;
Buffer16 = (UINT16 *)Buffer;
- while (Count--) {
+ while (Count-- > 0) {
IoWrite16 (Port, *Buffer16++);
}
}
@@ -447,7 +447,7 @@ IoWriteFifo32 ( UINT32 *Buffer32;
Buffer32 = (UINT32 *)Buffer;
- while (Count--) {
+ while (Count-- > 0) {
IoWrite32 (Port, *Buffer32++);
}
}
diff --git a/MdePkg/Library/DxeIoLibCpuIo2/DxeCpuIo2LibInternal.h b/MdePkg/Library/DxeIoLibCpuIo2/DxeCpuIo2LibInternal.h index c84ce6bf9e..8c289cb20d 100644 --- a/MdePkg/Library/DxeIoLibCpuIo2/DxeCpuIo2LibInternal.h +++ b/MdePkg/Library/DxeIoLibCpuIo2/DxeCpuIo2LibInternal.h @@ -135,7 +135,6 @@ IoWriteFifoWorker ( @param Address The MMIO register to read.
The caller is responsible for aligning the Address if required.
@param Width The width of the I/O operation.
- @param Count The number of times to write I/O port.
@return Data read from registers in the EFI system memory space.
diff --git a/MdePkg/Library/SmmIoLibSmmCpuIo2/IoLib.c b/MdePkg/Library/SmmIoLibSmmCpuIo2/IoLib.c index 0279bde27e..69acb80f2d 100644 --- a/MdePkg/Library/SmmIoLibSmmCpuIo2/IoLib.c +++ b/MdePkg/Library/SmmIoLibSmmCpuIo2/IoLib.c @@ -396,7 +396,7 @@ IoReadFifo8 ( UINT8 *Buffer8;
Buffer8 = (UINT8 *)Buffer;
- while (Count--) {
+ while (Count-- > 0) {
*Buffer8++ = IoRead8 (Port);
}
}
@@ -429,7 +429,7 @@ IoWriteFifo8 ( UINT8 *Buffer8;
Buffer8 = (UINT8 *)Buffer;
- while (Count--) {
+ while (Count-- > 0) {
IoWrite8 (Port, *Buffer8++);
}
}
@@ -466,7 +466,7 @@ IoReadFifo16 ( //
ASSERT ((Port & 1) == 0);
Buffer16 = (UINT16 *)Buffer;
- while (Count--) {
+ while (Count-- > 0) {
*Buffer16++ = IoRead16 (Port);
}
}
@@ -503,7 +503,7 @@ IoWriteFifo16 ( //
ASSERT ((Port & 1) == 0);
Buffer16 = (UINT16 *)Buffer;
- while (Count--) {
+ while (Count-- > 0) {
IoWrite16 (Port, *Buffer16++);
}
}
@@ -540,7 +540,7 @@ IoReadFifo32 ( //
ASSERT ((Port & 3) == 0);
Buffer32 = (UINT32 *)Buffer;
- while (Count--) {
+ while (Count-- > 0) {
*Buffer32++ = IoRead32 (Port);
}
}
@@ -577,7 +577,7 @@ IoWriteFifo32 ( //
ASSERT ((Port & 3) == 0);
Buffer32 = (UINT32 *)Buffer;
- while (Count--) {
+ while (Count-- > 0) {
IoWrite32 (Port, *Buffer32++);
}
}
|