diff options
| author | Laszlo Ersek <lersek@redhat.com> | 2016-10-21 11:59:36 +0200 |
|---|---|---|
| committer | Laszlo Ersek <lersek@redhat.com> | 2016-10-25 10:46:38 +0200 |
| commit | 2ea0fee9c77556d2cd8f898500c2240dd41e8a40 (patch) | |
| tree | 055a2e7f460734447a2f2df81cd2a90d44f33f52 | |
| parent | 5d1546b439b305785fc14456cdb2e2e9f96bf5ae (diff) | |
| download | edk2-platforms-2ea0fee9c77556d2cd8f898500c2240dd41e8a40.tar.xz | |
ArmVirtPkg/PlatformBootManagerLib: eliminate unchecked PcdSetXX() calls
These are deprecated / disabled under the
DISABLE_NEW_DEPRECATED_INTERFACES feature test macro.
Introduce a variable called PcdStatus, and use it to assert the success of
these operations (there is no reason for them to fail here).
Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=165
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Laszlo Ersek <lersek@redhat.com>
Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Tested-by: Ard Biesheuvel <ard.biesheuvel@linaro.org> # RVCT
Reviewed-by: Jordan Justen <jordan.l.justen@intel.com>
| -rw-r--r-- | ArmVirtPkg/Library/PlatformBootManagerLib/PlatformBm.c | 6 |
1 files changed, 5 insertions, 1 deletions
diff --git a/ArmVirtPkg/Library/PlatformBootManagerLib/PlatformBm.c b/ArmVirtPkg/Library/PlatformBootManagerLib/PlatformBm.c index aecad570a0..56f4c921b5 100644 --- a/ArmVirtPkg/Library/PlatformBootManagerLib/PlatformBm.c +++ b/ArmVirtPkg/Library/PlatformBootManagerLib/PlatformBm.c @@ -578,6 +578,8 @@ PlatformBootManagerBeforeConsole ( VOID
)
{
+ RETURN_STATUS PcdStatus;
+
//
// Signal EndOfDxe PI Event
//
@@ -629,7 +631,9 @@ PlatformBootManagerBeforeConsole ( //
// Set the front page timeout from the QEMU configuration.
//
- PcdSet16 (PcdPlatformBootTimeOut, GetFrontPageTimeoutFromQemu ());
+ PcdStatus = PcdSet16S (PcdPlatformBootTimeOut,
+ GetFrontPageTimeoutFromQemu ());
+ ASSERT_RETURN_ERROR (PcdStatus);
//
// Register platform-specific boot options and keyboard shortcuts.
|