diff options
| author | Olivier Martin <olivier.martin@arm.com> | 2014-11-11 00:51:11 +0000 |
|---|---|---|
| committer | oliviermartin <oliviermartin@Edk2> | 2014-11-11 00:51:11 +0000 |
| commit | fb7ea6114a780b2fe0da56156d65fa7659ffe2e2 (patch) | |
| tree | c6f9f4cf7f6976c602ef0f3dae33e0d9ed70d836 /ArmPkg/Library/ArmHvcLib | |
| parent | 6382e5df4e320b8b7db40bccbeccbd89d368d52f (diff) | |
| download | edk2-platforms-fb7ea6114a780b2fe0da56156d65fa7659ffe2e2.tar.xz | |
ArmPkg: Ensured the stack is always quad-word aligned
From the AArch64 Procedure Call Standard (ARM IHI 0055B):
5.2.2.1 Universal stack constraints
At all times the following basic constraints must hold:
- SP mod 16 = 0. The stack must be quad-word aligned.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Olivier Martin <olivier.martin@arm.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@16327 6f19259b-4bc3-4df7-8a09-765794883524
Diffstat (limited to 'ArmPkg/Library/ArmHvcLib')
| -rw-r--r-- | ArmPkg/Library/ArmHvcLib/AArch64/ArmHvc.S | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/ArmPkg/Library/ArmHvcLib/AArch64/ArmHvc.S b/ArmPkg/Library/ArmHvcLib/AArch64/ArmHvc.S index a15ae03e0f..99a1d21ce7 100644 --- a/ArmPkg/Library/ArmHvcLib/AArch64/ArmHvc.S +++ b/ArmPkg/Library/ArmHvcLib/AArch64/ArmHvc.S @@ -18,8 +18,8 @@ GCC_ASM_EXPORT(ArmCallHvc)
ASM_PFX(ArmCallHvc):
- // Push x0 on the stack
- str x0, [sp, #-8]!
+ // Push x0 on the stack - The stack must always be quad-word aligned
+ str x0, [sp, #-16]!
// Load the HVC arguments values into the appropriate registers
ldp x6, x7, [x0, #48]
@@ -30,9 +30,9 @@ ASM_PFX(ArmCallHvc): hvc #0
// Pop the ARM_HVC_ARGS structure address from the stack into x9
- ldr x9, [sp], #8
+ ldr x9, [sp], #16
- // Store the HVC returned values into the appropriate registers
+ // Store the HVC returned values into the ARM_HVC_ARGS structure.
// A HVC call can return up to 4 values
stp x2, x3, [x9, #16]
stp x0, x1, [x9, #0]
|