diff options
| author | Jeff Westfahl <jeff.westfahl@ni.com> | 2017-04-27 03:59:29 +0800 |
|---|---|---|
| committer | Guo Mang <mang.guo@intel.com> | 2017-07-12 11:24:42 +0800 |
| commit | 8eb2661f7a578ee09a77dab29ecd9ede22010d4e (patch) | |
| tree | 50a625aefcdd78b12e28aeb236c9d26d4ca5a93e /Core/ShellPkg | |
| parent | 1c399b246ef353aa2d447335e68f9c6ce39a949d (diff) | |
| download | edk2-platforms-8eb2661f7a578ee09a77dab29ecd9ede22010d4e.tar.xz | |
ShellPkg/ShellCommandLib: Update DumpHex to print {|}~
ASCII characters {|}~ should be printed by DumpHex. The problem is that
if you have a string like
{xizzy}~{foo|bar}~{quux}
in the dumped data, it will not appear as such in the *-delimited ASCII
column to the right, but as
.xizzy...foo.bar...quux.
which is less than ideal.
Most of the commit message was inspired by/shamelessly stolen from
Laszlo's example:
https://lists.01.org/pipermail/edk2-devel/2017-April/010266.html
Cc: Jaben Carsey <jaben.carsey@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Jeff Westfahl <jeff.westfahl@ni.com>
Reviewed-by: Laszlo Ersek <lersek@redhat.com>
Reviewed-by: Ruiyu Ni <ruiyu.ni@intel.com>
(cherry picked from commit 4bf3b994e8b207fc919958b4a212a8342aaaa749)
Diffstat (limited to 'Core/ShellPkg')
| -rw-r--r-- | Core/ShellPkg/Library/UefiShellCommandLib/UefiShellCommandLib.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/Core/ShellPkg/Library/UefiShellCommandLib/UefiShellCommandLib.c b/Core/ShellPkg/Library/UefiShellCommandLib/UefiShellCommandLib.c index a2ebc8f820..bd14878052 100644 --- a/Core/ShellPkg/Library/UefiShellCommandLib/UefiShellCommandLib.c +++ b/Core/ShellPkg/Library/UefiShellCommandLib/UefiShellCommandLib.c @@ -1745,7 +1745,7 @@ DumpHex ( Val[Index * 3 + 0] = Hex[TempByte >> 4];
Val[Index * 3 + 1] = Hex[TempByte & 0xF];
Val[Index * 3 + 2] = (CHAR8) ((Index == 7) ? '-' : ' ');
- Str[Index] = (CHAR8) ((TempByte < ' ' || TempByte > 'z') ? '.' : TempByte);
+ Str[Index] = (CHAR8) ((TempByte < ' ' || TempByte > '~') ? '.' : TempByte);
}
Val[Index * 3] = 0;
|