1) Add a stringent check to make sure the package list for UpdateForm call must have IFR packages.

2) Fix a bug for Numeric Opcode creation.
3) Add AssignQuestionId to assign QuestionId to be a non-zero value always.
4) Add in Check in UefiRegisterPackageList to same package list to be registered for more than once. (Framework BDS has this behavior).
5) Fix a bug in HiiNewString


git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5822 6f19259b-4bc3-4df7-8a09-765794883524

1 files changed, 4 insertions, 7 deletions

diff --git a/EdkCompatibilityPkg/Compatibility/FrameworkHiiToUefiHiiThunk/Forms.c b/EdkCompatibilityPkg/Compatibility/FrameworkHiiToUefiHiiThunk/Forms.c
index 3679f6dfb4..02beec331f 100644
--- a/EdkCompatibilityPkg/Compatibility/FrameworkHiiToUefiHiiThunk/Forms.c
+++ b/EdkCompatibilityPkg/Compatibility/FrameworkHiiToUefiHiiThunk/Forms.c
@@ -519,13 +519,10 @@ HiiUpdateForm (
     }

   }

 

-  if ((ThunkContext->IfrPackageCount == 0) && (ThunkContext->StringPackageCount != 0)) {

-    UefiHiiHandle = TagGuidToUefiHiiHandle (Private, &ThunkContext->TagGuid);

-  

-    if (UefiHiiHandle == NULL) {

-      Status = EFI_INVALID_PARAMETER;

-      goto Done;

-    }

+  if (ThunkContext->IfrPackageCount == 0) {

+    ASSERT (FALSE);

+    Status = EFI_INVALID_PARAMETER;

+    goto Done;

   } else {

     UefiHiiHandle = ThunkContext->UefiHiiHandle;

   }