Fix various warnings with the Intel C compiler.

EfiBind.h:
* Adding ignores for certain warnings with the Intel C compiler.
  (Partially merged from MdePkg.)

EfiPxe.h:
* Make sure PXE_NO_UINT64_SUPPORT is defined

Decompress.c:
* Removed 'unreachable' return statement.

EdkCompatibilityPkg/**: (all other files)
* Remove trailing comma from last value in enum.
* Include <EfiBind.h> instead of "EfiBind.h", or
  for some reason __STDC_VERSION__ is not defined.
* Introduce more explicit function call ordering by
  storing results in local variables before using
  in a calculation.
* Add some additional casting for BOOLEAN & UINT8
  following calculations which change the type to 'int'.

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5123 6f19259b-4bc3-4df7-8a09-765794883524

1 files changed, 7 insertions, 3 deletions

diff --git a/EdkCompatibilityPkg/Foundation/Library/EfiCommonLib/String.c b/EdkCompatibilityPkg/Foundation/Library/EfiCommonLib/String.c
index 150f650598..54523b2417 100644
--- a/EdkCompatibilityPkg/Foundation/Library/EfiCommonLib/String.c
+++ b/EdkCompatibilityPkg/Foundation/Library/EfiCommonLib/String.c
@@ -593,7 +593,7 @@ HexStringToBuf (
     } else {

       Byte = Buf[Idx / 2];

       Byte &= 0x0F;

-      Byte |= Digit << 4;

+      Byte = (UINT8)(Byte | (Digit << 4));

     }

 

     Buf[Idx / 2] = Byte;

@@ -749,9 +749,11 @@ Returns:
   Sub = StrCharSet;

   

   while ((*String != L'\0') && (*StrCharSet != L'\0')) {

-    if (*String++ != *StrCharSet++) {

+    if (*String++ != *StrCharSet) {

       String = ++Src;

       StrCharSet = Sub;

+    } else {

+      StrCharSet++;

     }

   }

   if (*StrCharSet == L'\0') {

@@ -788,9 +790,11 @@ Returns:
   Sub = StrCharSet;

   

   while ((*String != '\0') && (*StrCharSet != '\0')) {

-    if (*String++ != *StrCharSet++) {

+    if (*String++ != *StrCharSet) {

       String = ++Src;

       StrCharSet = Sub;

+    } else {

+      StrCharSet++;

     }

   }

   if (*StrCharSet == '\0') {