Code scrub DxeIpl, Runtime, DevicePath, FvbServicesLib, DiskIo, Partition, English, EBC.

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7105 6f19259b-4bc3-4df7-8a09-765794883524

4 files changed, 11 insertions, 56 deletions

diff --git a/MdeModulePkg/Core/DxeIplPeim/Ia32/DxeLoadFunc.c b/MdeModulePkg/Core/DxeIplPeim/Ia32/DxeLoadFunc.c
index 65c7ceac17..22fb1fea2c 100644
--- a/MdeModulePkg/Core/DxeIplPeim/Ia32/DxeLoadFunc.c
+++ b/MdeModulePkg/Core/DxeIplPeim/Ia32/DxeLoadFunc.c
@@ -1,5 +1,5 @@
 /** @file

-  Ia32-specifc functionality for DxeLoad.

+  Ia32-specific functionality for DxeLoad.

 

 Copyright (c) 2006 - 2008, Intel Corporation. <BR>

 All rights reserved. This program and the accompanying materials

@@ -49,9 +49,9 @@ GLOBAL_REMOVE_IF_UNREFERENCED  IA32_DESCRIPTOR gLidtDescriptor = {
 

    This function performs a CPU architecture specific operations to execute

    the entry point of DxeCore with the parameters of HobList.

-   It also intalls EFI_END_OF_PEI_PPI to signal the end of PEI phase.

+   It also installs EFI_END_OF_PEI_PPI to signal the end of PEI phase.

 

-   @param DxeCoreEntryPoint         The entrypoint of DxeCore.

+   @param DxeCoreEntryPoint         The entry point of DxeCore.

    @param HobList                   The start of HobList passed to DxeCore.

 

 **/

@@ -102,7 +102,7 @@ HandOffToDxeCore (
     PageTables = CreateIdentityMappingPageTables ();

 

     //

-    // End of PEI phase singal

+    // End of PEI phase signal

     //

     Status = PeiServicesInstallPpi (&gEndOfPeiSignalPpi);

     ASSERT_EFI_ERROR (Status);

@@ -165,7 +165,7 @@ HandOffToDxeCore (
     TopOfStack = (EFI_PHYSICAL_ADDRESS) (UINTN) ALIGN_POINTER (TopOfStack, CPU_STACK_ALIGNMENT);

 

     //

-    // End of PEI phase singal

+    // End of PEI phase signal

     //

     Status = PeiServicesInstallPpi (&gEndOfPeiSignalPpi);

     ASSERT_EFI_ERROR (Status);

diff --git a/MdeModulePkg/Core/DxeIplPeim/Ia32/ImageRead.c b/MdeModulePkg/Core/DxeIplPeim/Ia32/ImageRead.c
index 747026364e..78abff094c 100644
--- a/MdeModulePkg/Core/DxeIplPeim/Ia32/ImageRead.c
+++ b/MdeModulePkg/Core/DxeIplPeim/Ia32/ImageRead.c
@@ -54,40 +54,3 @@ PeiImageRead (
 

   return EFI_SUCCESS;

 }

-

-

-/**

-   This function simply retrieves the function pointer of ImageRead in

-   ImageContext structure.

-    

-   @param ImageContext       A pointer to the structure of 

-                             PE_COFF_LOADER_IMAGE_CONTEXT

-   

-   @retval EFI_SUCCESS       This function always returns EFI_SUCCESS.

-

-**/

-EFI_STATUS

-GetImageReadFunction (

-  IN      PE_COFF_LOADER_IMAGE_CONTEXT  *ImageContext

-  )

-{

-  VOID        *MemoryBuffer;

-

-  if (gInMemory) {

-    ImageContext->ImageRead = PeiImageRead;

-    return EFI_SUCCESS;

-  }

-

-  //

-  // BugBug; This code assumes PeiImageRead() is less than a page in size!

-  //  Allocate a page so we can shaddow the read function from FLASH into 

-  //  memory to increase performance. 

-  //

-  

-  MemoryBuffer = AllocateCopyPool (0x400, (VOID *)(UINTN) PeiImageRead);

-  ASSERT (MemoryBuffer != NULL);

-

-  ImageContext->ImageRead = (PE_COFF_LOADER_READ_FILE) (UINTN) MemoryBuffer;

-

-  return EFI_SUCCESS;

-}

diff --git a/MdeModulePkg/Core/DxeIplPeim/Ia32/VirtualMemory.c b/MdeModulePkg/Core/DxeIplPeim/Ia32/VirtualMemory.c
index 25fb37ea8e..e940feb1c4 100644
--- a/MdeModulePkg/Core/DxeIplPeim/Ia32/VirtualMemory.c
+++ b/MdeModulePkg/Core/DxeIplPeim/Ia32/VirtualMemory.c
@@ -4,16 +4,16 @@
   enter Long Mode (x64 64-bit mode).

 

   While we make a 1:1 mapping (identity mapping) for all physical pages 

-  we still need to use the MTRR's to ensure that the cachability attirbutes

+  we still need to use the MTRR's to ensure that the cachability attributes

   for all memory regions is correct.

 

   The basic idea is to use 2MB page table entries where ever possible. If

   more granularity of cachability is required then 4K page tables are used.

 

   References:

-    1) IA-32 Intel(R) Atchitecture Software Developer's Manual Volume 1:Basic Architecture, Intel

-    2) IA-32 Intel(R) Atchitecture Software Developer's Manual Volume 2:Instruction Set Reference, Intel

-    3) IA-32 Intel(R) Atchitecture Software Developer's Manual Volume 3:System Programmer's Guide, Intel

+    1) IA-32 Intel(R) Architecture Software Developer's Manual Volume 1:Basic Architecture, Intel

+    2) IA-32 Intel(R) Architecture Software Developer's Manual Volume 2:Instruction Set Reference, Intel

+    3) IA-32 Intel(R) Architecture Software Developer's Manual Volume 3:System Programmer's Guide, Intel

 

 Copyright (c) 2006 - 2008, Intel Corporation. <BR>

 All rights reserved. This program and the accompanying materials

@@ -29,11 +29,6 @@ WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
 #include "DxeIpl.h"

 #include "VirtualMemory.h"

 

-

-

-

-

-

 /**

   Allocates and fills in the Page Directory and Page Table Entries to

   establish a 1:1 Virtual to Physical mapping.

@@ -43,7 +38,7 @@ WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
                                                 table entries  to the physical 

                                                 address space. 

 

-  @return EFI_SUCCESS           The 1:1 Virtual to Physical identity mapping was created

+  @return The address of 4 level page map.

 

 **/

 UINTN

diff --git a/MdeModulePkg/Core/DxeIplPeim/Ia32/VirtualMemory.h b/MdeModulePkg/Core/DxeIplPeim/Ia32/VirtualMemory.h
index be9a7391b6..6ada7102e9 100644
--- a/MdeModulePkg/Core/DxeIplPeim/Ia32/VirtualMemory.h
+++ b/MdeModulePkg/Core/DxeIplPeim/Ia32/VirtualMemory.h
@@ -110,7 +110,7 @@ typedef union {
                                                 table entries  to the physical 

                                                 address space. 

 

-  @return EFI_SUCCESS           The 1:1 Virtual to Physical identity mapping was created

+  @return The address of 4 level page map.

 

 **/

 UINTN

@@ -119,9 +119,6 @@ CreateIdentityMappingPageTables (
   );

 

 

-

-

-

 /**

  

   Fix up the vector number in the vector code.