summaryrefslogtreecommitdiff
path: root/MdeModulePkg/Core
diff options
context:
space:
mode:
authorBi, Dandan <dandan.bi@intel.com>2017-03-03 12:44:46 +0800
committerStar Zeng <star.zeng@intel.com>2017-03-07 21:47:25 +0800
commit7babb4372e6a34cbbc54249b25056272a5a9924c (patch)
tree8e6a2afe47b192aae5b4c696abad2ee4f52609dd /MdeModulePkg/Core
parent76081dfcc5b2ccec7ef88d4dc0f8eedca107c193 (diff)
downloadedk2-platforms-7babb4372e6a34cbbc54249b25056272a5a9924c.tar.xz
MdeModulePkg/DxeCore: Fix coding style issues
Add comments for functions. Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org> Cc: Star Zeng <star.zeng@intel.com> Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Dandan Bi <dandan.bi@intel.com> Reviewed-by: Star Zeng <star.zeng@intel.com>
Diffstat (limited to 'MdeModulePkg/Core')
-rw-r--r--MdeModulePkg/Core/Dxe/Mem/Pool.c19
-rw-r--r--MdeModulePkg/Core/Dxe/Misc/MemoryProtection.c6
2 files changed, 23 insertions, 2 deletions
diff --git a/MdeModulePkg/Core/Dxe/Mem/Pool.c b/MdeModulePkg/Core/Dxe/Mem/Pool.c
index 5248ee2e6c..dd165fea75 100644
--- a/MdeModulePkg/Core/Dxe/Mem/Pool.c
+++ b/MdeModulePkg/Core/Dxe/Mem/Pool.c
@@ -291,6 +291,17 @@ CoreAllocatePool (
return Status;
}
+/**
+ Internal function. Used by the pool functions to allocate pages
+ to back pool allocation requests.
+
+ @param PoolType The type of memory for the new pool pages
+ @param NoPages No of pages to allocate
+ @param Granularity Bits to align.
+
+ @return The allocated memory, or NULL
+
+**/
STATIC
VOID *
CoreAllocatePoolPagesI (
@@ -553,6 +564,14 @@ CoreFreePool (
return Status;
}
+/**
+ Internal function. Frees pool pages allocated via CoreAllocatePoolPagesI().
+
+ @param PoolType The type of memory for the pool pages
+ @param Memory The base address to free
+ @param NoPages The number of pages to free
+
+**/
STATIC
VOID
CoreFreePoolPagesI (
diff --git a/MdeModulePkg/Core/Dxe/Misc/MemoryProtection.c b/MdeModulePkg/Core/Dxe/Misc/MemoryProtection.c
index 070228bc72..7689c794a8 100644
--- a/MdeModulePkg/Core/Dxe/Misc/MemoryProtection.c
+++ b/MdeModulePkg/Core/Dxe/Misc/MemoryProtection.c
@@ -657,6 +657,8 @@ UnprotectUefiImage (
/**
Return the EFI memory permission attribute associated with memory
type 'MemoryType' under the configured DXE memory protection policy.
+
+ @param MemoryType Memory type.
**/
STATIC
UINT64
@@ -788,7 +790,7 @@ MergeMemoryMapForProtectionPolicy (
/**
Remove exec permissions from all regions whose type is identified by
- PcdDxeNxMemoryProtectionPolicy
+ PcdDxeNxMemoryProtectionPolicy.
**/
STATIC
VOID
@@ -1053,7 +1055,7 @@ CoreInitializeMemoryProtection (
}
/**
- Returns whether we are currently executing in SMM mode
+ Returns whether we are currently executing in SMM mode.
**/
STATIC
BOOLEAN