diff options
| author | Zhang Lubo <lubo.zhang@intel.com> | 2016-04-08 09:48:14 +0800 |
|---|---|---|
| committer | Jiaxin Wu <jiaxin.wu@intel.com> | 2016-04-11 08:25:33 +0800 |
| commit | 364f4efa444150df3f074f563374dce1e153adc6 (patch) | |
| tree | 0ac1da2a778b68601b4d9081d43c5a4ed4d0d85b /MdeModulePkg/Include/Library | |
| parent | c720da286687aed978d9a20bcdd6d303bade9ddc (diff) | |
| download | edk2-platforms-364f4efa444150df3f074f563374dce1e153adc6.tar.xz | |
MdeModulePkg: Add new macros and refine codes
Add 2 macros inNetLib.h
#define IP4_MASK_MAX 32
#define IP6_PREFIX_MAX 128
we will use these two macros to check the max mask/prefix length,
instead of
#define IP4_MASK_NUM 33
#define IP6_PREFIX_NUM 129
which means a valid number.
This will make the code readability and maintainability.
Cc: Subramanian Sriram <sriram-s@hpe.com>
Cc: Fu Siyuan <siyuan.fu@intel.com>
Cc: Ye Ting <ting.ye@intel.com>
Cc: Wu Jiaxin <jiaxin.wu@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Zhang Lubo <lubo.zhang@intel.com>
Reviewed-by: Sriram Subramanian <sriram-s@hpe.com>
Diffstat (limited to 'MdeModulePkg/Include/Library')
| -rw-r--r-- | MdeModulePkg/Include/Library/NetLib.h | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/MdeModulePkg/Include/Library/NetLib.h b/MdeModulePkg/Include/Library/NetLib.h index b871a857f9..87f393e2de 100644 --- a/MdeModulePkg/Include/Library/NetLib.h +++ b/MdeModulePkg/Include/Library/NetLib.h @@ -52,6 +52,9 @@ typedef UINT16 TCP_PORTNO; #define IP4_MASK_NUM 33
#define IP6_PREFIX_NUM 129
+#define IP4_MASK_MAX 32
+#define IP6_PREFIX_MAX 128
+
#define IP6_HOP_BY_HOP 0
#define IP6_DESTINATION 60
#define IP6_ROUTING 43
@@ -230,7 +233,7 @@ typedef struct { #define IP4_IS_MULTICAST(Ip) (((Ip) & 0xF0000000) == 0xE0000000)
#define IP4_IS_LOCAL_BROADCAST(Ip) ((Ip) == 0xFFFFFFFF)
#define IP4_NET_EQUAL(Ip1, Ip2, NetMask) (((Ip1) & (NetMask)) == ((Ip2) & (NetMask)))
-#define IP4_IS_VALID_NETMASK(Ip) (NetGetMaskLength (Ip) != IP4_MASK_NUM)
+#define IP4_IS_VALID_NETMASK(Ip) (NetGetMaskLength (Ip) != (IP4_MASK_MAX + 1))
#define IP6_IS_MULTICAST(Ip6) (((Ip6)->Addr[0]) == 0xFF)
|