Refine BaseMemoryTestLib and add instance with full functionality.

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7831 6f19259b-4bc3-4df7-8a09-765794883524

2 files changed, 33 insertions, 18 deletions

diff --git a/MdeModulePkg/Library/BaseMemoryTestLibNull/BaseMemoryTestLibNull.c b/MdeModulePkg/Library/BaseMemoryTestLibNull/BaseMemoryTestLibNull.c
index 4163e61bb3..e88a22536a 100644
--- a/MdeModulePkg/Library/BaseMemoryTestLibNull/BaseMemoryTestLibNull.c
+++ b/MdeModulePkg/Library/BaseMemoryTestLibNull/BaseMemoryTestLibNull.c
@@ -15,23 +15,22 @@ WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
 #include <Library/BaseMemoryTestLib.h>

 

 /**

-  Test a system memory range with sparsely sampled memory units.

+  Perform a quick system memory range test.

 

-  This function tests a system memory range, whose memory units

-  are sampled sparsely. It leads to quick performance but less

-  reliability.

+  This function performs a quick system memory range test. It leads to quick performance

+  but least reliability.

 

   @param  StartAddress           Start address of the memory range to test.

   @param  Length                 Length of the memory range to test.

   @param  ErrorAddress           Address of the memory where error is encountered.

 

   @retval RETURN_SUCCESS         The memory range passes test.

-  @retval RETURNEFI_DEVICE_ERROR The memory range does not pass test.

+  @retval RETURN_DEVICE_ERROR    The memory range does not pass test.

 

 **/

 RETURN_STATUS

 EFIAPI

-SparseMemoryTest (

+QuickMemoryTest (

   IN  VOID      *StartAddress,

   IN  UINT64    Length,

   OUT VOID      **ErrorAddress

@@ -41,23 +40,23 @@ SparseMemoryTest (
 }

 

 /**

-  Test a system memory range with extensively sampled memory units.

+  Test a system memory range with sparsely sampled memory units.

 

   This function tests a system memory range, whose memory units

-  are sampled extensively. Compared with SparseMemoryTest, it achieves

-  more reliability and less performance.

+  are sampled sparsely. It leads to relatively good performance

+  and partial reliability.

 

   @param  StartAddress           Start address of the memory range to test.

   @param  Length                 Length of the memory range to test.

   @param  ErrorAddress           Address of the memory where error is encountered.

 

   @retval RETURN_SUCCESS         The memory range passes test.

-  @retval RETURNEFI_DEVICE_ERROR The memory range does not pass test.

+  @retval RETURN_DEVICE_ERROR    The memory range does not pass test.

 

 **/

 RETURN_STATUS

 EFIAPI

-ExtensiveMemoryTest (

+SparseMemoryTest (

   IN  VOID      *StartAddress,

   IN  UINT64    Length,

   OUT VOID      **ErrorAddress

@@ -67,23 +66,23 @@ ExtensiveMemoryTest (
 }

 

 /**

-  Test a system memory range with every memory unit checked.

+  Test a system memory range with extensively sampled memory units.

 

   This function tests a system memory range, whose memory units

-  are fully checked. It leads to complete reliability with the

-  cost of performance.

+  are sampled extensively. Compared with SparseMemoryTest, it achieves

+  more reliability and less performance.

 

   @param  StartAddress           Start address of the memory range to test.

   @param  Length                 Length of the memory range to test.

   @param  ErrorAddress           Address of the memory where error is encountered.

 

   @retval RETURN_SUCCESS         The memory range passes test.

-  @retval RETURNEFI_DEVICE_ERROR The memory range does not pass test.

+  @retval RETURN_DEVICE_ERROR    The memory range does not pass test.

 

 **/

 RETURN_STATUS

 EFIAPI

-FullMemoryTest (

+ExtensiveMemoryTest (

   IN  VOID      *StartAddress,

   IN  UINT64    Length,

   OUT VOID      **ErrorAddress

@@ -91,3 +90,19 @@ FullMemoryTest (
 {

   return RETURN_SUCCESS;

 }

+

+/**

+  Check if soft ECC initialzation is needed for system

+

+  @retval TRUE         Soft ECC initialzation is needed.

+  @retval FALSE        Soft ECC initialzation is not needed.

+

+**/

+BOOLEAN

+EFIAPI

+IsSoftEccInitRequired (

+  VOID

+  )

+{

+  return FALSE;

+}

diff --git a/MdeModulePkg/Library/BaseMemoryTestLibNull/BaseMemoryTestLibNull.inf b/MdeModulePkg/Library/BaseMemoryTestLibNull/BaseMemoryTestLibNull.inf
index 3587516daf..79f1395f26 100644
--- a/MdeModulePkg/Library/BaseMemoryTestLibNull/BaseMemoryTestLibNull.inf
+++ b/MdeModulePkg/Library/BaseMemoryTestLibNull/BaseMemoryTestLibNull.inf
@@ -18,7 +18,7 @@ WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
   FILE_GUID                      = D519E511-9C1C-47F5-AE01-FD216E779269

   MODULE_TYPE                    = BASE

   VERSION_STRING                 = 1.0

-  LIBRARY_CLASS                  = MemoryTestLib

+  LIBRARY_CLASS                  = BaseMemoryTestLib

 

 #

 # The following information is for reference only and not required by the build tools.

@@ -34,4 +34,4 @@ WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
   MdeModulePkg/MdeModulePkg.dec

 

 [LibraryClasses]

-  MemoryTestLib

+  BaseMemoryTestLib