refine the code and add more security check.

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@9691 6f19259b-4bc3-4df7-8a09-765794883524

1 files changed, 11 insertions, 10 deletions

diff --git a/MdeModulePkg/Universal/Network/Dhcp4Dxe/Dhcp4Driver.c b/MdeModulePkg/Universal/Network/Dhcp4Dxe/Dhcp4Driver.c
index 76c55c4478..3136652f98 100644
--- a/MdeModulePkg/Universal/Network/Dhcp4Dxe/Dhcp4Driver.c
+++ b/MdeModulePkg/Universal/Network/Dhcp4Dxe/Dhcp4Driver.c
@@ -1,6 +1,6 @@
 /** @file

 

-Copyright (c) 2006 - 2009, Intel Corporation.<BR>

+Copyright (c) 2006 - 2010, Intel Corporation.<BR>

 All rights reserved. This program and the accompanying materials

 are licensed and made available under the terms and conditions of the BSD License

 which accompanies this distribution.  The full text of the license may be found at

@@ -32,7 +32,7 @@ EFI_SERVICE_BINDING_PROTOCOL mDhcp4ServiceBindingTemplate = {
   This is the declaration of an EFI image entry point. This entry point is

   the same for UEFI Applications, UEFI OS Loaders, and UEFI Drivers including

   both device drivers and bus drivers.

-  

+

   Entry point of the DHCP driver to install various protocols.

 

   @param[in]  ImageHandle           The firmware allocated handle for the UEFI image.

@@ -315,6 +315,7 @@ Dhcp4DriverBindingStart (
   if (EFI_ERROR (Status)) {

     return Status;

   }

+  ASSERT (DhcpSb != NULL);

 

   //

   // Start the receiving

@@ -360,7 +361,7 @@ ON_ERROR:
   restrictions for this service. DisconnectController()

   must follow these calling restrictions. If any other agent wishes

   to call Stop() it must also follow these calling restrictions.

-  

+

   @param[in]  This              Protocol instance pointer.

   @param[in]  ControllerHandle  Handle of device to stop driver on

   @param[in]  NumberOfChildren  Number of Handles in ChildHandleBuffer. If number of

@@ -482,14 +483,14 @@ DhcpInitProtocol (
 

 /**

   Creates a child handle and installs a protocol.

-  

-  The CreateChild() function installs a protocol on ChildHandle. 

-  If ChildHandle is a pointer to NULL, then a new handle is created and returned in ChildHandle. 

+

+  The CreateChild() function installs a protocol on ChildHandle.

+  If ChildHandle is a pointer to NULL, then a new handle is created and returned in ChildHandle.

   If ChildHandle is not a pointer to NULL, then the protocol installs on the existing ChildHandle.

 

   @param  This        Pointer to the EFI_SERVICE_BINDING_PROTOCOL instance.

   @param  ChildHandle Pointer to the handle of the child to create. If it is NULL,

-                      then a new handle is created. If it is a pointer to an existing UEFI handle, 

+                      then a new handle is created. If it is a pointer to an existing UEFI handle,

                       then the protocol is added to the existing UEFI handle.

 

   @retval EFI_SUCCES            The protocol was added to ChildHandle.

@@ -578,9 +579,9 @@ Dhcp4ServiceBindingCreateChild (
 

 /**

   Destroys a child handle with a protocol installed on it.

-  

-  The DestroyChild() function does the opposite of CreateChild(). It removes a protocol 

-  that was installed by CreateChild() from ChildHandle. If the removed protocol is the 

+

+  The DestroyChild() function does the opposite of CreateChild(). It removes a protocol

+  that was installed by CreateChild() from ChildHandle. If the removed protocol is the

   last protocol on ChildHandle, then ChildHandle is destroyed.

 

   @param  This        Pointer to the EFI_SERVICE_BINDING_PROTOCOL instance.