add security check.

update functions comments.

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@8832 6f19259b-4bc3-4df7-8a09-765794883524

1 files changed, 3 insertions, 2 deletions

diff --git a/MdeModulePkg/Universal/Network/Dhcp4Dxe/Dhcp4Option.c b/MdeModulePkg/Universal/Network/Dhcp4Dxe/Dhcp4Option.c
index aa5009abf3..559fd9ad0e 100644
--- a/MdeModulePkg/Universal/Network/Dhcp4Dxe/Dhcp4Option.c
+++ b/MdeModulePkg/Universal/Network/Dhcp4Dxe/Dhcp4Option.c
@@ -542,6 +542,7 @@ DhcpFillOption (
   @param[out] OptionPoint            The array that contains the DHCP options. Caller

                                      should free it.

 

+  @retval EFI_NOT_FOUND          Cannot find any option.

   @retval EFI_OUT_OF_RESOURCES   Failed to allocate memory to parse the packet.

   @retval EFI_INVALID_PARAMETER  The options are mal-formated

   @retval EFI_SUCCESS            The options are parsed into OptionPoint

@@ -603,6 +604,7 @@ DhcpParseOption (
   *OptionPoint  = NULL;

 

   if (OptNum == 0) {

+    Status = EFI_NOT_FOUND;

     goto ON_EXIT;

   }

 

@@ -673,13 +675,12 @@ DhcpValidateOptions (
   if (EFI_ERROR (Status) || (Count == 0)) {

     return Status;

   }

-

+  

   Updated = FALSE;

   ZeroMem (&Parameter, sizeof (Parameter));

 

   for (Index = 0; Index < Count; Index++) {

     Option = &AllOption[Index];

-    ASSERT (Option != NULL);

 

     //

     // Find the format of the option then validate it.