BaseMemoryLib (BaseMemoryLibRepStr):

	Fix a logic error in SetMem64 (); The correct stride should be 8 instead of 4.
	BasePrintLib:
	Fix Printf(“%\n”) passer error.
	Fix BufferSize = 0, 1 issue
	Fix some missing ASSERT ()s
	Move MAXIMUM_VALUE_CHARACTERS from PrintLibInternal.h to PrintLib.h
	ReportStatusCodeLib:
	Add CONST modifier to some interfaces
	Modify 
	DebugLib:
	Replace some Unicode in comments.
	PeiServicesTablePointerLib
	Add ASSERT()s
	PciLib:
	Remove unnecessary ASSERT()s in PciRead/WriteBuffer()


git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@496 6f19259b-4bc3-4df7-8a09-765794883524

3 files changed, 39 insertions, 22 deletions

diff --git a/MdePkg/Include/Library/DebugLib.h b/MdePkg/Include/Library/DebugLib.h
index 5efb304016..b1d320057f 100644
--- a/MdePkg/Include/Library/DebugLib.h
+++ b/MdePkg/Include/Library/DebugLib.h
@@ -72,7 +72,7 @@ DebugPrint (
   Prints an assert message containing a filename, line number, and description.  

   This may be followed by a breakpoint or a dead loop.

 

-  Print a message of the form �ASSERT <FileName>(<LineNumber>): <Description>\n?

+  Print a message of the form "ASSERT <FileName>(<LineNumber>): <Description>\n"

   to the debug output device.  If DEBUG_PROPERTY_ASSERT_BREAKPOINT_ENABLED bit of 

   PcdDebugProperyMask is set then CpuBreakpoint() is called. Otherwise, if 

   DEBUG_PROPERTY_ASSERT_DEADLOOP_ENABLED bit of PcdDebugProperyMask is set then 

@@ -411,7 +411,7 @@ DebugClearMemoryEnabled (
   by TYPE is compared to TestSignature.  If the signatures match, then a pointer 

   to the pointer to a data structure of the type specified by TYPE is returned.  

   If the signatures do not match, then DebugAssert() is called with a description 

-  of �CR has a bad signature?and Record is returned.  

+  of "CR has a bad signature" and Record is returned.  

 

   If the data type specified by TYPE does not contain the field specified by Field, 

   then the module will not compile.

diff --git a/MdePkg/Include/Library/PrintLib.h b/MdePkg/Include/Library/PrintLib.h
index 9c65459a59..22df74c65a 100644
--- a/MdePkg/Include/Library/PrintLib.h
+++ b/MdePkg/Include/Library/PrintLib.h
@@ -17,9 +17,26 @@
 #ifndef __PRINT_LIB_H__

 #define __PRINT_LIB_H__

 

-//

-// Print primitives

-//

+///

+/// Define the maximum number of characters that are required to

+/// encode a decimal, hexidecimal, GUID, or TIME value with a NULL 

+/// terminator.

+///  

+///  Maximum Length Decimal String     = 28

+///    "-9,223,372,036,854,775,808"

+///  Maximum Length Hexidecimal String = 17

+///    "FFFFFFFFFFFFFFFF"

+///  Maximum Length GUID               = 37

+///    "00000000-0000-0000-0000-000000000000"

+///  Maximum Length TIME               = 18

+///    "12/12/2006  12:12"

+///

+#define MAXIMUM_VALUE_CHARACTERS  38

+

+///

+/// Flags bitmask values use in UnicodeValueToString() and 

+/// AcsiiValueToString()

+///

 #define LEFT_JUSTIFY      0x01

 #define COMMA_TYPE        0x08

 #define PREFIX_ZERO       0x20

diff --git a/MdePkg/Include/Library/ReportStatusCodeLib.h b/MdePkg/Include/Library/ReportStatusCodeLib.h
index 9a3d4daabd..6b32ddb137 100644
--- a/MdePkg/Include/Library/ReportStatusCodeLib.h
+++ b/MdePkg/Include/Library/ReportStatusCodeLib.h
@@ -241,12 +241,12 @@ CodeTypeToPostCode (
 BOOLEAN

 EFIAPI

 ReportStatusCodeExtractAssertInfo (

-  IN  EFI_STATUS_CODE_TYPE   CodeType,

-  IN  EFI_STATUS_CODE_VALUE  Value,  

-  IN  EFI_STATUS_CODE_DATA   *Data, 

-  OUT CHAR8                  **Filename,

-  OUT CHAR8                  **Description,

-  OUT UINT32                 *LineNumber

+  IN EFI_STATUS_CODE_TYPE        CodeType,

+  IN EFI_STATUS_CODE_VALUE       Value,  

+  IN CONST EFI_STATUS_CODE_DATA  *Data, 

+  OUT CHAR8                      **Filename,

+  OUT CHAR8                      **Description,

+  OUT UINT32                     *LineNumber

   );

 

 

@@ -282,10 +282,10 @@ ReportStatusCodeExtractAssertInfo (
 BOOLEAN

 EFIAPI

 ReportStatusCodeExtractDebugInfo (

-  IN  EFI_STATUS_CODE_DATA  *Data,

-  OUT UINT32                *ErrorLevel,

-  OUT VA_LIST               *Marker,

-  OUT CHAR8                 **Format

+  IN CONST EFI_STATUS_CODE_DATA  *Data, 

+  OUT UINT32                     *ErrorLevel,

+  OUT VA_LIST                    *Marker,

+  OUT CHAR8                      **Format

   );

 

 

@@ -349,9 +349,9 @@ ReportStatusCode (
 EFI_STATUS

 EFIAPI

 ReportStatusCodeWithDevicePath (

-  IN EFI_STATUS_CODE_TYPE      Type,

-  IN EFI_STATUS_CODE_VALUE     Value,

-  IN EFI_DEVICE_PATH_PROTOCOL  *DevicePath

+  IN EFI_STATUS_CODE_TYPE            Type,

+  IN EFI_STATUS_CODE_VALUE           Value,

+  IN CONST EFI_DEVICE_PATH_PROTOCOL  *DevicePath

   );

 

 

@@ -393,7 +393,7 @@ EFIAPI
 ReportStatusCodeWithExtendedData (

   IN EFI_STATUS_CODE_TYPE   Type,

   IN EFI_STATUS_CODE_VALUE  Value,

-  IN VOID                   *ExtendedData,

+  IN CONST VOID             *ExtendedData,

   IN UINTN                  ExtendedDataSize

   );

 

@@ -445,9 +445,9 @@ ReportStatusCodeEx (
   IN EFI_STATUS_CODE_TYPE   Type,

   IN EFI_STATUS_CODE_VALUE  Value,

   IN UINT32                 Instance,

-  IN EFI_GUID               *CallerId           OPTIONAL,

-  IN EFI_GUID               *ExtendedDataGuid   OPTIONAL,

-  IN VOID                   *ExtendedData       OPTIONAL,

+  IN CONST EFI_GUID         *CallerId          OPTIONAL,

+  IN CONST EFI_GUID         *ExtendedDataGuid  OPTIONAL,

+  IN CONST VOID             *ExtendedData      OPTIONAL,

   IN UINTN                  ExtendedDataSize

   );