1. Updated some files’ description files in MdePkg, EdkModulePkg & EdkNt32Pkg.

2.	Update .msa files to add some missing files files in MdePkg 
3.	Add Help text to Mde Library related PCDs.
4.	Fix some bugs in CpuId.S and CpuIdEx.S.


git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@919 6f19259b-4bc3-4df7-8a09-765794883524

3 files changed, 41 insertions, 33 deletions

diff --git a/MdePkg/Library/BaseLib/BaseLib.msa b/MdePkg/Library/BaseLib/BaseLib.msa
index 64168b4e41..430d74ef0a 100644
--- a/MdePkg/Library/BaseLib/BaseLib.msa
+++ b/MdePkg/Library/BaseLib/BaseLib.msa
@@ -5,8 +5,8 @@
     <ModuleType>BASE</ModuleType>

     <GuidValue>27d67720-ea68-48ae-93da-a3a074c90e30</GuidValue>

     <Version>1.0</Version>

-    <Abstract>Memory-only library functions with no library constructordestructor</Abstract>

-    <Description>FIX ME!</Description>

+    <Abstract>Component description file for Base Library</Abstract>

+    <Description>Base Library implementation.</Description>

     <Copyright>Copyright (c) 2006, Intel Corporation.</Copyright>

     <License>All rights reserved. This program and the accompanying materials

       are licensed and made available under the terms and conditions of the BSD License

@@ -39,6 +39,7 @@
     </LibraryClass>

   </LibraryClassDefinitions>

   <SourceFiles>

+    <Filename>BaseLibInternal.h</Filename>

     <Filename>String.c</Filename>

     <Filename>LinkedList.c</Filename>

     <Filename>Synchronization.c</Filename>

@@ -364,6 +365,8 @@
     <Filename SupArchList="X64">X64/CpuFlushTlb.asm</Filename>

     <Filename SupArchList="X64">X64/Thunk16.asm</Filename>

     <Filename SupArchList="IPF">Math64.c</Filename>

+    <Filename SupArchList="IPF">Ipf/asm.h</Filename>

+    <Filename SupArchList="IPF">Ipf/ia64_gen.h</Filename>

     <Filename SupArchList="IPF">Ipf/PalCallStatic.s</Filename>

     <Filename SupArchList="IPF">Ipf/setjmp.s</Filename>

     <Filename SupArchList="IPF">Ipf/longjmp.s</Filename>

@@ -394,26 +397,29 @@
     <PcdEntry PcdItemType="FIXED_AT_BUILD">

       <C_Name>PcdMaximumUnicodeStringLength</C_Name>

           <TokenSpaceGuidCName>gEfiMdePkgTokenSpaceGuid</TokenSpaceGuidCName>

-

-      <HelpText/>

+      <HelpText>If PcdMaximumUnicodeStringLength is not zero, the maximum

+                number of characters (not counting the NULL-terminator) in a

+                Unicode string cannot exceed it.</HelpText>

     </PcdEntry>

     <PcdEntry PcdItemType="FIXED_AT_BUILD">

       <C_Name>PcdMaximumAsciiStringLength</C_Name>

           <TokenSpaceGuidCName>gEfiMdePkgTokenSpaceGuid</TokenSpaceGuidCName>

-

-      <HelpText/>

+      <HelpText>If PcdMaximumAsciiStringLength is not zero, the maximum number

+                of characters (not counting the NULL-terminator) in an ASCII

+                string cannot exceed it.</HelpText>

     </PcdEntry>

     <PcdEntry PcdItemType="FIXED_AT_BUILD">

       <C_Name>PcdMaximumLinkedListLength</C_Name>

           <TokenSpaceGuidCName>gEfiMdePkgTokenSpaceGuid</TokenSpaceGuidCName>

-

-      <HelpText/>

+      <HelpText>If PcdMaximumLinkedListLength is not zero, the maximum number

+                of nodes (not counting the list header) in a linked list

+                cannot exceed it.</HelpText>

     </PcdEntry>

     <PcdEntry PcdItemType="FIXED_AT_BUILD">

       <C_Name>PcdSpinLockTimeout</C_Name>

           <TokenSpaceGuidCName>gEfiMdePkgTokenSpaceGuid</TokenSpaceGuidCName>

-

-      <HelpText/>

+      <HelpText>If PcdSpinLockTimeout is not zero, it stands for the timeout

+                value (unit: millisecond) for spin lock.</HelpText>

     </PcdEntry>

   </PcdCoded>

 </ModuleSurfaceArea>
\ No newline at end of file
diff --git a/MdePkg/Library/BaseLib/Ia32/CpuId.S b/MdePkg/Library/BaseLib/Ia32/CpuId.S
index 989daba127..c394de926d 100644
--- a/MdePkg/Library/BaseLib/Ia32/CpuId.S
+++ b/MdePkg/Library/BaseLib/Ia32/CpuId.S
@@ -22,8 +22,6 @@
 #------------------------------------------------------------------------------

 

 

-

-

 #------------------------------------------------------------------------------

 #  VOID

 #  EFIAPI

@@ -35,29 +33,33 @@
 #    OUT  UINT32  *RegisterOutEdx  OPTIONAL

 #    )

 #------------------------------------------------------------------------------

-.globl _AsmCpuid

+.globl  _AsmCpuid

 _AsmCpuid:

-    push   %ebx

-    push   %edi

-    movl    12(%esp),%eax

+    pushl   %ebx

+    pushl   %ebp

+    movl    %esp, %ebp

+    movl    12(%ebp), %eax

     cpuid

-    movl    %ecx,%edi

-    movl    16(%esp),%ecx

+    pushl   %ecx

+    movl    16(%ebp), %ecx

     jecxz   L1

-    movl    %eax,(%ecx)

-L1:

-    movl    20(%esp),%ecx

+    movl    %eax, (%ecx)

+L1: 

+    movl    20(%ebp), %ecx

     jecxz   L2

-    movl    %ebx,(%ecx)

-L2:

-    movl    24(%esp),%ecx

+    movl    %ebx, (%ecx)

+L2: 

+    movl    24(%ebp), %ecx

     jecxz   L3

-    movl    %edi,(%ecx)

-L3:

-    movl    28(%esp),%ecx

+    popl    (%ecx)

+L3: 

+    movl    28(%ebp), %ecx

     jecxz   L4

-    movl    %edx,(%ecx)

-L4:

-    pop    %edi

-    pop    %ebx

+    movl    %edx, (%ecx)

+L4: 

+    movl    12(%ebp), %eax

+    leave

+    popl    %ebx

     ret

+

+

diff --git a/MdePkg/Library/BaseLib/Ia32/CpuIdEx.S b/MdePkg/Library/BaseLib/Ia32/CpuIdEx.S
index 43c23b6415..e5255fb1a3 100644
--- a/MdePkg/Library/BaseLib/Ia32/CpuIdEx.S
+++ b/MdePkg/Library/BaseLib/Ia32/CpuIdEx.S
@@ -55,13 +55,13 @@ L1:
 L2: 
     movl    28(%ebp), %ecx
     jecxz   L3
-    popl    %ecx
+    popl    (%ecx)
 L3: 
     movl    32(%ebp), %edx
     jecxz   L4
     movl    %edx, (%ecx)
 L4: 
     movl    12(%ebp), %eax
-    pop     %ebx
     leave
+    pop     %ebx
     ret