Make MDE package pass intel IPF compiler with /W4 /WX switched on.

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@2312 6f19259b-4bc3-4df7-8a09-765794883524

3 files changed, 227 insertions, 57 deletions

diff --git a/MdePkg/Library/BaseUefiDecompressLib/BaseUefiDecompressLib.c b/MdePkg/Library/BaseUefiDecompressLib/BaseUefiDecompressLib.c
index a336417760..e70dc88ef1 100644
--- a/MdePkg/Library/BaseUefiDecompressLib/BaseUefiDecompressLib.c
+++ b/MdePkg/Library/BaseUefiDecompressLib/BaseUefiDecompressLib.c
@@ -14,59 +14,7 @@
 

 **/

 

-//

-// Decompression algorithm begins here

-//

-#define BITBUFSIZ 32

-#define MAXMATCH  256

-#define THRESHOLD 3

-#define CODE_BIT  16

-#define BAD_TABLE - 1

-

-//

-// C: Char&Len Set; P: Position Set; T: exTra Set

-//

-#define NC      (0xff + MAXMATCH + 2 - THRESHOLD)

-#define CBIT    9

-#define MAXPBIT 5

-#define TBIT    5

-#define MAXNP   ((1U << MAXPBIT) - 1)

-#define NT      (CODE_BIT + 3)

-#if NT > MAXNP

-#define NPT NT

-#else

-#define NPT MAXNP

-#endif

-

-typedef struct {

-  UINT8   *mSrcBase;  ///< Starting address of compressed data

-  UINT8   *mDstBase;  ///< Starting address of decompressed data

-  UINT32  mOutBuf;

-  UINT32  mInBuf;

-

-  UINT16  mBitCount;

-  UINT32  mBitBuf;

-  UINT32  mSubBitBuf;

-  UINT16  mBlockSize;

-  UINT32  mCompSize;

-  UINT32  mOrigSize;

-

-  UINT16  mBadTableFlag;

-

-  UINT16  mLeft[2 * NC - 1];

-  UINT16  mRight[2 * NC - 1];

-  UINT8   mCLen[NC];

-  UINT8   mPTLen[NPT];

-  UINT16  mCTable[4096];

-  UINT16  mPTTable[256];

-

-  ///

-  /// The length of the field 'Position Set Code Length Array Size' in Block Header.

-  /// For EFI 1.1 de/compression algorithm, mPBit = 4

-  /// For Tiano de/compression algorithm, mPBit = 5

-  ///

-  UINT8   mPBit;

-} SCRATCH_DATA;

+#include "BaseUefiDecompressLibInternals.h"

 

 /**

   Read NumOfBit of bits from source into mBitBuf

@@ -195,6 +143,9 @@ MakeTable (
   UINT16  Avail;

   UINT16  NextCode;

   UINT16  Mask;

+  UINT16  WordOfStart;

+  UINT16  WordOfCount;

+

 

   for (Index = 1; Index <= 16; Index++) {

     Count[Index] = 0;

@@ -207,7 +158,9 @@ MakeTable (
   Start[1] = 0;

 

   for (Index = 1; Index <= 16; Index++) {

-    Start[Index + 1] = (UINT16) (Start[Index] + (Count[Index] << (16 - Index)));

+    WordOfStart = Start[Index];

+    WordOfCount = Count[Index];

+    Start[Index + 1] = (UINT16) (WordOfStart + (WordOfCount << (16 - Index)));

   }

 

   if (Start[17] != 0) {

@@ -627,7 +580,7 @@ Decode (
     // 

     CharC = DecodeC (Sd);

     if (Sd->mBadTableFlag != 0) {

-      return ;

+      goto Done;

     }

 

     if (CharC < 256) {

@@ -635,7 +588,7 @@ Decode (
       // Process an Original character

       //

       if (Sd->mOutBuf >= Sd->mOrigSize) {

-        return ;

+        goto Done;

       } else {

         //

         // Write orignal character into mDstBase

@@ -666,7 +619,7 @@ Decode (
       while ((INT16) (BytesRemain) >= 0) {

         Sd->mDstBase[Sd->mOutBuf++] = Sd->mDstBase[DataIdx++];

         if (Sd->mOutBuf >= Sd->mOrigSize) {

-          return ;

+          goto Done;

         }

 

         BytesRemain--;

@@ -674,6 +627,7 @@ Decode (
     }

   }

 

+Done:

   return ;

 }

 

diff --git a/MdePkg/Library/BaseUefiDecompressLib/BaseUefiDecompressLib.msa b/MdePkg/Library/BaseUefiDecompressLib/BaseUefiDecompressLib.msa
index 08ac9af7f1..6302302d18 100644
--- a/MdePkg/Library/BaseUefiDecompressLib/BaseUefiDecompressLib.msa
+++ b/MdePkg/Library/BaseUefiDecompressLib/BaseUefiDecompressLib.msa
@@ -34,6 +34,7 @@
   </LibraryClassDefinitions>

   <SourceFiles>

     <Filename>BaseUefiDecompressLib.c</Filename>

+    <Filename>BaseUefiDecompressLibInternals.h</Filename>

   </SourceFiles>

   <PackageDependencies>

     <Package PackageGuid="5e0e9358-46b6-4ae2-8218-4ab8b9bbdcec"/>

diff --git a/MdePkg/Library/BaseUefiDecompressLib/BaseUefiDecompressLibInternals.h b/MdePkg/Library/BaseUefiDecompressLib/BaseUefiDecompressLibInternals.h
new file mode 100644
index 0000000000..70ae3f2974
--- /dev/null
+++ b/MdePkg/Library/BaseUefiDecompressLib/BaseUefiDecompressLibInternals.h
@@ -0,0 +1,215 @@
+/** @file

+  Internal include file for Base UEFI Decompress Libary.

+

+  Copyright (c) 2006, Intel Corporation

+  All rights reserved. This program and the accompanying materials

+  are licensed and made available under the terms and conditions of the BSD License

+  which accompanies this distribution.  The full text of the license may be found at

+  http://opensource.org/licenses/bsd-license.php

+

+  THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,

+  WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.

+

+  Module Name:  BaseUefiDecompressLibInternals.h

+

+**/

+

+#ifndef __BASE_UEFI_DECOMPRESS_LIB_INTERNALS_H__

+#define __BASE_UEFI_DECOMPRESS_LIB_INTERNALS_H__

+

+//

+// Decompression algorithm begins here

+//

+#define BITBUFSIZ 32

+#define MAXMATCH  256

+#define THRESHOLD 3

+#define CODE_BIT  16

+#define BAD_TABLE - 1

+

+//

+// C: Char&Len Set; P: Position Set; T: exTra Set

+//

+#define NC      (0xff + MAXMATCH + 2 - THRESHOLD)

+#define CBIT    9

+#define MAXPBIT 5

+#define TBIT    5

+#define MAXNP   ((1U << MAXPBIT) - 1)

+#define NT      (CODE_BIT + 3)

+#if NT > MAXNP

+#define NPT NT

+#else

+#define NPT MAXNP

+#endif

+

+typedef struct {

+  UINT8   *mSrcBase;  ///< Starting address of compressed data

+  UINT8   *mDstBase;  ///< Starting address of decompressed data

+  UINT32  mOutBuf;

+  UINT32  mInBuf;

+

+  UINT16  mBitCount;

+  UINT32  mBitBuf;

+  UINT32  mSubBitBuf;

+  UINT16  mBlockSize;

+  UINT32  mCompSize;

+  UINT32  mOrigSize;

+

+  UINT16  mBadTableFlag;

+

+  UINT16  mLeft[2 * NC - 1];

+  UINT16  mRight[2 * NC - 1];

+  UINT8   mCLen[NC];

+  UINT8   mPTLen[NPT];

+  UINT16  mCTable[4096];

+  UINT16  mPTTable[256];

+

+  ///

+  /// The length of the field 'Position Set Code Length Array Size' in Block Header.

+  /// For EFI 1.1 de/compression algorithm, mPBit = 4

+  /// For Tiano de/compression algorithm, mPBit = 5

+  ///

+  UINT8   mPBit;

+} SCRATCH_DATA;

+

+/**

+  Read NumOfBit of bits from source into mBitBuf

+

+  Shift mBitBuf NumOfBits left. Read in NumOfBits of bits from source.

+

+  @param  Sd        The global scratch data

+  @param  NumOfBits The number of bits to shift and read.

+

+**/

+VOID

+FillBuf (

+  IN  SCRATCH_DATA  *Sd,

+  IN  UINT16        NumOfBits

+  );

+

+/**

+  Get NumOfBits of bits out from mBitBuf

+

+  Get NumOfBits of bits out from mBitBuf. Fill mBitBuf with subsequent 

+  NumOfBits of bits from source. Returns NumOfBits of bits that are 

+  popped out.

+

+  @param  Sd        The global scratch data.

+  @param  NumOfBits The number of bits to pop and read.

+

+  @return The bits that are popped out.

+

+**/

+UINT32

+GetBits (

+  IN  SCRATCH_DATA  *Sd,

+  IN  UINT16        NumOfBits

+  );

+

+/**

+  Creates Huffman Code mapping table according to code length array.

+

+  Creates Huffman Code mapping table for Extra Set, Char&Len Set 

+  and Position Set according to code length array.

+

+  @param  Sd        The global scratch data

+  @param  NumOfChar Number of symbols in the symbol set

+  @param  BitLen    Code length array

+  @param  TableBits The width of the mapping table

+  @param  Table     The table

+

+  @retval  0 OK.

+  @retval  BAD_TABLE The table is corrupted.

+

+**/

+UINT16

+MakeTable (

+  IN  SCRATCH_DATA  *Sd,

+  IN  UINT16        NumOfChar,

+  IN  UINT8         *BitLen,

+  IN  UINT16        TableBits,

+  OUT UINT16        *Table

+  );

+

+/**

+  Decodes a position value.

+

+  Get a position value according to Position Huffman Table.

+  

+  @param  Sd the global scratch data

+

+  @return The position value decoded.

+

+**/

+UINT32

+DecodeP (

+  IN  SCRATCH_DATA  *Sd

+  );

+

+/**

+  Reads code lengths for the Extra Set or the Position Set.

+

+  Read in the Extra Set or Pointion Set Length Arrary, then

+  generate the Huffman code mapping for them.

+

+  @param  Sd      The global scratch data.

+  @param  nn      Number of symbols.

+  @param  nbit    Number of bits needed to represent nn.

+  @param  Special The special symbol that needs to be taken care of.

+

+  @retval  0 OK.

+  @retval  BAD_TABLE Table is corrupted.

+

+**/

+UINT16

+ReadPTLen (

+  IN  SCRATCH_DATA  *Sd,

+  IN  UINT16        nn,

+  IN  UINT16        nbit,

+  IN  UINT16        Special

+  );

+

+/**

+  Reads code lengths for Char&Len Set.

+  

+  Read in and decode the Char&Len Set Code Length Array, then

+  generate the Huffman Code mapping table for the Char&Len Set.

+

+  @param  Sd the global scratch data

+

+**/

+VOID

+ReadCLen (

+  SCRATCH_DATA  *Sd

+  );

+

+/**

+  Decode a character/length value.

+  

+  Read one value from mBitBuf, Get one code from mBitBuf. If it is at block boundary, generates

+  Huffman code mapping table for Extra Set, Code&Len Set and

+  Position Set.

+

+  @param  Sd The global scratch data.

+

+  @return The value decoded.

+

+**/

+UINT16

+DecodeC (

+  SCRATCH_DATA  *Sd

+  );

+

+/**

+  Decode the source data and put the resulting data into the destination buffer.

+

+  Decode the source data and put the resulting data into the destination buffer.

+  

+  @param  Sd The global scratch data

+

+**/

+VOID

+Decode (

+  SCRATCH_DATA  *Sd

+  );

+

+#endif