PeiSmbusLib & DxeSmbusLib

	Remove Arp Related interfaces
	Change the return type of SmbusQuickWrite from “BOOLEAN” to “VOID”
	Complete interface SmBusBlockProcessCall()
	Make the PEC bit “bit 21” of SMBUS address. If data show that MSB helps to save code size in BaseSmbusLib, we may simply redefine it to be MAX_BIT.
UefiLib
	Modify the interfaces in UefiNotTiano.c to sync with spec
MemoryAllocationLib
	Add extra checking in “Aligned” Memory services to prevent “AllocationSize + OverAllocation” overflow in DxeMemoryAllocationLib.


git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@23 6f19259b-4bc3-4df7-8a09-765794883524

1 files changed, 7 insertions, 59 deletions

diff --git a/MdePkg/Library/DxeSmbusLib/InternalSmbusLib.h b/MdePkg/Library/DxeSmbusLib/InternalSmbusLib.h
index 3c0b597fc5..bd6d57f2d3 100644
--- a/MdePkg/Library/DxeSmbusLib/InternalSmbusLib.h
+++ b/MdePkg/Library/DxeSmbusLib/InternalSmbusLib.h
@@ -18,11 +18,11 @@ Module Name: SmbusLib.c
 #ifndef __INTERNAL_SMBUS_LIB_H

 #define __INTERNAL_SMBUS_LIB_H

 

-#define SMBUS_LIB_PEC(SmBusAddress)           ((BOOLEAN) ((SmBusAddress) & 0x01))

-#define SMBUS_LIB_SLAVE_ADDRESS(SmBusAddress) (((SmBusAddress) >> 1)     & 0x7f)

-#define SMBUS_LIB_COMMAND(SmBusAddress)       (((SmBusAddress) >> 8)     & 0xff)

-#define SMBUS_LIB_LENGTH(SmBusAddress)        (((SmBusAddress) >> 16)    & 0x1f)

-#define SMBUS_LIB_RESEARVED(SmBusAddress)     (((SmBusAddress) >> 21))

+#define SMBUS_LIB_SLAVE_ADDRESS(SmBusAddress)      (((SmBusAddress) >> 1)  & 0x7f)

+#define SMBUS_LIB_COMMAND(SmBusAddress)            (((SmBusAddress) >> 8)  & 0xff)

+#define SMBUS_LIB_LENGTH(SmBusAddress)             (((SmBusAddress) >> 16) & 0x1f)

+#define SMBUS_LIB_PEC(SmBusAddress)     ((BOOLEAN) (((SmBusAddress) & SMBUS_LIB_PEC_BIT) != 0))

+#define SMBUS_LIB_RESEARVED(SmBusAddress)          ((SmBusAddress) & ~(((1 << 21) - 2) | SMBUS_LIB_PEC_BIT))

 

 //

 // Declaration for internal functions

@@ -45,7 +45,7 @@ Module Name: SmbusLib.c
   @param  Status          Return status for the executed command.

                           This is an optional parameter and may be NULL.

 

-  @return The actual number of bytes that are executed for this operation..

+  @return The actual number of bytes that are executed for this operation.

 

 **/

 UINTN

@@ -53,60 +53,8 @@ InternalSmBusExec (
   IN     EFI_SMBUS_OPERATION        SmbusOperation,

   IN     UINTN                      SmBusAddress,

   IN     UINTN                      Length,

-  IN     VOID                       *Buffer,

+  IN OUT VOID                       *Buffer,

      OUT RETURN_STATUS              *Status        OPTIONAL

   );

 

-/**

-  Assigns an SMBUS slave addresses.

-

-  Assigns the SMBUS device specified by Uuid the slave address specified by SmBusAddress.

-  The status of the executed command is returned.

-  If Command in SmBusAddress is not zero, then ASSERT().

-  If Length in SmBusAddress is not zero, then ASSERT().

-  If PEC in SmBusAddress is set, then ASSERT().

-  If any reserved bits of SmBusAddress are set, then ASSERT().

-

-  @param  SmBusAddress        Address that encodes the SMBUS Slave Address,

-                              SMBUS Command, SMBUS Data Length, and PEC.

-  @param  Uuid                Pointer to the UUID of the device to assign a slave address.

-                              It will assign to all SMBUS slave devices if it is NULL.

-

-  @retval RETURN_SUCCESS      The SMBUS command was executed.

-  @retval RETURN_TIMEOUT      A timeout occurred while executing the SMBUS command.

-  @retval RETURN_DEVICE_ERROR The request was not completed because a failure reflected

-                              in the Host Status Register bit.

-                              Device errors are a result of a transaction collision, illegal command field,

-                              unclaimed cycle (host initiated), or bus errors (collisions).

-

-**/

-RETURN_STATUS

-InternalSmBusArpDevice (

-  IN UINTN          SmBusAddress,

-  IN CONST GUID     *Uuid       OPTIONAL 

-  );

-

-/**

-  Retrieves the mapping of all the SMBus devices.

-

-  The GetArpMap() function returns the mapping of all the SMBus devices 

-  that are enumerated by the SMBus host driver. 

- 

-  @param  Length              Size of the buffer that contains the SMBus device map.

-  @param  SmbusDeviceMap      The pointer to the device map as enumerated by the SMBus controller driver.

-

-  @retval RETURN_SUCCESS      The SMBUS command was executed.

-  @retval RETURN_TIMEOUT      A timeout occurred while executing the SMBUS command.

-  @retval RETURN_DEVICE_ERROR The request was not completed because a failure reflected

-                              in the Host Status Register bit.

-                              Device errors are a result of a transaction collision, illegal command field,

-                              unclaimed cycle (host initiated), or bus errors (collisions).

-

-**/

-RETURN_STATUS

-InternalGetArpMap (

-  OUT UINTN                         *Length,

-  OUT EFI_SMBUS_DEVICE_MAP          **SmbusDeviceMap

-  );

-

 #endif