diff options
| author | xli24 <xli24@6f19259b-4bc3-4df7-8a09-765794883524> | 2008-11-24 05:55:41 +0000 |
|---|---|---|
| committer | xli24 <xli24@6f19259b-4bc3-4df7-8a09-765794883524> | 2008-11-24 05:55:41 +0000 |
| commit | e43e4b3e8cb381cffa146ac8c0f329bbb4c4b593 (patch) | |
| tree | c9a0a97fc0ba22542e50e8046c4c73ae742bb138 /MdePkg/Library/UefiSalLib/UefiSalLib.c | |
| parent | 519f076a478a7da9ff4b9d5327a993b1fc2968e8 (diff) | |
| download | edk2-platforms-e43e4b3e8cb381cffa146ac8c0f329bbb4c4b593.tar.xz | |
Refine new library instances according to review comments.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@6692 6f19259b-4bc3-4df7-8a09-765794883524
Diffstat (limited to 'MdePkg/Library/UefiSalLib/UefiSalLib.c')
| -rw-r--r-- | MdePkg/Library/UefiSalLib/UefiSalLib.c | 13 |
1 files changed, 7 insertions, 6 deletions
diff --git a/MdePkg/Library/UefiSalLib/UefiSalLib.c b/MdePkg/Library/UefiSalLib/UefiSalLib.c index e41cc0d980..f4319ed11c 100644 --- a/MdePkg/Library/UefiSalLib/UefiSalLib.c +++ b/MdePkg/Library/UefiSalLib/UefiSalLib.c @@ -1,5 +1,6 @@ /** @file
- SAL Library implementation built upon UEFI.
+ SAL Library implementation retrieving the SAL Entry Point from the SAL System Table
+ register in the EFI System Confguration Table.
Copyright (c) 2007 - 2008, Intel Corporation All rights
reserved. This program and the accompanying materials are
@@ -85,7 +86,7 @@ SalCall ( The constructor function looks up the SAL System Table in the EFI System Configuration
Table. Once the SAL System Table is found, the SAL Entry Point in the SAL System Table
- will be derived and stored inot a global variable for library usage.
+ will be derived and stored into a global variable for library usage.
It will ASSERT() if the SAL System Table cannot be found or the data in the SAL System
Table is not the valid data.
@@ -114,9 +115,9 @@ UefiSalLibConstructor ( ASSERT_EFI_ERROR (Status);
//
- // Move the SAL System Table point to the first Entry
- // Due to the SAL Entry is in ascending order with the Entry type,
- // the type 0 Entry should be the first if exist.
+ // Check the first entry of SAL System Table,
+ // because the SAL entry is in ascending order with the entry type,
+ // the type 0 entry should be the first if exist.
//
SalStEntryDes = (SAL_ST_ENTRY_POINT_DESCRIPTOR *)(SalSystemTable + 1);
@@ -128,7 +129,7 @@ UefiSalLibConstructor ( mPlabel.EntryPoint = SalStEntryDes->SalProcEntry;
mPlabel.GP = SalStEntryDes->SalGlobalDataPointer;
//
- // Make sure the EntryPoint has the real value
+ // Make sure the EntryPoint has the valid value
//
ASSERT ((mPlabel.EntryPoint != 0) && (mPlabel.GP != 0));
|