OvmfPkg/QemuVideoDxe: remove useless QEMU_VIDEO_PRIVATE_DATA.LineBuffer

This field is (re)allocated in QemuVideoGraphicsOutputSetMode(), released
in QemuVideoGraphicsOutputDestructor(), and used for nothing else. Remove
it.

Cc: Jordan Justen <jordan.l.justen@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Laszlo Ersek <lersek@redhat.com>
Reviewed-by: Jordan Justen <jordan.l.justen@intel.com>

2 files changed, 0 insertions, 17 deletions

diff --git a/OvmfPkg/QemuVideoDxe/Gop.c b/OvmfPkg/QemuVideoDxe/Gop.c
index 532f20e644..5485ba3c28 100644
--- a/OvmfPkg/QemuVideoDxe/Gop.c
+++ b/OvmfPkg/QemuVideoDxe/Gop.c
@@ -167,15 +167,6 @@ Routine Description:
 

   ModeData = &Private->ModeData[ModeNumber];

 

-  if (Private->LineBuffer) {

-    gBS->FreePool (Private->LineBuffer);

-  }

-

-  Private->LineBuffer = AllocatePool (4 * ModeData->HorizontalResolution);

-  if (Private->LineBuffer == NULL) {

-    return EFI_OUT_OF_RESOURCES;

-  }

-

   switch (Private->Variant) {

   case QEMU_VIDEO_CIRRUS_5430:

   case QEMU_VIDEO_CIRRUS_5446:

@@ -187,8 +178,6 @@ Routine Description:
     break;

   default:

     ASSERT (FALSE);

-    gBS->FreePool (Private->LineBuffer);

-    Private->LineBuffer = NULL;

     return EFI_DEVICE_ERROR;

   }

 

@@ -349,7 +338,6 @@ QemuVideoGraphicsOutputConstructor (
   }

   Private->GraphicsOutput.Mode->MaxMode = (UINT32) Private->MaxMode;

   Private->GraphicsOutput.Mode->Mode    = GRAPHICS_OUTPUT_INVALIDE_MODE_NUMBER;

-  Private->LineBuffer                   = NULL;

   Private->FrameBufferBltConfigure      = NULL;

   Private->FrameBufferBltConfigureSize  = 0;

 

@@ -395,10 +383,6 @@ Returns:
 

 --*/

 {

-  if (Private->LineBuffer != NULL) {

-    FreePool (Private->LineBuffer);

-  }

-

   if (Private->FrameBufferBltConfigure != NULL) {

     FreePool (Private->FrameBufferBltConfigure);

   }

diff --git a/OvmfPkg/QemuVideoDxe/Qemu.h b/OvmfPkg/QemuVideoDxe/Qemu.h
index f3358d8a7c..2ce37defc5 100644
--- a/OvmfPkg/QemuVideoDxe/Qemu.h
+++ b/OvmfPkg/QemuVideoDxe/Qemu.h
@@ -116,7 +116,6 @@ typedef struct {
   UINTN                                 MaxMode;

   QEMU_VIDEO_MODE_DATA                  *ModeData;

 

-  UINT8                                 *LineBuffer;

   QEMU_VIDEO_VARIANT                    Variant;

   FRAME_BUFFER_CONFIGURE                *FrameBufferBltConfigure;

   UINTN                                 FrameBufferBltConfigureSize;