summaryrefslogtreecommitdiff
path: root/OvmfPkg
diff options
context:
space:
mode:
authorLaszlo Ersek <lersek@redhat.com>2015-07-14 12:02:01 +0000
committerlersek <lersek@Edk2>2015-07-14 12:02:01 +0000
commit6c46498875b7f67b2e3edf5a4bdb4c34f529236f (patch)
treee2584e56a931c9c6cba1cf9f1da248ea3e52e0ce /OvmfPkg
parent7f66476701a1ad15af762750e643b499a4d856a7 (diff)
downloadedk2-platforms-6c46498875b7f67b2e3edf5a4bdb4c34f529236f.tar.xz
OvmfPkg: PciHostBridgeDxe: kill RootBridgeNumber and RootBridgeAttribute
There is no need to store these constants in dedicated static storage duration objects; we can simply open-code them, simplifying the code. Cc: Jordan Justen <jordan.l.justen@intel.com> Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Laszlo Ersek <lersek@redhat.com> Regression-tested-by: Gabriel Somlo <somlo@cmu.edu> Reviewed-by: Jordan Justen <jordan.l.justen@intel.com> git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@17956 6f19259b-4bc3-4df7-8a09-765794883524
Diffstat (limited to 'OvmfPkg')
-rw-r--r--OvmfPkg/PciHostBridgeDxe/PciHostBridge.c13
1 files changed, 3 insertions, 10 deletions
diff --git a/OvmfPkg/PciHostBridgeDxe/PciHostBridge.c b/OvmfPkg/PciHostBridgeDxe/PciHostBridge.c
index 33cf119814..985290928d 100644
--- a/OvmfPkg/PciHostBridgeDxe/PciHostBridge.c
+++ b/OvmfPkg/PciHostBridgeDxe/PciHostBridge.c
@@ -18,16 +18,9 @@
#include "PciHostBridge.h"
//
-// Hard code: Root Bridge Number within the host bridge
-// Root Bridge's attribute
-// Root Bridge's device path
+// Hard code: Root Bridge's device path
// Root Bridge's resource aperture
//
-UINTN RootBridgeNumber = 1;
-
-UINT64 RootBridgeAttribute[1] = {
- EFI_PCI_HOST_BRIDGE_COMBINE_MEM_PMEM
-};
EFI_PCI_ROOT_BRIDGE_DEVICE_PATH mEfiPciRootBridgeDevicePath[1] = {
{
@@ -117,7 +110,7 @@ InitializePciHostBridge (
return EFI_OUT_OF_RESOURCES;
}
- HostBridge->RootBridgeNumber = RootBridgeNumber;
+ HostBridge->RootBridgeNumber = 1;
InitializeListHead (&HostBridge->Head);
Status = gBS->InstallMultipleProtocolInterfaces (
@@ -148,7 +141,7 @@ InitializePciHostBridge (
RootBridgeConstructor (
&PrivateData->Io,
HostBridge->HostBridgeHandle,
- RootBridgeAttribute[Loop2],
+ EFI_PCI_HOST_BRIDGE_COMBINE_MEM_PMEM,
&mResAperture[Loop2]
);