diff options
| author | jcarsey <jcarsey@6f19259b-4bc3-4df7-8a09-765794883524> | 2011-06-30 22:25:46 +0000 |
|---|---|---|
| committer | jcarsey <jcarsey@6f19259b-4bc3-4df7-8a09-765794883524> | 2011-06-30 22:25:46 +0000 |
| commit | f1518f69703e1086f346a6e9d8e5a59855954178 (patch) | |
| tree | 4b4063efe03eb5383c15399998731dde6d212c14 /ShellPkg | |
| parent | 92d4b03fccc691698f83f6ee79b1da0417f98e7c (diff) | |
| download | edk2-platforms-f1518f69703e1086f346a6e9d8e5a59855954178.tar.xz | |
add fixes for code verification happyness.
signed-off-by: jcarsey
reviewed-by: jljusten
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@11935 6f19259b-4bc3-4df7-8a09-765794883524
Diffstat (limited to 'ShellPkg')
| -rw-r--r-- | ShellPkg/Library/UefiShellLevel1CommandsLib/If.c | 4 | ||||
| -rw-r--r-- | ShellPkg/Library/UefiShellLevel2CommandsLib/Cp.c | 5 |
2 files changed, 9 insertions, 0 deletions
diff --git a/ShellPkg/Library/UefiShellLevel1CommandsLib/If.c b/ShellPkg/Library/UefiShellLevel1CommandsLib/If.c index 1d83f8a246..62c713e589 100644 --- a/ShellPkg/Library/UefiShellLevel1CommandsLib/If.c +++ b/ShellPkg/Library/UefiShellLevel1CommandsLib/If.c @@ -95,6 +95,10 @@ IsValidProfile ( CONST CHAR16 *TempLocation;
ProfilesString = ShellGetEnvironmentVariable(L"profiles");
+ //
+ // According to the Shell spec this is a required environment variable.
+ //
+ ASSERT(ProfileString != NULL);
TempLocation = StrStr(ProfilesString, String);
if ((TempLocation != NULL) && (*(TempLocation-1) == L';') && (*(TempLocation+StrLen(String)) == L';')) {
return (TRUE);
diff --git a/ShellPkg/Library/UefiShellLevel2CommandsLib/Cp.c b/ShellPkg/Library/UefiShellLevel2CommandsLib/Cp.c index d09d2ec7a7..8b30ac3122 100644 --- a/ShellPkg/Library/UefiShellLevel2CommandsLib/Cp.c +++ b/ShellPkg/Library/UefiShellLevel2CommandsLib/Cp.c @@ -255,6 +255,11 @@ ValidateAndCopyFiles( ASSERT(DestDir != NULL);
//
+ // We already verified that this was present.
+ //
+ ASSERT(Cwd != NULL);
+
+ //
// If we are trying to copy multiple files... make sure we got a directory for the target...
//
if (EFI_ERROR(ShellIsDirectory(DestDir)) && FileList->Link.ForwardLink != FileList->Link.BackLink) {
|