diff options
| author | Jeff Fan <jeff.fan@intel.com> | 2013-12-20 05:49:15 +0000 |
|---|---|---|
| committer | vanjeff <vanjeff@6f19259b-4bc3-4df7-8a09-765794883524> | 2013-12-20 05:49:15 +0000 |
| commit | 4692bc0b81d822e467435c7a7b9e6470dff1b8d2 (patch) | |
| tree | fcb505fef9eb46c2d1f486cd89b64f74b2bf287e /SourceLevelDebugPkg/Library | |
| parent | f3b113bf614119f4b54858f909606954be75b3f3 (diff) | |
| download | edk2-platforms-4692bc0b81d822e467435c7a7b9e6470dff1b8d2.tar.xz | |
Only save HostSequenceNo for new command in Debug Timer handler.
Signed-off-by: Jeff Fan <jeff.fan@intel.com>
Reviewed-by: Ruiyu Ni <ruiyu.ni@intel.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@15013 6f19259b-4bc3-4df7-8a09-765794883524
Diffstat (limited to 'SourceLevelDebugPkg/Library')
| -rw-r--r-- | SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/DebugAgent.c | 21 |
1 files changed, 18 insertions, 3 deletions
diff --git a/SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/DebugAgent.c b/SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/DebugAgent.c index 239cf63f6b..91b29af82a 100644 --- a/SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/DebugAgent.c +++ b/SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/DebugAgent.c @@ -374,6 +374,7 @@ UpdateMailboxContent ( Mailbox->SequenceNo = (UINT8) Value;
break;
case DEBUG_MAILBOX_HOST_SEQUENCE_NO_INDEX:
+ DebugAgentMsgPrint (DEBUG_AGENT_INFO, "Update HostSequenceNo to %x\n", Value);
Mailbox->ToBeCheckSum = Mailbox->CheckSum + CalculateSum8 ((UINT8 *)&Mailbox->HostSequenceNo, sizeof(UINT8))
- CalculateSum8 ((UINT8 *)&Value, sizeof(UINT8));
Mailbox->HostSequenceNo = (UINT8) Value;
@@ -572,6 +573,7 @@ DebugAgentDataMsgPrint ( @retval EFI_SUCCESS Read the symbol in BreakSymbol.
@retval EFI_CRC_ERROR CRC check fail.
@retval EFI_TIMEOUT Timeout occurs when reading debug packet.
+ @retval EFI_DEVICE_ERROR Receive the old or responsed packet.
**/
EFI_STATUS
@@ -581,6 +583,8 @@ ReadRemainingBreakPacket ( )
{
UINT16 Crc;
+ DEBUG_AGENT_MAILBOX *Mailbox;
+
//
// Has received start symbol, try to read the rest part
//
@@ -599,9 +603,20 @@ ReadRemainingBreakPacket ( DebugAgentDataMsgPrint (DEBUG_AGENT_VERBOSE, FALSE, (UINT8 *)DebugHeader, DebugHeader->Length);
return EFI_CRC_ERROR;
}
-
- UpdateMailboxContent (GetMailboxPointer(), DEBUG_MAILBOX_HOST_SEQUENCE_NO_INDEX, DebugHeader->SequenceNo);
- return EFI_SUCCESS;
+ Mailbox = GetMailboxPointer();
+ if (((DebugHeader->Command & DEBUG_COMMAND_RESPONSE) != 0) &&
+ (DebugHeader->SequenceNo == (UINT8) (Mailbox->HostSequenceNo + 1))) {
+ //
+ // Only updagte HostSequenceNo for new command packet
+ //
+ UpdateMailboxContent (Mailbox, DEBUG_MAILBOX_HOST_SEQUENCE_NO_INDEX, DebugHeader->SequenceNo);
+ return EFI_SUCCESS;
+ } else {
+ //
+ // If one old command or response packet received, skip it
+ //
+ return EFI_DEVICE_ERROR;
+ }
}
/**
|