diff options
| -rw-r--r-- | MdeModulePkg/Core/Pei/BootMode/BootMode.c | 2 | ||||
| -rw-r--r-- | MdeModulePkg/Core/Pei/Dispatcher/Dispatcher.c | 3 | ||||
| -rw-r--r-- | MdeModulePkg/Core/Pei/FwVol/FwVol.c | 2 | ||||
| -rw-r--r-- | MdeModulePkg/Core/Pei/Image/Image.c | 2 | ||||
| -rw-r--r-- | MdeModulePkg/Core/Pei/PeiMain.h | 11 |
5 files changed, 7 insertions, 13 deletions
diff --git a/MdeModulePkg/Core/Pei/BootMode/BootMode.c b/MdeModulePkg/Core/Pei/BootMode/BootMode.c index 8c38fa8dc6..74b90529ae 100644 --- a/MdeModulePkg/Core/Pei/BootMode/BootMode.c +++ b/MdeModulePkg/Core/Pei/BootMode/BootMode.c @@ -32,7 +32,7 @@ EFI_STATUS EFIAPI
PeiGetBootMode (
IN CONST EFI_PEI_SERVICES **PeiServices,
- OUT EFI_BOOT_MODE *BootMode
+ IN OUT EFI_BOOT_MODE *BootMode
)
{
PEI_CORE_INSTANCE *PrivateData;
diff --git a/MdeModulePkg/Core/Pei/Dispatcher/Dispatcher.c b/MdeModulePkg/Core/Pei/Dispatcher/Dispatcher.c index 49b3d36864..54b145b8f0 100644 --- a/MdeModulePkg/Core/Pei/Dispatcher/Dispatcher.c +++ b/MdeModulePkg/Core/Pei/Dispatcher/Dispatcher.c @@ -231,9 +231,6 @@ ShadowPeiCore( the BFV location.
@param Private Pointer to the private data passed in from caller
- @retval EFI_SUCCESS - Successfully dispatched PEIM.
- @retval EFI_NOT_FOUND - The dispatch failed.
-
**/
VOID
PeiDispatcher (
diff --git a/MdeModulePkg/Core/Pei/FwVol/FwVol.c b/MdeModulePkg/Core/Pei/FwVol/FwVol.c index 37ddb797fe..807476fba4 100644 --- a/MdeModulePkg/Core/Pei/FwVol/FwVol.c +++ b/MdeModulePkg/Core/Pei/FwVol/FwVol.c @@ -163,7 +163,7 @@ PeiFindFileEx ( FileHeader = (EFI_FFS_FILE_HEADER **)FileHandle;
FvLength = FwVolHeader->FvLength;
- if (FwVolHeader->Attributes & EFI_FVB2_ERASE_POLARITY) {
+ if ((FwVolHeader->Attributes & EFI_FVB2_ERASE_POLARITY) != 0) {
ErasePolarity = 1;
} else {
ErasePolarity = 0;
diff --git a/MdeModulePkg/Core/Pei/Image/Image.c b/MdeModulePkg/Core/Pei/Image/Image.c index 25c6330db7..4918c1a6da 100644 --- a/MdeModulePkg/Core/Pei/Image/Image.c +++ b/MdeModulePkg/Core/Pei/Image/Image.c @@ -78,7 +78,7 @@ PeiImageRead ( Destination8 = Buffer;
Source8 = (CHAR8 *) ((UINTN) FileHandle + FileOffset);
Length = *ReadSize;
- while (Length--) {
+ while ((Length--) > 0) {
*(Destination8++) = *(Source8++);
}
diff --git a/MdeModulePkg/Core/Pei/PeiMain.h b/MdeModulePkg/Core/Pei/PeiMain.h index 6f040d0155..4e66b71bee 100644 --- a/MdeModulePkg/Core/Pei/PeiMain.h +++ b/MdeModulePkg/Core/Pei/PeiMain.h @@ -234,7 +234,7 @@ EFI_STATUS EFIAPI
PeiCore (
IN CONST EFI_SEC_PEI_HAND_OFF *SecCoreData,
- IN CONST EFI_PEI_PPI_DESCRIPTOR *PpList,
+ IN CONST EFI_PEI_PPI_DESCRIPTOR *PpiList,
IN VOID *Data
);
@@ -274,9 +274,6 @@ PeimDispatchReadiness ( @param SecCoreData Pointer to the data structure containing SEC to PEI handoff data
@param PrivateData Pointer to the private data passed in from caller
- @retval EFI_SUCCESS Successfully dispatched PEIM.
- @retval EFI_NOT_FOUND The dispatch failed.
-
**/
VOID
PeiDispatcher (
@@ -500,7 +497,7 @@ EFI_STATUS EFIAPI
PeiGetBootMode (
IN CONST EFI_PEI_SERVICES **PeiServices,
- IN OUT EFI_BOOT_MODE *BootMode
+ IN OUT EFI_BOOT_MODE *BootMode
);
/**
@@ -539,7 +536,7 @@ InitializeSecurityServices ( );
/**
- Verify a Firmware volume
+ Verify a Firmware volume.
@param CurrentFvAddress Pointer to the current Firmware Volume under consideration
@@ -1016,7 +1013,7 @@ InitializeImageServices ( Get Fv image from the FV type file, then install FV INFO ppi, Build FV hob.
@param PeiServices An indirect pointer to the EFI_PEI_SERVICES table published by the PEI Foundation.
- @param FileHandle File handle of a Fv type file.
+ @param FvFileHandle File handle of a Fv type file.
@param AuthenticationState Pointer to attestation authentication state of image.
If return 0, means pass security checking.
|