From 3454e932107c7524f6a89fcab35d430d0b422b2e Mon Sep 17 00:00:00 2001 From: Marcin Wojtas Date: Wed, 18 Apr 2018 03:54:35 +0200 Subject: Marvell/Drivers: MvFvbDxe: Fix uninstallation of protocol Recently added installation of gEdkiiNvVarStoreFormattedGuid introduced bug in the error path. gBS->UninstallProtocolInterface takes an actual handle as an argument (not the pointer). Fix this and on the occasion fix indentation of multiline call. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Marcin Wojtas Reviewed-by: Ard Biesheuvel --- Silicon/Marvell/Drivers/Spi/MvFvbDxe/MvFvbDxe.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/Silicon/Marvell/Drivers/Spi/MvFvbDxe/MvFvbDxe.c b/Silicon/Marvell/Drivers/Spi/MvFvbDxe/MvFvbDxe.c index 6e583a381f..1a41a4f47e 100644 --- a/Silicon/Marvell/Drivers/Spi/MvFvbDxe/MvFvbDxe.c +++ b/Silicon/Marvell/Drivers/Spi/MvFvbDxe/MvFvbDxe.c @@ -1142,9 +1142,9 @@ ErrorSetMemAttr: gDS->RemoveMemorySpace (RegionBaseAddress, RuntimeMmioRegionSize); ErrorAddSpace: - gBS->UninstallProtocolInterface (&gImageHandle, - &gEdkiiNvVarStoreFormattedGuid, - NULL); + gBS->UninstallProtocolInterface (gImageHandle, + &gEdkiiNvVarStoreFormattedGuid, + NULL); ErrorInstallNvVarStoreFormatted: gBS->UninstallMultipleProtocolInterfaces (&mFvbDevice->Handle, -- cgit v1.2.3