From 3532030489e93e67703a3c3df53fd9dfdee68f97 Mon Sep 17 00:00:00 2001 From: Qiu Shumin Date: Fri, 19 Dec 2014 02:37:53 +0000 Subject: Code refine. Check the original length of array to avoid buffer over flow. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Qiu Shumin Reviewed-by: Fu Siyuan git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@16539 6f19259b-4bc3-4df7-8a09-765794883524 --- NetworkPkg/IScsiDxe/IScsiMisc.c | 1 + 1 file changed, 1 insertion(+) diff --git a/NetworkPkg/IScsiDxe/IScsiMisc.c b/NetworkPkg/IScsiDxe/IScsiMisc.c index 05f639aaee..aeb99e5f94 100644 --- a/NetworkPkg/IScsiDxe/IScsiMisc.c +++ b/NetworkPkg/IScsiDxe/IScsiMisc.c @@ -226,6 +226,7 @@ IScsiLunToUnicodeStr ( // // Remove the last '-' // + ASSERT (StrLen(Str) >= 1); Str[StrLen (Str) - 1] = 0; for (Index = StrLen (Str) - 1; Index > 1; Index = Index - 2) { -- cgit v1.2.3