From 534c4ad39c9a8693ea69989fee98e0e99a23433b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Marvin=20H=C3=A4user?= Date: Tue, 27 Feb 2018 23:28:40 +0100 Subject: MinPlatformPkg/DxePlatformBootManagerLib: Add missing ASSERTs. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Marvin Haeuser Reviewed-by: Jiewen Yao --- .../DxePlatformBootManagerLib/BdsPlatform.c | 23 ++++++++++++++++------ 1 file changed, 17 insertions(+), 6 deletions(-) diff --git a/Platform/Intel/MinPlatformPkg/Bds/Library/DxePlatformBootManagerLib/BdsPlatform.c b/Platform/Intel/MinPlatformPkg/Bds/Library/DxePlatformBootManagerLib/BdsPlatform.c index 8fd31df876..0e2fed1f72 100644 --- a/Platform/Intel/MinPlatformPkg/Bds/Library/DxePlatformBootManagerLib/BdsPlatform.c +++ b/Platform/Intel/MinPlatformPkg/Bds/Library/DxePlatformBootManagerLib/BdsPlatform.c @@ -979,8 +979,12 @@ ChangeModeForInternalShell ( // // Update text mode PCD. // - PcdSet32S (PcdConOutColumn, mShellModeColumn); - PcdSet32S (PcdConOutRow, mShellModeRow); + Status = PcdSet32S (PcdConOutColumn, mShellModeColumn); + ASSERT_EFI_ERROR (Status); + + Status = PcdSet32S (PcdConOutRow, mShellModeRow); + ASSERT_EFI_ERROR (Status); + FreePool (Info); return EFI_SUCCESS; } @@ -1006,10 +1010,17 @@ ChangeModeForInternalShell ( // Set PCD to restart GraphicsConsole and Consplitter to change video resolution // and produce new text mode based on new resolution. // - PcdSet32S (PcdVideoHorizontalResolution, mShellHorizontalResolution); - PcdSet32S (PcdVideoVerticalResolution, mShellVerticalResolution); - PcdSet32S (PcdConOutColumn, mShellModeColumn); - PcdSet32S (PcdConOutRow, mShellModeRow); + Status = PcdSet32S (PcdVideoHorizontalResolution, mShellHorizontalResolution); + ASSERT_EFI_ERROR (Status); + + Status = PcdSet32S (PcdVideoVerticalResolution, mShellVerticalResolution); + ASSERT_EFI_ERROR (Status); + + Status = PcdSet32S (PcdConOutColumn, mShellModeColumn); + ASSERT_EFI_ERROR (Status); + + Status = PcdSet32S (PcdConOutRow, mShellModeRow); + ASSERT_EFI_ERROR (Status); Status = gBS->LocateHandleBuffer ( ByProtocol, -- cgit v1.2.3