From de3ecb331fc45550d41d35110948cb96e32df08a Mon Sep 17 00:00:00 2001 From: Hao Wu Date: Mon, 11 Jan 2016 00:34:36 +0000 Subject: PcAtChipsetPkg SerialIoLib: Fix VS2010 build error When overriding compiler options '/GL' with '/GL-', VS2010 will report warning C4701 potentially uninitialized local variable for 'LcrParity' and 'LcrStop' in function SerialPortSetAttributes(). This commit fixes this build issue. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Hao Wu Reviewed-by: Star Zeng git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@19629 6f19259b-4bc3-4df7-8a09-765794883524 --- PcAtChipsetPkg/Library/SerialIoLib/SerialPortLib.c | 14 +++----------- 1 file changed, 3 insertions(+), 11 deletions(-) diff --git a/PcAtChipsetPkg/Library/SerialIoLib/SerialPortLib.c b/PcAtChipsetPkg/Library/SerialIoLib/SerialPortLib.c index 8656785347..1bbb1a2584 100644 --- a/PcAtChipsetPkg/Library/SerialIoLib/SerialPortLib.c +++ b/PcAtChipsetPkg/Library/SerialIoLib/SerialPortLib.c @@ -1,7 +1,7 @@ /** @file UART Serial Port library functions - Copyright (c) 2006 - 2015, Intel Corporation. All rights reserved.
+ Copyright (c) 2006 - 2016, Intel Corporation. All rights reserved.
This program and the accompanying materials are licensed and made available under the terms and conditions of the BSD License which accompanies this distribution. The full text of the license may be found at @@ -417,14 +417,6 @@ SerialPortSetAttributes ( return RETURN_INVALID_PARAMETER; } - if ((*Parity < NoParity) || (*Parity > SpaceParity)) { - return RETURN_INVALID_PARAMETER; - } - - if ((*StopBits < OneStopBit) || (*StopBits > TwoStopBits)) { - return RETURN_INVALID_PARAMETER; - } - // // Map 5..8 to 0..3 // @@ -452,7 +444,7 @@ SerialPortSetAttributes ( break; default: - break; + return RETURN_INVALID_PARAMETER; } switch (*StopBits) { @@ -466,7 +458,7 @@ SerialPortSetAttributes ( break; default: - break; + return RETURN_INVALID_PARAMETER; } // -- cgit v1.2.3