From 65e27445877ff101115c79e76928d91bf7625876 Mon Sep 17 00:00:00 2001 From: andrewfish Date: Tue, 16 Feb 2010 23:45:42 +0000 Subject: Fix bug in UncachedMemoryAllocationLib, Assembler, make DefaultExceptionHandler lib inc the PC past the faulting instruction to aid debug. Update LR in Exception hanlder, so return address can get updated properly. git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@10018 6f19259b-4bc3-4df7-8a09-765794883524 --- ArmPkg/Library/ArmDisassemblerLib/ThumbDisassembler.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) (limited to 'ArmPkg/Library/ArmDisassemblerLib/ThumbDisassembler.c') diff --git a/ArmPkg/Library/ArmDisassemblerLib/ThumbDisassembler.c b/ArmPkg/Library/ArmDisassemblerLib/ThumbDisassembler.c index 8b3132cc99..d46a4fa2c3 100644 --- a/ArmPkg/Library/ArmDisassemblerLib/ThumbDisassembler.c +++ b/ArmPkg/Library/ArmDisassemblerLib/ThumbDisassembler.c @@ -339,7 +339,7 @@ THUMB_INSTRUCTIONS gOpThumb2[] = { { "LDR", 0xf8500800, 0xfff00800, LDM_REG_IMM8 }, // LDR , [, {, #]} { "LDRBT", 0xf8100e00, 0xfff00f00, LDM_REG_IMM8 }, // LDRBT , [, {, #]} { "LDRHT", 0xf8300e00, 0xfff00f00, LDM_REG_IMM8 }, // LDRHT , [, {, #]} - { "LDRSB", 0xf9900800, 0xfff00800, LDM_REG_IMM8 }, // LDRHT , [, {, #]} {!} form? + { "LDRSB", 0xf9100800, 0xfff00800, LDM_REG_IMM8 }, // LDRHT , [, {, #]} {!} form? { "LDRSBT",0xf9100e00, 0xfff00f00, LDM_REG_IMM8 }, // LDRHBT , [, {, #]} {!} form? { "LDRSH" ,0xf9300800, 0xfff00800, LDM_REG_IMM8 }, // LDRSH , [, {, #]} { "LDRSHT",0xf9300e00, 0xfff00f00, LDM_REG_IMM8 }, // LDRSHT , [, {, #]} @@ -791,7 +791,6 @@ DisassembleThumbInstruction ( return; case LDM_REG_IMM8: - ASSERT (FALSE); // , [, {, #}]{!} W = (OpCode32 & BIT8) == BIT8; U = (OpCode32 & BIT9) == BIT9; @@ -801,10 +800,10 @@ DisassembleThumbInstruction ( if ((OpCode32 && 0xff) == 0) { AsciiSPrint (&Buf[Offset], Size - Offset, "]%a", W?"!":""); } else { - AsciiSPrint (&Buf[Offset], Size - Offset, ", #%a0x%x]%a", OpCode32 & 0xff, U?"":"-" , W?"!":""); + AsciiSPrint (&Buf[Offset], Size - Offset, ", #%a0x%x]%a", U?"":"-" , OpCode32 & 0xff, W?"!":""); } } else { - AsciiSPrint (&Buf[Offset], Size - Offset, "], #%a0x%x]", OpCode32 & 0xff, U?"":"-"); + AsciiSPrint (&Buf[Offset], Size - Offset, "], #%a0x%x", U?"":"-", OpCode32 & 0xff); } return; -- cgit v1.2.3