From 3ad72779aa97fcde5262b072edc69967da3bdc82 Mon Sep 17 00:00:00 2001 From: Ard Biesheuvel Date: Wed, 13 Apr 2016 10:04:24 +0200 Subject: ArmPlatformPkg/PL031RealTimeClockLib: don't clobber gRT table PL031RealTimeClockLib is a base library that could potentially (although unlikely) be incorporated into other modules than the DXE_RUNTIME_DRIVER module that it was intended to complement. This means the library has no business whatsoever setting the Runtime Service table pointers directly (since we have no way of knowing which instance will 'win', and the pointers may end up referring to a module that is not a DXE_RUNTIME_DRIVER). So remove the assignment altogether. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel Reviewed-by: Leif Lindholm --- .../Library/PL031RealTimeClockLib/PL031RealTimeClockLib.c | 6 ------ 1 file changed, 6 deletions(-) (limited to 'ArmPlatformPkg') diff --git a/ArmPlatformPkg/Library/PL031RealTimeClockLib/PL031RealTimeClockLib.c b/ArmPlatformPkg/Library/PL031RealTimeClockLib/PL031RealTimeClockLib.c index 52ba48992b..516b45675c 100644 --- a/ArmPlatformPkg/Library/PL031RealTimeClockLib/PL031RealTimeClockLib.c +++ b/ArmPlatformPkg/Library/PL031RealTimeClockLib/PL031RealTimeClockLib.c @@ -650,12 +650,6 @@ LibRtcInitialize ( return Status; } - // Setup the setters and getters - gRT->GetTime = LibGetTime; - gRT->SetTime = LibSetTime; - gRT->GetWakeupTime = LibGetWakeupTime; - gRT->SetWakeupTime = LibSetWakeupTime; - mRT = gRT; // Install the protocol -- cgit v1.2.3