From a79d29b6d340529029630af05c44a904827b2b63 Mon Sep 17 00:00:00 2001 From: Laszlo Ersek Date: Fri, 21 Oct 2016 11:59:36 +0200 Subject: ArmVirtPkg/ArmVirtPL031FdtClientLib: eliminate unchecked PcdSetXX() calls These are deprecated / disabled under the DISABLE_NEW_DEPRECATED_INTERFACES feature test macro. Introduce a variable called PcdStatus, and use it to assert the success of these operations (there is no reason for them to fail here). Cc: Ard Biesheuvel Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=165 Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Laszlo Ersek Reviewed-by: Ard Biesheuvel Tested-by: Ard Biesheuvel # RVCT Reviewed-by: Jordan Justen --- .../Library/ArmVirtPL031FdtClientLib/ArmVirtPL031FdtClientLib.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) (limited to 'ArmVirtPkg/Library') diff --git a/ArmVirtPkg/Library/ArmVirtPL031FdtClientLib/ArmVirtPL031FdtClientLib.c b/ArmVirtPkg/Library/ArmVirtPL031FdtClientLib/ArmVirtPL031FdtClientLib.c index 3c4e44caa2..82de7a51b3 100644 --- a/ArmVirtPkg/Library/ArmVirtPL031FdtClientLib/ArmVirtPL031FdtClientLib.c +++ b/ArmVirtPkg/Library/ArmVirtPL031FdtClientLib/ArmVirtPL031FdtClientLib.c @@ -34,6 +34,7 @@ ArmVirtPL031FdtClientLibConstructor ( CONST UINT64 *Reg; UINT32 RegSize; UINT64 RegBase; + RETURN_STATUS PcdStatus; Status = gBS->LocateProtocol (&gFdtClientProtocolGuid, NULL, (VOID **)&FdtClient); @@ -60,7 +61,8 @@ ArmVirtPL031FdtClientLibConstructor ( RegBase = SwapBytes64 (Reg[0]); ASSERT (RegBase < MAX_UINT32); - PcdSet32 (PcdPL031RtcBase, (UINT32)RegBase); + PcdStatus = PcdSet32S (PcdPL031RtcBase, (UINT32)RegBase); + ASSERT_RETURN_ERROR (PcdStatus); DEBUG ((EFI_D_INFO, "Found PL031 RTC @ 0x%Lx\n", RegBase)); -- cgit v1.2.3