From 97404058f1752da8fa2ba531e592491c65cb29f1 Mon Sep 17 00:00:00 2001 From: hfang Date: Thu, 25 Dec 2008 08:59:02 +0000 Subject: Fixup for review git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7120 6f19259b-4bc3-4df7-8a09-765794883524 --- IntelFrameworkModulePkg/Bus/Pci/IdeBusDxe/Ata.c | 32 ++--- IntelFrameworkModulePkg/Bus/Pci/IdeBusDxe/Atapi.c | 32 ++--- .../Bus/Pci/IdeBusDxe/ComponentName.h | 2 +- .../Bus/Pci/IdeBusDxe/DriverConfiguration.c | 6 +- IntelFrameworkModulePkg/Bus/Pci/IdeBusDxe/Ide.c | 42 +++---- IntelFrameworkModulePkg/Bus/Pci/IdeBusDxe/Ide.h | 140 ++++++++++----------- IntelFrameworkModulePkg/Bus/Pci/IdeBusDxe/IdeBus.c | 4 +- IntelFrameworkModulePkg/Bus/Pci/IdeBusDxe/IdeBus.h | 24 ++-- 8 files changed, 138 insertions(+), 144 deletions(-) (limited to 'IntelFrameworkModulePkg/Bus/Pci/IdeBusDxe') diff --git a/IntelFrameworkModulePkg/Bus/Pci/IdeBusDxe/Ata.c b/IntelFrameworkModulePkg/Bus/Pci/IdeBusDxe/Ata.c index 72941e93d4..a91eb174c1 100644 --- a/IntelFrameworkModulePkg/Bus/Pci/IdeBusDxe/Ata.c +++ b/IntelFrameworkModulePkg/Bus/Pci/IdeBusDxe/Ata.c @@ -630,7 +630,7 @@ CheckErrorStatus ( DEBUG_CODE_BEGIN (); - if (StatusRegister & ATA_STSREG_DWF) { + if ((StatusRegister & ATA_STSREG_DWF) != 0) { DEBUG ( (EFI_D_BLKIO, "CheckErrorStatus()-- %02x : Error : Write Fault\n", @@ -638,7 +638,7 @@ CheckErrorStatus ( ); } - if (StatusRegister & ATA_STSREG_CORR) { + if ((StatusRegister & ATA_STSREG_CORR) != 0) { DEBUG ( (EFI_D_BLKIO, "CheckErrorStatus()-- %02x : Error : Corrected Data\n", @@ -646,10 +646,10 @@ CheckErrorStatus ( ); } - if (StatusRegister & ATA_STSREG_ERR) { + if ((StatusRegister & ATA_STSREG_ERR) != 0) { ErrorRegister = IDEReadPortB (IdeDev->PciIo, IdeDev->IoPort->Reg1.Error); - if (ErrorRegister & ATA_ERRREG_BBK) { + if ((ErrorRegister & ATA_ERRREG_BBK) != 0) { DEBUG ( (EFI_D_BLKIO, "CheckErrorStatus()-- %02x : Error : Bad Block Detected\n", @@ -657,7 +657,7 @@ CheckErrorStatus ( ); } - if (ErrorRegister & ATA_ERRREG_UNC) { + if ((ErrorRegister & ATA_ERRREG_UNC) != 0) { DEBUG ( (EFI_D_BLKIO, "CheckErrorStatus()-- %02x : Error : Uncorrectable Data\n", @@ -665,7 +665,7 @@ CheckErrorStatus ( ); } - if (ErrorRegister & ATA_ERRREG_MC) { + if ((ErrorRegister & ATA_ERRREG_MC) != 0) { DEBUG ( (EFI_D_BLKIO, "CheckErrorStatus()-- %02x : Error : Media Change\n", @@ -673,7 +673,7 @@ CheckErrorStatus ( ); } - if (ErrorRegister & ATA_ERRREG_ABRT) { + if ((ErrorRegister & ATA_ERRREG_ABRT) != 0) { DEBUG ( (EFI_D_BLKIO, "CheckErrorStatus()-- %02x : Error : Abort\n", @@ -681,7 +681,7 @@ CheckErrorStatus ( ); } - if (ErrorRegister & ATA_ERRREG_TK0NF) { + if ((ErrorRegister & ATA_ERRREG_TK0NF) != 0) { DEBUG ( (EFI_D_BLKIO, "CheckErrorStatus()-- %02x : Error : Track 0 Not Found\n", @@ -689,7 +689,7 @@ CheckErrorStatus ( ); } - if (ErrorRegister & ATA_ERRREG_AMNF) { + if ((ErrorRegister & ATA_ERRREG_AMNF) != 0) { DEBUG ( (EFI_D_BLKIO, "CheckErrorStatus()-- %02x : Error : Address Mark Not Found\n", @@ -1348,7 +1348,7 @@ AtaReadSectorsExt ( @param[in] *DataBuffer A pointer to the source buffer for the data. - @param[in] Lba + @param[in] StartLba The starting logical block address to write onto the device media. @@ -1439,7 +1439,7 @@ AtaWriteSectorsExt ( @param[in] *IdeDev pointer pointing to IDE_BLK_IO_DEV data structure, used to record all the information of the IDE device. - @param[in,out] *Buffer buffer contained data transferred from device to host. + @param[in, out] *Buffer buffer contained data transferred from device to host. @param[in] ByteCount data size in byte unit of the buffer. @param[in] AtaCommand value of the Command Register @param[in] StartLba the start LBA of this transaction @@ -1908,7 +1908,7 @@ AtaSMARTSupport ( @param LbaAddress The LBA address in 48-bit mode @retval EFI_SUCCESS Reading succeed - @retval EFI_DEVICE_ERROR Error executing commands on this device + @retval EFI_DEVICE_ERROR Error executing commands on this device. **/ EFI_STATUS @@ -2020,7 +2020,7 @@ AtaCommandIssueExt ( @param LbaAddress The LBA address in 48-bit mode @retval EFI_SUCCESS Reading succeed - @retval EFI_DEVICE_ERROR Error executing commands on this device + @retval EFI_DEVICE_ERROR Error executing commands on this device. **/ EFI_STATUS @@ -2574,8 +2574,8 @@ DoAtaUdma ( 1, &RegisterValue ); - if ((RegisterValue & (BMIS_INTERRUPT | BMIS_ERROR)) || (Count == 0)) { - if ((RegisterValue & BMIS_ERROR) || (Count == 0)) { + if (((RegisterValue & (BMIS_INTERRUPT | BMIS_ERROR)) != 0) || (Count == 0)) { + if (((RegisterValue & BMIS_ERROR) != 0) || (Count == 0)) { Status = EFI_DEVICE_ERROR; break; } @@ -2637,7 +2637,7 @@ DoAtaUdma ( &RegisterValue ); - if (RegisterValue & BMIS_ERROR) { + if ((RegisterValue & BMIS_ERROR) != 0) { return EFI_DEVICE_ERROR; } diff --git a/IntelFrameworkModulePkg/Bus/Pci/IdeBusDxe/Atapi.c b/IntelFrameworkModulePkg/Bus/Pci/IdeBusDxe/Atapi.c index e7ddcb980e..e3515d2547 100644 --- a/IntelFrameworkModulePkg/Bus/Pci/IdeBusDxe/Atapi.c +++ b/IntelFrameworkModulePkg/Bus/Pci/IdeBusDxe/Atapi.c @@ -90,11 +90,11 @@ LS120GetMediaStatus ( // StatusValue = IDEReadPortB (IdeDev->PciIo, IdeDev->IoPort->Reg1.Error); - if (StatusValue & BIT1) { + if ((StatusValue & BIT1) != 0) { return EFI_NO_MEDIA; } - if (StatusValue & BIT6) { + if ((StatusValue & BIT6) != 0) { return EFI_WRITE_PROTECTED; } else { return EFI_SUCCESS; @@ -803,7 +803,7 @@ PioReadWriteData ( @param[in] *IdeDev Pointer pointing to IDE_BLK_IO_DEV data structure, used to record all the information of the IDE device. - @param[in] *SResult Sense result for this packet command. + @param[out] *SResult Sense result for this packet command. @retval EFI_SUCCESS Device is accessible. @retval EFI_DEVICE_ERROR Device is not accessible. @@ -851,17 +851,11 @@ AtapiTestUnitReady ( pointer pointing to IDE_BLK_IO_DEV data structure, used to record all the information of the IDE device. - @param[out] **SenseBuffers + @param[out] **SenseCounts allocated in this function, and freed by the calling function. This buffer is used to accommodate all the sense data returned by the device. - @param[out] *BufUnit - record the unit size of the sense data block in the SenseBuffers, - - @param[out] *BufNumbers - record the number of units in the SenseBuffers. - @retval EFI_SUCCESS Request Sense command completes successfully. @@ -961,7 +955,7 @@ AtapiRequestSense ( @param[in] *IdeDev Pointer pointing to IDE_BLK_IO_DEV data structure, used to record all the information of the IDE device. - @param[in] SResult Sense result for this packet command + @param[out] SResult Sense result for this packet command @retval EFI_SUCCESS Read Capacity Command finally completes successfully. @retval EFI_DEVICE_ERROR Read Capacity Command failed because of device error. @@ -1657,7 +1651,7 @@ AtapiSoftReset ( This function is the ATAPI implementation for ReadBlocks in the Block I/O Protocol interface. - @param[in] *IdeBlkIoDev + @param[in] *IdeBlkIoDevice Indicates the calling context. @param[in] MediaId @@ -1795,7 +1789,7 @@ AtapiBlkIoReadBlocks ( // // save the first block to the cache for performance // - if (LBA == 0 && !IdeBlkIoDevice->Cache) { + if (LBA == 0 && (IdeBlkIoDevice->Cache == NULL)) { IdeBlkIoDevice->Cache = AllocatePool (BlockSize); if (IdeBlkIoDevice != NULL) { CopyMem ((UINT8 *) IdeBlkIoDevice->Cache, (UINT8 *) Buffer, BlockSize); @@ -1810,7 +1804,7 @@ AtapiBlkIoReadBlocks ( This function is the ATAPI implementation for WriteBlocks in the Block I/O Protocol interface. - @param[in] *This + @param[in] *IdeBlkIoDevice Indicates the calling context. @param[in] MediaId @@ -1869,7 +1863,7 @@ AtapiBlkIoWriteBlocks ( EFI_STATUS Status; BOOLEAN MediaChange; - if (LBA == 0 && IdeBlkIoDevice->Cache) { + if (LBA == 0 && IdeBlkIoDevice->Cache != NULL) { gBS->FreePool (IdeBlkIoDevice->Cache); IdeBlkIoDevice->Cache = NULL; } @@ -1890,7 +1884,7 @@ AtapiBlkIoWriteBlocks ( Status = AtapiDetectMedia (IdeBlkIoDevice, &MediaChange); if (EFI_ERROR (Status)) { - if (LBA == 0 && IdeBlkIoDevice->Cache) { + if (LBA == 0 && IdeBlkIoDevice->Cache != NULL) { gBS->FreePool (IdeBlkIoDevice->Cache); IdeBlkIoDevice->Cache = NULL; } @@ -1906,7 +1900,7 @@ AtapiBlkIoWriteBlocks ( if (!(Media->MediaPresent)) { - if (LBA == 0 && IdeBlkIoDevice->Cache) { + if (LBA == 0 && IdeBlkIoDevice->Cache != NULL) { gBS->FreePool (IdeBlkIoDevice->Cache); IdeBlkIoDevice->Cache = NULL; } @@ -1915,7 +1909,7 @@ AtapiBlkIoWriteBlocks ( if ((MediaId != Media->MediaId) || MediaChange) { - if (LBA == 0 && IdeBlkIoDevice->Cache) { + if (LBA == 0 && IdeBlkIoDevice->Cache != NULL) { gBS->FreePool (IdeBlkIoDevice->Cache); IdeBlkIoDevice->Cache = NULL; } @@ -2073,7 +2067,7 @@ AtapiReadPendingData ( @retval EFI_DEVICE_ERROR TODO: Add description for return value @retval EFI_DEVICE_ERROR TODO: Add description for return value - @retval EFI_SUCCESS TODO: Add description for return value + @retval EFI_SUCCESS TODO: Add description for return value. **/ EFI_STATUS diff --git a/IntelFrameworkModulePkg/Bus/Pci/IdeBusDxe/ComponentName.h b/IntelFrameworkModulePkg/Bus/Pci/IdeBusDxe/ComponentName.h index f8cb60d5dc..cce33cf36a 100644 --- a/IntelFrameworkModulePkg/Bus/Pci/IdeBusDxe/ComponentName.h +++ b/IntelFrameworkModulePkg/Bus/Pci/IdeBusDxe/ComponentName.h @@ -154,7 +154,7 @@ IDEBusComponentNameGetControllerName ( @param IdeBlkIoDevicePtr TODO: add argument description - TODO: add return values + TODO: add return values. **/ VOID diff --git a/IntelFrameworkModulePkg/Bus/Pci/IdeBusDxe/DriverConfiguration.c b/IntelFrameworkModulePkg/Bus/Pci/IdeBusDxe/DriverConfiguration.c index 79385b8084..1816e2d0a5 100644 --- a/IntelFrameworkModulePkg/Bus/Pci/IdeBusDxe/DriverConfiguration.c +++ b/IntelFrameworkModulePkg/Bus/Pci/IdeBusDxe/DriverConfiguration.c @@ -33,9 +33,9 @@ EFI_DRIVER_CONFIGURATION_PROTOCOL gIDEBusDriverConfiguration = { /** TODO: Add function description - @retval EFI_ABORTED TODO: Add description for return value - @retval EFI_SUCCESS TODO: Add description for return value - @retval EFI_NOT_FOUND TODO: Add description for return value + @retval EFI_ABORTED TODO: Add description for return value. + @retval EFI_SUCCESS TODO: Add description for return value. + @retval EFI_NOT_FOUND TODO: Add description for return value. **/ EFI_STATUS diff --git a/IntelFrameworkModulePkg/Bus/Pci/IdeBusDxe/Ide.c b/IntelFrameworkModulePkg/Bus/Pci/IdeBusDxe/Ide.c index 6386d7976e..c6902afe01 100644 --- a/IntelFrameworkModulePkg/Bus/Pci/IdeBusDxe/Ide.c +++ b/IntelFrameworkModulePkg/Bus/Pci/IdeBusDxe/Ide.c @@ -24,7 +24,7 @@ UINT8 MasterDeviceType = INVALID_DEVICE_TYPE; @param PciIo TODO: add argument description @param Port TODO: add argument description - TODO: add return values + TODO: add return values. **/ UINT8 @@ -66,7 +66,7 @@ IDEReadPortWMultiple ( IN EFI_PCI_IO_PROTOCOL *PciIo, IN UINT16 Port, IN UINTN Count, - IN VOID *Buffer + OUT VOID *Buffer ) { UINT16 *AlignedBuffer; @@ -115,7 +115,7 @@ IDEReadPortWMultiple ( @param Port TODO: add argument description @param Data TODO: add argument description - TODO: add return values + TODO: add return values. **/ VOID @@ -146,7 +146,7 @@ IDEWritePortB ( @param Port TODO: add argument description @param Data TODO: add argument description - TODO: add return values + TODO: add return values. **/ VOID @@ -409,7 +409,7 @@ ReassignIdeResources ( /** Detect if there is disk connected to this port - @param IdeDev The BLK_IO private data which specifies the IDE device + @param IdeDev The BLK_IO private data which specifies the IDE device. **/ EFI_STATUS @@ -426,7 +426,7 @@ DiscoverIdeDevice ( // If a channel has not been checked, check it now. Then set it to "checked" state // After this step, all devices in this channel have been checked. // - if (ChannelDeviceDetected == FALSE) { + if (!ChannelDeviceDetected) { Status = DetectIDEController (IdeDev); if (EFI_ERROR (Status)) { return EFI_NOT_FOUND; @@ -787,7 +787,7 @@ DRQClear ( Delay--; - } while (Delay); + } while (Delay > 0); if (Delay == 0) { return EFI_TIMEOUT; @@ -861,7 +861,7 @@ DRQClear2 ( Delay--; - } while (Delay); + } while (Delay > 0); if (Delay == 0) { return EFI_TIMEOUT; @@ -939,7 +939,7 @@ DRQReady ( gBS->Stall (30); Delay--; - } while (Delay); + } while (Delay > 0); if (Delay == 0) { return EFI_TIMEOUT; @@ -1016,7 +1016,7 @@ DRQReady2 ( gBS->Stall (30); Delay--; - } while (Delay); + } while (Delay > 0); if (Delay == 0) { return EFI_TIMEOUT; @@ -1075,7 +1075,7 @@ WaitForBSYClear ( Delay--; - } while (Delay); + } while (Delay > 0); if (Delay == 0) { return EFI_TIMEOUT; @@ -1132,7 +1132,7 @@ WaitForBSYClear2 ( Delay--; - } while (Delay); + } while (Delay > 0); if (Delay == 0) { return EFI_TIMEOUT; @@ -1154,7 +1154,7 @@ WaitForBSYClear2 ( pointer pointing to IDE_BLK_IO_DEV data structure, used to record all the information of the IDE device. - @param[in] UINTN IN TimeoutInMilliSeconds + @param[in] UINTN IN DelayInMilliSeconds used to designate the timeout for the DRQ ready. @retval EFI_SUCCESS @@ -1203,7 +1203,7 @@ DRDYReady ( gBS->Stall (30); Delay--; - } while (Delay); + } while (Delay > 0); if (Delay == 0) { return EFI_TIMEOUT; @@ -1225,7 +1225,7 @@ DRDYReady ( pointer pointing to IDE_BLK_IO_DEV data structure, used to record all the information of the IDE device. - @param[in] UINTN IN TimeoutInMilliSeconds + @param[in] UINTN IN DelayInMilliSeconds used to designate the timeout for the DRQ ready. @retval EFI_SUCCESS @@ -1274,7 +1274,7 @@ DRDYReady2 ( gBS->Stall (30); Delay--; - } while (Delay); + } while (Delay > 0); if (Delay == 0) { return EFI_TIMEOUT; @@ -1401,7 +1401,7 @@ ReleaseIdeResources ( @param[in] *IdeDev Standard IDE device private data structure @param[in] *TransferMode The device transfer mode to be set - @return Set transfer mode Command execute status + @return Set transfer mode Command execute status. **/ EFI_STATUS @@ -1450,7 +1450,7 @@ SetDeviceTransferMode ( @retval EFI_SUCCESS Reading succeed @retval EFI_ABORTED Command failed - @retval EFI_DEVICE_ERROR Device status error + @retval EFI_DEVICE_ERROR Device status error. **/ EFI_STATUS @@ -1542,7 +1542,7 @@ AtaNonDataCommandIn ( @retval EFI_SUCCESS Reading succeed @retval EFI_ABORTED Command failed - @retval EFI_DEVICE_ERROR Device status error + @retval EFI_DEVICE_ERROR Device status error. **/ EFI_STATUS @@ -1658,7 +1658,7 @@ AtaNonDataCommandInExt ( @param[in] IdeDev Standard IDE device private data structure @param[in] DriveParameters The device parameters to be set into the disk - @return SetParameters Command execute status + @return SetParameters Command execute status. **/ EFI_STATUS @@ -1708,7 +1708,7 @@ SetDriveParameters ( @param IdeDev TODO: add argument description - @retval EFI_SUCCESS TODO: Add description for return value + @retval EFI_SUCCESS TODO: Add description for return value. **/ EFI_STATUS diff --git a/IntelFrameworkModulePkg/Bus/Pci/IdeBusDxe/Ide.h b/IntelFrameworkModulePkg/Bus/Pci/IdeBusDxe/Ide.h index 9fd43f551a..71ab6ecd75 100644 --- a/IntelFrameworkModulePkg/Bus/Pci/IdeBusDxe/Ide.h +++ b/IntelFrameworkModulePkg/Bus/Pci/IdeBusDxe/Ide.h @@ -31,7 +31,7 @@ @param Controller TODO: add argument description @param Handle TODO: add argument description - TODO: add return values + TODO: add return values. **/ EFI_STATUS @@ -49,7 +49,7 @@ DeRegisterIdeDevice ( @param ParentDevicePath TODO: add argument description @param RemainingDevicePath TODO: add argument description - TODO: add return values + TODO: add return values. **/ EFI_STATUS @@ -66,7 +66,7 @@ EnableIdeDevice ( @param PciIo TODO: add argument description @param Port TODO: add argument description - TODO: add return values + TODO: add return values. **/ UINT8 @@ -83,7 +83,7 @@ IDEReadPortB ( @param Count TODO: add argument description @param Buffer TODO: add argument description - TODO: add return values + TODO: add return values. **/ VOID @@ -101,7 +101,7 @@ IDEReadPortWMultiple ( @param Port TODO: add argument description @param Data TODO: add argument description - TODO: add return values + TODO: add return values. **/ VOID @@ -136,7 +136,7 @@ IDEWritePortW ( @param Count TODO: add argument description @param Buffer TODO: add argument description - TODO: add return values + TODO: add return values. **/ VOID @@ -153,7 +153,7 @@ IDEWritePortWMultiple ( @param PciIo TODO: add argument description @param IdeRegsBaseAddr TODO: add argument description - TODO: add return values + TODO: add return values. **/ EFI_STATUS @@ -167,7 +167,7 @@ GetIdeRegistersBaseAddr ( @param IdeDev TODO: add argument description - TODO: add return values + TODO: add return values. **/ EFI_STATUS @@ -180,7 +180,7 @@ ReassignIdeResources ( @param IdeDev TODO: add argument description - TODO: add return values + TODO: add return values. **/ EFI_STATUS @@ -205,7 +205,7 @@ InitializeIDEChannelData ( @param IdeDev TODO: add argument description - TODO: add return values + TODO: add return values. **/ EFI_STATUS @@ -219,7 +219,7 @@ DetectIDEController ( @param IdeDev TODO: add argument description @param TimeoutInMilliSeconds TODO: add argument description - TODO: add return values + TODO: add return values. **/ EFI_STATUS @@ -234,7 +234,7 @@ DRQClear ( @param IdeDev TODO: add argument description @param TimeoutInMilliSeconds TODO: add argument description - TODO: add return values + TODO: add return values. **/ EFI_STATUS @@ -249,7 +249,7 @@ DRQClear2 ( @param IdeDev TODO: add argument description @param TimeoutInMilliSeconds TODO: add argument description - TODO: add return values + TODO: add return values. **/ EFI_STATUS @@ -264,7 +264,7 @@ DRQReady ( @param IdeDev TODO: add argument description @param TimeoutInMilliSeconds TODO: add argument description - TODO: add return values + TODO: add return values. **/ EFI_STATUS @@ -279,7 +279,7 @@ DRQReady2 ( @param IdeDev TODO: add argument description @param TimeoutInMilliSeconds TODO: add argument description - TODO: add return values + TODO: add return values. **/ EFI_STATUS @@ -294,7 +294,7 @@ WaitForBSYClear ( @param IdeDev TODO: add argument description @param TimeoutInMilliSeconds TODO: add argument description - TODO: add return values + TODO: add return values. **/ EFI_STATUS @@ -309,7 +309,7 @@ WaitForBSYClear2 ( @param IdeDev TODO: add argument description @param DelayInMilliSeconds TODO: add argument description - TODO: add return values + TODO: add return values. **/ EFI_STATUS @@ -324,7 +324,7 @@ DRDYReady ( @param IdeDev TODO: add argument description @param DelayInMilliSeconds TODO: add argument description - TODO: add return values + TODO: add return values. **/ EFI_STATUS @@ -340,7 +340,7 @@ DRDYReady2 ( @param Source TODO: add argument description @param Size TODO: add argument description - TODO: add return values + TODO: add return values. **/ VOID @@ -358,7 +358,7 @@ SwapStringChars ( @param IdeDev TODO: add argument description - TODO: add return values + TODO: add return values. **/ EFI_STATUS @@ -371,7 +371,7 @@ ATAIdentify ( @param IdeDev TODO: add argument description - TODO: add return values + TODO: add return values. **/ VOID @@ -392,7 +392,7 @@ PrintAtaModuleName ( @param CylinderLsb TODO: add argument description @param CylinderMsb TODO: add argument description - TODO: add return values + TODO: add return values. **/ EFI_STATUS @@ -421,7 +421,7 @@ AtaPioDataIn ( @param CylinderLsb TODO: add argument description @param CylinderMsb TODO: add argument description - TODO: add return values + TODO: add return values. **/ EFI_STATUS @@ -458,7 +458,7 @@ CheckErrorStatus ( @param Lba TODO: add argument description @param NumberOfBlocks TODO: add argument description - TODO: add return values + TODO: add return values. **/ EFI_STATUS @@ -477,7 +477,7 @@ AtaReadSectors ( @param Lba TODO: add argument description @param NumberOfBlocks TODO: add argument description - TODO: add return values + TODO: add return values. **/ EFI_STATUS @@ -493,7 +493,7 @@ AtaWriteSectors ( @param IdeDev TODO: add argument description - TODO: add return values + TODO: add return values. **/ EFI_STATUS @@ -510,7 +510,7 @@ AtaSoftReset ( @param BufferSize TODO: add argument description @param Buffer TODO: add argument description - TODO: add return values + TODO: add return values. **/ EFI_STATUS @@ -531,7 +531,7 @@ AtaBlkIoReadBlocks ( @param BufferSize TODO: add argument description @param Buffer TODO: add argument description - TODO: add return values + TODO: add return values. **/ EFI_STATUS @@ -551,7 +551,7 @@ AtaBlkIoWriteBlocks ( @param IdeDev TODO: add argument description - TODO: add return values + TODO: add return values. **/ EFI_STATUS @@ -564,7 +564,7 @@ ATAPIIdentify ( @param IdeDev TODO: add argument description - TODO: add return values + TODO: add return values. **/ EFI_STATUS @@ -581,7 +581,7 @@ AtapiInquiry ( @param ByteCount TODO: add argument description @param TimeOut TODO: add argument description - TODO: add return values + TODO: add return values. **/ EFI_STATUS @@ -602,7 +602,7 @@ AtapiPacketCommandIn ( @param ByteCount TODO: add argument description @param TimeOut TODO: add argument description - TODO: add return values + TODO: add return values. **/ EFI_STATUS @@ -623,7 +623,7 @@ AtapiPacketCommandOut ( @param Read TODO: add argument description @param TimeOut TODO: add argument description - TODO: add return values + TODO: add return values. **/ EFI_STATUS @@ -638,10 +638,10 @@ PioReadWriteData ( /** TODO: Add function description - @param IdeDev TODO: add argument description - @param IdeDev TODO: add argument description + @param IdeDev TODO: add argument description + @param SResult TODO: add argument description - TODO: add return values + TODO: add return values. **/ EFI_STATUS @@ -656,7 +656,7 @@ AtapiTestUnitReady ( @param IdeDev TODO: add argument description @param SenseCounts TODO: add argument description - TODO: add return values + TODO: add return values. **/ EFI_STATUS @@ -668,10 +668,10 @@ AtapiRequestSense ( /** TODO: Add function description - @param IdeDev TODO: add argument description - @param IdeDev TODO: add argument description + @param IdeDev TODO: add argument description + @param SResult TODO: add argument description - TODO: add return values + TODO: add return values. **/ EFI_STATUS @@ -686,7 +686,7 @@ AtapiReadCapacity ( @param IdeDev TODO: add argument description @param MediaChange TODO: add argument description - TODO: add return values + TODO: add return values. **/ EFI_STATUS @@ -703,7 +703,7 @@ AtapiDetectMedia ( @param Lba TODO: add argument description @param NumberOfBlocks TODO: add argument description - TODO: add return values + TODO: add return values. **/ EFI_STATUS @@ -722,7 +722,7 @@ AtapiReadSectors ( @param Lba TODO: add argument description @param NumberOfBlocks TODO: add argument description - TODO: add return values + TODO: add return values. **/ EFI_STATUS @@ -738,7 +738,7 @@ AtapiWriteSectors ( @param IdeDev TODO: add argument description - TODO: add return values + TODO: add return values. **/ EFI_STATUS @@ -755,7 +755,7 @@ AtapiSoftReset ( @param BufferSize TODO: add argument description @param Buffer TODO: add argument description - TODO: add return values + TODO: add return values. **/ EFI_STATUS @@ -776,7 +776,7 @@ AtapiBlkIoReadBlocks ( @param BufferSize TODO: add argument description @param Buffer TODO: add argument description - TODO: add return values + TODO: add return values. **/ EFI_STATUS @@ -795,7 +795,7 @@ AtapiBlkIoWriteBlocks ( @param SenseCount TODO: add argument description @param Result TODO: add argument description - TODO: add return values + TODO: add return values. **/ EFI_STATUS @@ -810,7 +810,7 @@ ParseSenseData ( @param IdeDev TODO: add argument description - TODO: add return values + TODO: add return values. **/ EFI_STATUS @@ -824,7 +824,7 @@ AtapiReadPendingData ( @param IdeDev TODO: add argument description @param WriteProtected TODO: add argument description - TODO: add return values + TODO: add return values. **/ EFI_STATUS @@ -838,7 +838,7 @@ IsLS120orZipWriteProtected ( @param IdeBlkIoDevice TODO: add argument description - TODO: add return values + TODO: add return values. **/ VOID @@ -852,7 +852,7 @@ ReleaseIdeResources ( @param IdeDev TODO: add argument description @param TransferMode TODO: add argument description - TODO: add return values + TODO: add return values. **/ EFI_STATUS @@ -867,7 +867,7 @@ SetDeviceTransferMode ( @param IdeDev TODO: add argument description @param NativeMaxAddress TODO: add argument description - TODO: add return values + TODO: add return values. **/ EFI_STATUS @@ -883,7 +883,7 @@ ReadNativeMaxAddress ( @param MaxAddress TODO: add argument description @param bVolatile TODO: add argument description - TODO: add return values + TODO: add return values. **/ EFI_STATUS @@ -905,7 +905,7 @@ SetMaxAddress ( @param LbaMiddle TODO: add argument description @param LbaHigh TODO: add argument description - TODO: add return values + TODO: add return values. **/ EFI_STATUS @@ -930,7 +930,7 @@ AtaNonDataCommandIn ( @param SectorCount TODO: add argument description @param LbaAddress TODO: add argument description - TODO: add return values + TODO: add return values. **/ EFI_STATUS @@ -951,7 +951,7 @@ AtaNonDataCommandInExt ( @param StartLba TODO: add argument description @param NumberOfBlocks TODO: add argument description - TODO: add return values + TODO: add return values. **/ EFI_STATUS @@ -970,7 +970,7 @@ AtaReadSectorsExt ( @param StartLba TODO: add argument description @param NumberOfBlocks TODO: add argument description - TODO: add return values + TODO: add return values. **/ EFI_STATUS @@ -989,7 +989,7 @@ AtaWriteSectorsExt ( @param StartLba TODO: add argument description @param NumberOfBlocks TODO: add argument description - TODO: add return values + TODO: add return values. **/ EFI_STATUS @@ -1008,7 +1008,7 @@ AtaUdmaReadExt ( @param StartLba TODO: add argument description @param NumberOfBlocks TODO: add argument description - TODO: add return values + TODO: add return values. **/ EFI_STATUS @@ -1027,7 +1027,7 @@ AtaUdmaRead ( @param StartLba TODO: add argument description @param NumberOfBlocks TODO: add argument description - TODO: add return values + TODO: add return values. **/ EFI_STATUS @@ -1081,7 +1081,7 @@ DoAtaUdma ( @param StartLba TODO: add argument description @param NumberOfBlocks TODO: add argument description - TODO: add return values + TODO: add return values. **/ EFI_STATUS @@ -1102,7 +1102,7 @@ AtaUdmaWrite ( @param SectorCount TODO: add argument description @param LbaAddress TODO: add argument description - TODO: add return values + TODO: add return values. **/ EFI_STATUS @@ -1125,7 +1125,7 @@ AtaCommandIssueExt ( @param SectorCount TODO: add argument description @param LbaAddress TODO: add argument description - TODO: add return values + TODO: add return values. **/ EFI_STATUS @@ -1143,7 +1143,7 @@ AtaCommandIssue ( @param IdeDev TODO: add argument description - TODO: add return values + TODO: add return values. **/ EFI_STATUS @@ -1157,7 +1157,7 @@ AtaAtapi6Identify ( @param IdeDev TODO: add argument description - TODO: add return values + TODO: add return values. **/ VOID @@ -1175,7 +1175,7 @@ AtaSMARTSupport ( @param StartLba TODO: add argument description @param SectorCount TODO: add argument description - TODO: add return values + TODO: add return values. **/ EFI_STATUS @@ -1198,7 +1198,7 @@ AtaPioDataInExt ( @param StartLba TODO: add argument description @param SectorCount TODO: add argument description - TODO: add return values + TODO: add return values. **/ EFI_STATUS @@ -1217,7 +1217,7 @@ AtaPioDataOutExt ( @param IdeDev TODO: add argument description @param DriveParameters TODO: add argument description - TODO: add return values + TODO: add return values. **/ EFI_STATUS @@ -1231,7 +1231,7 @@ SetDriveParameters ( @param IdeDev TODO: add argument description - TODO: add return values + TODO: add return values. **/ EFI_STATUS @@ -1245,7 +1245,7 @@ EnableInterrupt ( @param[in] Event Pointer to this event @param[in] Context Event hanlder private data - @retval EFI_SUCCESS - Interrupt cleared + @retval EFI_SUCCESS - Interrupt cleared. **/ VOID diff --git a/IntelFrameworkModulePkg/Bus/Pci/IdeBusDxe/IdeBus.c b/IntelFrameworkModulePkg/Bus/Pci/IdeBusDxe/IdeBus.c index 5b6f0de60f..e864eccc31 100644 --- a/IntelFrameworkModulePkg/Bus/Pci/IdeBusDxe/IdeBus.c +++ b/IntelFrameworkModulePkg/Bus/Pci/IdeBusDxe/IdeBus.c @@ -437,7 +437,7 @@ IDEBusDriverBindingStart ( // // Check whether the configuration options allow this device // - if (!(ConfigurationOptions & (1 << (IdeChannel * 2 + IdeDevice)))) { + if ((ConfigurationOptions & (1 << (IdeChannel * 2 + IdeDevice))) == 0) { continue; } @@ -822,7 +822,7 @@ ErrorExit: Stop this driver on Controller Handle. @param This Protocol instance pointer. - @param DeviceHandle Handle of device to stop driver on + @param Controller Handle of device to stop driver on @param NumberOfChildren Not used @param ChildHandleBuffer Not used diff --git a/IntelFrameworkModulePkg/Bus/Pci/IdeBusDxe/IdeBus.h b/IntelFrameworkModulePkg/Bus/Pci/IdeBusDxe/IdeBus.h index 6e540ca15a..f4ec71594d 100644 --- a/IntelFrameworkModulePkg/Bus/Pci/IdeBusDxe/IdeBus.h +++ b/IntelFrameworkModulePkg/Bus/Pci/IdeBusDxe/IdeBus.h @@ -127,7 +127,7 @@ extern EFI_DRIVER_DIAGNOSTICS2_PROTOCOL gIDEBusDriverDiagnostics2; @param ImageHandle TODO: add argument description @param SystemTable TODO: add argument description - TODO: add return values + TODO: add return values. **/ EFI_STATUS @@ -144,7 +144,7 @@ IDEBusControllerDriverEntryPoint ( @param Controller TODO: add argument description @param RemainingDevicePath TODO: add argument description - TODO: add return values + TODO: add return values. **/ EFI_STATUS @@ -162,7 +162,7 @@ IDEBusDriverBindingSupported ( @param Controller TODO: add argument description @param RemainingDevicePath TODO: add argument description - TODO: add return values + TODO: add return values. **/ EFI_STATUS @@ -181,7 +181,7 @@ IDEBusDriverBindingStart ( @param NumberOfChildren TODO: add argument description @param ChildHandleBuffer TODO: add argument description - TODO: add return values + TODO: add return values. **/ EFI_STATUS @@ -245,7 +245,7 @@ IDEBusDriverDiagnosticsRunDiagnostics ( @param This TODO: add argument description @param ExtendedVerification TODO: add argument description - TODO: add return values + TODO: add return values. **/ EFI_STATUS @@ -286,7 +286,7 @@ IDEBlkIoReadBlocks ( @param BufferSize TODO: add argument description @param Buffer TODO: add argument description - TODO: add return values + TODO: add return values. **/ EFI_STATUS @@ -304,7 +304,7 @@ IDEBlkIoWriteBlocks ( @param This TODO: add argument description - TODO: add return values + TODO: add return values. **/ EFI_STATUS @@ -319,7 +319,7 @@ IDEBlkIoFlushBlocks ( @param PciIo TODO: add argument description @param Enable TODO: add argument description - TODO: add return values + TODO: add return values. **/ EFI_STATUS @@ -335,7 +335,7 @@ IDERegisterDecodeEnableorDisable ( @param InquiryData TODO: add argument description @param IntquiryDataSize TODO: add argument description - TODO: add return values + TODO: add return values. **/ EFI_STATUS @@ -353,7 +353,7 @@ IDEDiskInfoInquiry ( @param IdentifyData TODO: add argument description @param IdentifyDataSize TODO: add argument description - TODO: add return values + TODO: add return values. **/ EFI_STATUS @@ -372,7 +372,7 @@ IDEDiskInfoIdentify ( @param SenseDataSize TODO: add argument description @param SenseDataNumber TODO: add argument description - TODO: add return values + TODO: add return values. **/ EFI_STATUS @@ -391,7 +391,7 @@ IDEDiskInfoSenseData ( @param IdeChannel TODO: add argument description @param IdeDevice TODO: add argument description - TODO: add return values + TODO: add return values. **/ EFI_STATUS -- cgit v1.2.3