From b55f8b0146ab1a0b26909a63bb04ba850b9ba198 Mon Sep 17 00:00:00 2001 From: lgao4 Date: Fri, 14 Aug 2009 02:21:55 +0000 Subject: 1. Correct Col * Row string 2. Add error handle for no data hub system. git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@9065 6f19259b-4bc3-4df7-8a09-765794883524 --- IntelFrameworkModulePkg/Universal/BdsDxe/BootMaint/UpdatePage.c | 8 +++----- IntelFrameworkModulePkg/Universal/BdsDxe/FrontPage.c | 3 +++ 2 files changed, 6 insertions(+), 5 deletions(-) (limited to 'IntelFrameworkModulePkg') diff --git a/IntelFrameworkModulePkg/Universal/BdsDxe/BootMaint/UpdatePage.c b/IntelFrameworkModulePkg/Universal/BdsDxe/BootMaint/UpdatePage.c index 790fe51d44..5146399dd4 100644 --- a/IntelFrameworkModulePkg/Universal/BdsDxe/BootMaint/UpdatePage.c +++ b/IntelFrameworkModulePkg/Universal/BdsDxe/BootMaint/UpdatePage.c @@ -754,7 +754,6 @@ UpdateConModePage ( UINTN Index; UINTN Col; UINTN Row; - CHAR16 RowString[50]; CHAR16 ModeString[50]; CHAR16 *PStr; UINTN MaxMode; @@ -813,10 +812,9 @@ UpdateConModePage ( // UnicodeValueToString (ModeString, 0, Col, 0); PStr = &ModeString[0]; - StrnCat (PStr, L" x ", StrLen(L" x ")); - UnicodeValueToString (RowString, 0, Row, 0); - PStr = &ModeString[0]; - StrnCat (PStr, RowString, StrLen(RowString)); + StrnCat (PStr, L" x ", StrLen(L" x ") + 1); + PStr = PStr + StrLen (PStr); + UnicodeValueToString (PStr , 0, Row, 0); ModeToken[Index] = HiiSetString (CallbackData->BmmHiiHandle, 0, ModeString, NULL); diff --git a/IntelFrameworkModulePkg/Universal/BdsDxe/FrontPage.c b/IntelFrameworkModulePkg/Universal/BdsDxe/FrontPage.c index 9f25ebca6b..55fce979f7 100644 --- a/IntelFrameworkModulePkg/Universal/BdsDxe/FrontPage.c +++ b/IntelFrameworkModulePkg/Universal/BdsDxe/FrontPage.c @@ -721,6 +721,9 @@ UpdateFrontPageStrings ( Record = NULL; do { Status = DataHub->GetNextRecord (DataHub, &MonotonicCount, NULL, &Record); + if (EFI_ERROR (Status) || Record == NULL) { + break; + } if (Record->DataRecordClass == EFI_DATA_RECORD_CLASS_DATA) { DataHeader = (EFI_SUBCLASS_TYPE1_HEADER *) (Record + 1); if (CompareGuid (&Record->DataRecordGuid, &gEfiMiscSubClassGuid) && -- cgit v1.2.3