From 7ae58ec2eaaad7a4a22092266c407d76c12ed69a Mon Sep 17 00:00:00 2001 From: xli24 Date: Fri, 20 Aug 2010 17:32:04 +0000 Subject: The definition of NumberOfSmmReservedRegions is incorrect in Framework SmmCis specification 0.91, in which the type of this field is defined as UINTN. However, HOBs are supposed to be CPU neutral, so UINT32 should be used. Here the code is updated and comments in FrameworkSpecConformance.txt is added. git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@10813 6f19259b-4bc3-4df7-8a09-765794883524 --- IntelFrameworkPkg/Include/Guid/SmramMemoryReserve.h | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) (limited to 'IntelFrameworkPkg/Include/Guid') diff --git a/IntelFrameworkPkg/Include/Guid/SmramMemoryReserve.h b/IntelFrameworkPkg/Include/Guid/SmramMemoryReserve.h index 9edec42b9e..04589cf040 100644 --- a/IntelFrameworkPkg/Include/Guid/SmramMemoryReserve.h +++ b/IntelFrameworkPkg/Include/Guid/SmramMemoryReserve.h @@ -42,7 +42,11 @@ typedef struct { /// Designates the number of possible regions in the system /// that can be usable for SMRAM. /// - UINTN NumberOfSmmReservedRegions; + /// Inconsistent with specification here: + /// In Framework SMM CIS 0.91 specification, it defines the field type as UINTN. + /// However, HOBs are supposed to be CPU neutral, so UINT32 should be used instead. + /// + UINT32 NumberOfSmmReservedRegions; /// /// Used throughout this protocol to describe the candidate /// regions for SMRAM that are supported by this platform. -- cgit v1.2.3