From 6d1824fc6eb724bf6d21f701b2c66835d1529161 Mon Sep 17 00:00:00 2001 From: jchen20 Date: Thu, 9 Jul 2009 10:27:43 +0000 Subject: Add comments to describe the difference between code and spec to fix the bug #202430 git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@8839 6f19259b-4bc3-4df7-8a09-765794883524 --- IntelFrameworkPkg/Include/Protocol/FrameworkHii.h | 28 +++++++++++------------ 1 file changed, 13 insertions(+), 15 deletions(-) (limited to 'IntelFrameworkPkg/Include/Protocol') diff --git a/IntelFrameworkPkg/Include/Protocol/FrameworkHii.h b/IntelFrameworkPkg/Include/Protocol/FrameworkHii.h index 43fb641b59..c3117971c2 100644 --- a/IntelFrameworkPkg/Include/Protocol/FrameworkHii.h +++ b/IntelFrameworkPkg/Include/Protocol/FrameworkHii.h @@ -29,7 +29,16 @@ // is defined in MdePkg/Protocol/GraphicsOutput.h // #include - +// +// In UEFI2.1 spec, there is a same data type named EFI_GRAPHICS_OUTPUT_BLT_PIXEL. +// To define this data type only for backward compatibility. +// +typedef struct { + UINT8 Blue; + UINT8 Green; + UINT8 Red; + UINT8 Reserved; +} EFI_UGA_PIXEL // // In both EDK and EDK II, incompatbile change is done to Framework HII protocol. // This change should cause a change of GUID in both of code and HII spec. But we @@ -46,19 +55,6 @@ 0x5542cce1, 0xdf5c, 0x4d1b, { 0xab, 0xca, 0x36, 0x4f, 0x77, 0xd3, 0x99, 0xfb } \ } -// BugBug: -//++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ -// If UGA goes away we need to put this some place. I'm not sure where? -// -//typedef struct { -// UINT8 Blue; -// UINT8 Green; -// UINT8 Red; -// UINT8 Reserved; -//} EFI_UGA_PIXEL; - -//++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ -// typedef UINT16 STRING_REF; typedef UINT32 RELOFST; @@ -489,7 +485,9 @@ EFI_STATUS @retval EFI_SUCCESS It worked. @retval EFI_NOT_FOUND A glyph for a character was not found. - + @note: Inconsistent with specification here: + In Framework Spec,HII spec 0.92. The type of 3rd, 4th and 8th parameter is EFI_UGA_PIXEL. + Here the definition use the EFI_GRAPHICS_OUTPUT_BLT_PIXEL which defined in UEFI2.1 spec **/ typedef EFI_STATUS -- cgit v1.2.3