From a56b6e03e22c4023fdf5b026b0fcb096d6a0f677 Mon Sep 17 00:00:00 2001 From: ydong10 Date: Thu, 1 Nov 2012 02:10:31 +0000 Subject: Add more check to make code more safely. Signed-off-by: Eric Dong Reviewed-by: Ouyang Qian git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@13903 6f19259b-4bc3-4df7-8a09-765794883524 --- MdeModulePkg/Universal/Network/Ip4Dxe/Ip4Icmp.c | 1 + MdeModulePkg/Universal/Network/Ip4Dxe/Ip4Input.c | 4 +++- 2 files changed, 4 insertions(+), 1 deletion(-) (limited to 'MdeModulePkg/Universal/Network/Ip4Dxe') diff --git a/MdeModulePkg/Universal/Network/Ip4Dxe/Ip4Icmp.c b/MdeModulePkg/Universal/Network/Ip4Dxe/Ip4Icmp.c index a4d09abd74..18cb9ff360 100644 --- a/MdeModulePkg/Universal/Network/Ip4Dxe/Ip4Icmp.c +++ b/MdeModulePkg/Universal/Network/Ip4Dxe/Ip4Icmp.c @@ -240,6 +240,7 @@ Ip4IcmpReplyEcho ( // update is omitted. // Icmp = (IP4_ICMP_QUERY_HEAD *) NetbufGetByte (Data, 0, NULL); + ASSERT (Icmp != NULL); Icmp->Head.Type = ICMP_ECHO_REPLY; Icmp->Head.Checksum = 0; Icmp->Head.Checksum = (UINT16) (~NetblockChecksum ((UINT8 *) Icmp, Data->TotalSize)); diff --git a/MdeModulePkg/Universal/Network/Ip4Dxe/Ip4Input.c b/MdeModulePkg/Universal/Network/Ip4Dxe/Ip4Input.c index bd15fc2e17..d985b1aeb6 100644 --- a/MdeModulePkg/Universal/Network/Ip4Dxe/Ip4Input.c +++ b/MdeModulePkg/Universal/Network/Ip4Dxe/Ip4Input.c @@ -849,7 +849,8 @@ Ip4AccpetFrame ( goto DROP; } - Head = (IP4_HEAD *) NetbufGetByte (Packet, 0, NULL); + Head = (IP4_HEAD *) NetbufGetByte (Packet, 0, NULL); + ASSERT (Head != NULL); OptionLen = (Head->HeadLen << 2) - IP4_MIN_HEADLEN; if (OptionLen > 0) { Option = (UINT8 *) (Head + 1); @@ -899,6 +900,7 @@ Ip4AccpetFrame ( // is transfered to the packet process logic. // Head = (IP4_HEAD *) NetbufGetByte (Packet, 0, NULL); + ASSERT (Head != NULL); Status = Ip4PreProcessPacket ( IpSb, &Packet, -- cgit v1.2.3