From fa8ee0ad6dbb22bb9962c3e32c091f29c2e0d5d8 Mon Sep 17 00:00:00 2001 From: Dandan Bi Date: Fri, 22 Apr 2016 11:29:12 +0800 Subject: MdeModulePkg/SetupBrowserDxe: Remove the useless check When the type of HiiValue is BUFFER Type, the BufferValue of the related question can not be NULL, so can remove the check. Cc: Qiu Shumin Cc: Eric Dong Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Dandan Bi Reviewed-by: Qiu Shumin Reviewed-by: Eric Dong --- MdeModulePkg/Universal/SetupBrowserDxe/Setup.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'MdeModulePkg/Universal/SetupBrowserDxe') diff --git a/MdeModulePkg/Universal/SetupBrowserDxe/Setup.c b/MdeModulePkg/Universal/SetupBrowserDxe/Setup.c index c36588e4bf..5887e0f3be 100644 --- a/MdeModulePkg/Universal/SetupBrowserDxe/Setup.c +++ b/MdeModulePkg/Universal/SetupBrowserDxe/Setup.c @@ -3919,7 +3919,7 @@ GetQuestionDefault ( // HiiValue = &Question->HiiValue; TypeValue = &HiiValue->Value; - if (HiiValue->Type == EFI_IFR_TYPE_BUFFER && Question->BufferValue != NULL) { + if (HiiValue->Type == EFI_IFR_TYPE_BUFFER) { // // For orderedlist, need to pass the BufferValue to Callback function. // -- cgit v1.2.3