From c24b392c3049f92bd2a06899f766eb1e874ca09c Mon Sep 17 00:00:00 2001 From: eric_tian Date: Fri, 6 Feb 2009 05:37:46 +0000 Subject: fix ecc warning git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7456 6f19259b-4bc3-4df7-8a09-765794883524 --- MdeModulePkg/Universal/Variable/RuntimeDxe/Variable.c | 16 ++++------------ 1 file changed, 4 insertions(+), 12 deletions(-) (limited to 'MdeModulePkg/Universal/Variable/RuntimeDxe/Variable.c') diff --git a/MdeModulePkg/Universal/Variable/RuntimeDxe/Variable.c b/MdeModulePkg/Universal/Variable/RuntimeDxe/Variable.c index 6d3967947d..8fbcf129fa 100644 --- a/MdeModulePkg/Universal/Variable/RuntimeDxe/Variable.c +++ b/MdeModulePkg/Universal/Variable/RuntimeDxe/Variable.c @@ -38,14 +38,6 @@ VARIABLE_CACHE_ENTRY mVariableCache[] = { VARIABLE_INFO_ENTRY *gVariableInfo = NULL; -EFI_STATUS -FtwVariableSpace ( - IN EFI_PHYSICAL_ADDRESS VariableBaseAddress, - IN UINT8 *Buffer, - IN UINTN BufferSize - ); - - /** Acquires lock only at boot time. Simply returns at runtime. @@ -929,7 +921,7 @@ FindVariable ( if (Variable[Index]->State == VAR_ADDED || Variable[Index]->State == (VAR_IN_DELETED_TRANSITION & VAR_ADDED) ) { - if (!EfiAtRuntime () || (Variable[Index]->Attributes & EFI_VARIABLE_RUNTIME_ACCESS)) { + if (!EfiAtRuntime () || (Variable[Index]->Attributes & EFI_VARIABLE_RUNTIME_ACCESS != 0)) { if (VariableName[0] == 0) { if (Variable[Index]->State == (VAR_IN_DELETED_TRANSITION & VAR_ADDED)) { InDeletedVariable = Variable[Index]; @@ -947,7 +939,7 @@ FindVariable ( Point = (VOID *) GetVariableNamePtr (Variable[Index]); ASSERT (NameSizeOfVariable (Variable[Index]) != 0); - if (!CompareMem (VariableName, Point, NameSizeOfVariable (Variable[Index]))) { + if (CompareMem (VariableName, Point, NameSizeOfVariable (Variable[Index])) == 0) { if (Variable[Index]->State == (VAR_IN_DELETED_TRANSITION & VAR_ADDED)) { InDeletedVariable = Variable[Index]; InDeletedStorageIndex = Index; @@ -1136,7 +1128,7 @@ RuntimeServiceGetNextVariableName ( // Variable is found // if (IsValidVariableHeader (Variable.CurrPtr) && Variable.CurrPtr->State == VAR_ADDED) { - if (!(EfiAtRuntime () && !(Variable.CurrPtr->Attributes & EFI_VARIABLE_RUNTIME_ACCESS))) { + if ((EfiAtRuntime () && ((Variable.CurrPtr->Attributes & EFI_VARIABLE_RUNTIME_ACCESS) == 0)) == 0) { VarNameSize = NameSizeOfVariable (Variable.CurrPtr); ASSERT (VarNameSize != 0); @@ -1294,7 +1286,7 @@ RuntimeServiceSetVariable ( // // Only variable have NV attribute can be updated/deleted in Runtime // - if (!(Variable.CurrPtr->Attributes & EFI_VARIABLE_NON_VOLATILE)) { + if ((Variable.CurrPtr->Attributes & EFI_VARIABLE_NON_VOLATILE) == 0) { Status = EFI_INVALID_PARAMETER; goto Done; } -- cgit v1.2.3