From 4140a6635b4784db9d0125e96d521d01053eca2c Mon Sep 17 00:00:00 2001 From: rsun3 Date: Thu, 11 Feb 2010 02:33:16 +0000 Subject: Coding style fix and minor improvements. git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@9977 6f19259b-4bc3-4df7-8a09-765794883524 --- MdeModulePkg/Universal/DevicePathDxe/DevicePathToText.c | 2 +- MdeModulePkg/Universal/Network/SnpDxe/Get_status.c | 10 +++++----- MdeModulePkg/Universal/Network/SnpDxe/Receive.c | 6 +++--- MdeModulePkg/Universal/PCD/Dxe/Pcd.c | 4 ++-- MdeModulePkg/Universal/PCD/Dxe/Service.h | 2 +- MdeModulePkg/Universal/SetupBrowserDxe/Expression.c | 4 ++-- 6 files changed, 14 insertions(+), 14 deletions(-) (limited to 'MdeModulePkg/Universal') diff --git a/MdeModulePkg/Universal/DevicePathDxe/DevicePathToText.c b/MdeModulePkg/Universal/DevicePathDxe/DevicePathToText.c index 82789c1d51..44689504df 100644 --- a/MdeModulePkg/Universal/DevicePathDxe/DevicePathToText.c +++ b/MdeModulePkg/Universal/DevicePathDxe/DevicePathToText.c @@ -910,7 +910,7 @@ DevPathToTextSata ( SATA_DEVICE_PATH *Sata; Sata = DevPath; - if (Sata->PortMultiplierPortNumber & SATA_HBA_DIRECT_CONNECT_FLAG) { + if ((Sata->PortMultiplierPortNumber & SATA_HBA_DIRECT_CONNECT_FLAG) != 0) { CatPrint ( Str, L"Sata(0x%x,0x%x)", diff --git a/MdeModulePkg/Universal/Network/SnpDxe/Get_status.c b/MdeModulePkg/Universal/Network/SnpDxe/Get_status.c index edd2424c2c..dc742081da 100644 --- a/MdeModulePkg/Universal/Network/SnpDxe/Get_status.c +++ b/MdeModulePkg/Universal/Network/SnpDxe/Get_status.c @@ -1,8 +1,8 @@ /** @file - Implementation of reading the current interrupt status and recycled transmit - buffer status from a network interface. + Implementation of reading the current interrupt status and recycled transmit + buffer status from a network interface. -Copyright (c) 2004 - 2007, Intel Corporation.
+Copyright (c) 2004 - 2010, Intel Corporation.
All rights reserved. This program and the accompanying materials are licensed and made available under the terms and conditions of the BSD License which accompanies this distribution. The full text of the license may be found at @@ -115,8 +115,8 @@ PxeGetStatus ( if (TransmitBufferListPtr != NULL) { *TransmitBufferListPtr = ( - (Snp->Cdb.StatFlags & PXE_STATFLAGS_GET_STATUS_NO_TXBUFS_WRITTEN) || - (Snp->Cdb.StatFlags & PXE_STATFLAGS_GET_STATUS_TXBUF_QUEUE_EMPTY) + ((Snp->Cdb.StatFlags & PXE_STATFLAGS_GET_STATUS_NO_TXBUFS_WRITTEN) != 0) || + ((Snp->Cdb.StatFlags & PXE_STATFLAGS_GET_STATUS_TXBUF_QUEUE_EMPTY) != 0) ) ? 0 : (VOID *) (UINTN) Db->TxBuffer[0]; } diff --git a/MdeModulePkg/Universal/Network/SnpDxe/Receive.c b/MdeModulePkg/Universal/Network/SnpDxe/Receive.c index 92123b6c1f..a37156aa0b 100644 --- a/MdeModulePkg/Universal/Network/SnpDxe/Receive.c +++ b/MdeModulePkg/Universal/Network/SnpDxe/Receive.c @@ -1,7 +1,7 @@ /** @file - Implementation of receiving a packet from a network interface. + Implementation of receiving a packet from a network interface. -Copyright (c) 2004 - 2007, Intel Corporation.
+Copyright (c) 2004 - 2010, Intel Corporation.
All rights reserved. This program and the accompanying materials are licensed and made available under the terms and conditions of the BSD License which accompanies this distribution. The full text of the license may be found at @@ -225,7 +225,7 @@ SnpUndi32Receive ( goto ON_EXIT; } - if (!Snp->Mode.ReceiveFilterSetting) { + if (Snp->Mode.ReceiveFilterSetting == 0) { Status = EFI_DEVICE_ERROR; goto ON_EXIT; } diff --git a/MdeModulePkg/Universal/PCD/Dxe/Pcd.c b/MdeModulePkg/Universal/PCD/Dxe/Pcd.c index 83cbcdc3b2..363a949ea5 100644 --- a/MdeModulePkg/Universal/PCD/Dxe/Pcd.c +++ b/MdeModulePkg/Universal/PCD/Dxe/Pcd.c @@ -3,7 +3,7 @@ produce the implementation of native PCD protocol and EFI_PCD_PROTOCOL defined in PI 1.2 Vol3. -Copyright (c) 2006 - 2009, Intel Corporation +Copyright (c) 2006 - 2010, Intel Corporation All rights reserved. This program and the accompanying materials are licensed and made available under the terms and conditions of the BSD License which accompanies this distribution. The full text of the license may be found at @@ -968,7 +968,7 @@ DxeUnRegisterCallBackOnSet ( @param[in] Guid The 128-bit unique value that designates the namespace from which to retrieve the next token. This is an optional parameter that may be NULL. If this parameter is NULL, then a request is being made to retrieve tokens from the default token space. - @param[in,out] TokenNumber + @param[in, out] TokenNumber A pointer to the PCD token number to use to find the subsequent token number. @retval EFI_SUCCESS The PCD service retrieved the next valid token number. Or the input token number diff --git a/MdeModulePkg/Universal/PCD/Dxe/Service.h b/MdeModulePkg/Universal/PCD/Dxe/Service.h index 5602a72868..e2c25af08c 100644 --- a/MdeModulePkg/Universal/PCD/Dxe/Service.h +++ b/MdeModulePkg/Universal/PCD/Dxe/Service.h @@ -699,7 +699,7 @@ DxeUnRegisterCallBackOnSet ( @param[in] Guid The 128-bit unique value that designates the namespace from which to retrieve the next token. This is an optional parameter that may be NULL. If this parameter is NULL, then a request is being made to retrieve tokens from the default token space. - @param[in,out] TokenNumber + @param[in, out] TokenNumber A pointer to the PCD token number to use to find the subsequent token number. @retval EFI_SUCCESS The PCD service retrieved the next valid token number. Or the input token number diff --git a/MdeModulePkg/Universal/SetupBrowserDxe/Expression.c b/MdeModulePkg/Universal/SetupBrowserDxe/Expression.c index 4bb1950668..b429605662 100644 --- a/MdeModulePkg/Universal/SetupBrowserDxe/Expression.c +++ b/MdeModulePkg/Universal/SetupBrowserDxe/Expression.c @@ -1,7 +1,7 @@ /** @file Utility functions for expression evaluation. -Copyright (c) 2007 - 2009, Intel Corporation +Copyright (c) 2007 - 2010, Intel Corporation All rights reserved. This program and the accompanying materials are licensed and made available under the terms and conditions of the BSD License which accompanies this distribution. The full text of the license may be found at @@ -1717,7 +1717,7 @@ EvaluateExpression ( // When converting from an unsigned integer, zero will be converted to // FALSE and any other value will be converted to TRUE. // - Value->Value.b = (BOOLEAN) ((Value->Value.u64) ? TRUE : FALSE); + Value->Value.b = (BOOLEAN) (Value->Value.u64 != 0); Value->Type = EFI_IFR_TYPE_BOOLEAN; } else if (Value->Type == EFI_IFR_TYPE_STRING) { -- cgit v1.2.3