From 04d5cc639b207b0d3b9922acc7c669fffe25ef79 Mon Sep 17 00:00:00 2001 From: Star Zeng Date: Thu, 19 Nov 2015 02:32:03 +0000 Subject: MdeModulePkg PeiCore: PeiInstallPeiMemory improper ASSERT test on second call The ASSERT (PrivateData->PeiMemoryInstalled) in if (PrivateData->PeiMemoryInstalled) condition is useless, it should be ASSERT (FALSE) to follow the code's expectation. (Sync patch r18887 from main trunk.) Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Star Zeng Reviewed-by: Liming Gao git-svn-id: https://svn.code.sf.net/p/edk2/code/branches/UDK2015@18901 6f19259b-4bc3-4df7-8a09-765794883524 --- MdeModulePkg/Core/Pei/Memory/MemoryServices.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'MdeModulePkg') diff --git a/MdeModulePkg/Core/Pei/Memory/MemoryServices.c b/MdeModulePkg/Core/Pei/Memory/MemoryServices.c index 36bdc73ebd..2f9b9dea31 100644 --- a/MdeModulePkg/Core/Pei/Memory/MemoryServices.c +++ b/MdeModulePkg/Core/Pei/Memory/MemoryServices.c @@ -96,7 +96,7 @@ PeiInstallPeiMemory ( // if (PrivateData->PeiMemoryInstalled) { DEBUG ((EFI_D_ERROR, "ERROR: PeiInstallPeiMemory is called more than once!\n")); - ASSERT (PrivateData->PeiMemoryInstalled); + ASSERT (FALSE); return EFI_SUCCESS; } -- cgit v1.2.3