From d28c4ed72bb390b1152c114b0b34374428956871 Mon Sep 17 00:00:00 2001 From: Ye Ting Date: Wed, 24 Sep 2014 09:35:32 +0000 Subject: Enhance TargetName check when save iSCSI configuration. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ye Ting Reviewed-by: Wu, Jiaxin Reviewed-by: Fu, Siyuan git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@16167 6f19259b-4bc3-4df7-8a09-765794883524 --- MdeModulePkg/Universal/Network/IScsiDxe/IScsiConfig.c | 17 +++++++++++++++++ 1 file changed, 17 insertions(+) (limited to 'MdeModulePkg') diff --git a/MdeModulePkg/Universal/Network/IScsiDxe/IScsiConfig.c b/MdeModulePkg/Universal/Network/IScsiDxe/IScsiConfig.c index f8ae161b4c..e263f0e306 100644 --- a/MdeModulePkg/Universal/Network/IScsiDxe/IScsiConfig.c +++ b/MdeModulePkg/Universal/Network/IScsiDxe/IScsiConfig.c @@ -872,6 +872,23 @@ IScsiFormCallback ( Status = EFI_INVALID_PARAMETER; break; } + + // + // Validate iSCSI target name configuration again: + // The format of iSCSI target name is already verified when user input the name; + // here we only check the case user does not input the name. + // + if (Private->Current->SessionConfigData.TargetName[0] == '\0') { + CreatePopUp ( + EFI_LIGHTGRAY | EFI_BACKGROUND_BLUE, + &Key, + L"iSCSI target name is NULL!", + NULL + ); + Status = EFI_INVALID_PARAMETER; + break; + } + } if (IfrNvData->CHAPType != ISCSI_CHAP_NONE) { -- cgit v1.2.3