From 8960cdebac8c75f13f1cb6afa932f0ae323a138b Mon Sep 17 00:00:00 2001 From: qhuang8 Date: Tue, 13 Jun 2006 06:31:11 +0000 Subject: =?UTF-8?q?=09BaseMemoryLib=20(BaseMemoryLibRepStr):=20=09Fix=20a?= =?UTF-8?q?=20logic=20error=20in=20SetMem64=20();=20The=20correct=20stride?= =?UTF-8?q?=20should=20be=208=20instead=20of=204.=20=09BasePrintLib:=20=09?= =?UTF-8?q?Fix=20Printf(=E2=80=9C%\n=E2=80=9D)=20passer=20error.=20=09Fix?= =?UTF-8?q?=20BufferSize=20=3D=200,=201=20issue=20=09Fix=20some=20missing?= =?UTF-8?q?=20ASSERT=20()s=20=09Move=20MAXIMUM=5FVALUE=5FCHARACTERS=20from?= =?UTF-8?q?=20PrintLibInternal.h=20to=20PrintLib.h=20=09ReportStatusCodeLi?= =?UTF-8?q?b:=20=09Add=20CONST=20modifier=20to=20some=20interfaces=20=09Mo?= =?UTF-8?q?dify=20=09DebugLib:=20=09Replace=20some=20Unicode=20in=20commen?= =?UTF-8?q?ts.=20=09PeiServicesTablePointerLib=20=09Add=20ASSERT()s=20=09P?= =?UTF-8?q?ciLib:=20=09Remove=20unnecessary=20ASSERT()s=20in=20PciRead/Wri?= =?UTF-8?q?teBuffer()?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@496 6f19259b-4bc3-4df7-8a09-765794883524 --- MdePkg/Include/Library/DebugLib.h | 4 ++-- MdePkg/Include/Library/PrintLib.h | 23 ++++++++++++++++--- MdePkg/Include/Library/ReportStatusCodeLib.h | 34 ++++++++++++++-------------- 3 files changed, 39 insertions(+), 22 deletions(-) (limited to 'MdePkg/Include/Library') diff --git a/MdePkg/Include/Library/DebugLib.h b/MdePkg/Include/Library/DebugLib.h index 5efb304016..b1d320057f 100644 --- a/MdePkg/Include/Library/DebugLib.h +++ b/MdePkg/Include/Library/DebugLib.h @@ -72,7 +72,7 @@ DebugPrint ( Prints an assert message containing a filename, line number, and description. This may be followed by a breakpoint or a dead loop. - Print a message of the form “ASSERT (): \n? + Print a message of the form "ASSERT (): \n" to the debug output device. If DEBUG_PROPERTY_ASSERT_BREAKPOINT_ENABLED bit of PcdDebugProperyMask is set then CpuBreakpoint() is called. Otherwise, if DEBUG_PROPERTY_ASSERT_DEADLOOP_ENABLED bit of PcdDebugProperyMask is set then @@ -411,7 +411,7 @@ DebugClearMemoryEnabled ( by TYPE is compared to TestSignature. If the signatures match, then a pointer to the pointer to a data structure of the type specified by TYPE is returned. If the signatures do not match, then DebugAssert() is called with a description - of “CR has a bad signature?and Record is returned. + of "CR has a bad signature" and Record is returned. If the data type specified by TYPE does not contain the field specified by Field, then the module will not compile. diff --git a/MdePkg/Include/Library/PrintLib.h b/MdePkg/Include/Library/PrintLib.h index 9c65459a59..22df74c65a 100644 --- a/MdePkg/Include/Library/PrintLib.h +++ b/MdePkg/Include/Library/PrintLib.h @@ -17,9 +17,26 @@ #ifndef __PRINT_LIB_H__ #define __PRINT_LIB_H__ -// -// Print primitives -// +/// +/// Define the maximum number of characters that are required to +/// encode a decimal, hexidecimal, GUID, or TIME value with a NULL +/// terminator. +/// +/// Maximum Length Decimal String = 28 +/// "-9,223,372,036,854,775,808" +/// Maximum Length Hexidecimal String = 17 +/// "FFFFFFFFFFFFFFFF" +/// Maximum Length GUID = 37 +/// "00000000-0000-0000-0000-000000000000" +/// Maximum Length TIME = 18 +/// "12/12/2006 12:12" +/// +#define MAXIMUM_VALUE_CHARACTERS 38 + +/// +/// Flags bitmask values use in UnicodeValueToString() and +/// AcsiiValueToString() +/// #define LEFT_JUSTIFY 0x01 #define COMMA_TYPE 0x08 #define PREFIX_ZERO 0x20 diff --git a/MdePkg/Include/Library/ReportStatusCodeLib.h b/MdePkg/Include/Library/ReportStatusCodeLib.h index 9a3d4daabd..6b32ddb137 100644 --- a/MdePkg/Include/Library/ReportStatusCodeLib.h +++ b/MdePkg/Include/Library/ReportStatusCodeLib.h @@ -241,12 +241,12 @@ CodeTypeToPostCode ( BOOLEAN EFIAPI ReportStatusCodeExtractAssertInfo ( - IN EFI_STATUS_CODE_TYPE CodeType, - IN EFI_STATUS_CODE_VALUE Value, - IN EFI_STATUS_CODE_DATA *Data, - OUT CHAR8 **Filename, - OUT CHAR8 **Description, - OUT UINT32 *LineNumber + IN EFI_STATUS_CODE_TYPE CodeType, + IN EFI_STATUS_CODE_VALUE Value, + IN CONST EFI_STATUS_CODE_DATA *Data, + OUT CHAR8 **Filename, + OUT CHAR8 **Description, + OUT UINT32 *LineNumber ); @@ -282,10 +282,10 @@ ReportStatusCodeExtractAssertInfo ( BOOLEAN EFIAPI ReportStatusCodeExtractDebugInfo ( - IN EFI_STATUS_CODE_DATA *Data, - OUT UINT32 *ErrorLevel, - OUT VA_LIST *Marker, - OUT CHAR8 **Format + IN CONST EFI_STATUS_CODE_DATA *Data, + OUT UINT32 *ErrorLevel, + OUT VA_LIST *Marker, + OUT CHAR8 **Format ); @@ -349,9 +349,9 @@ ReportStatusCode ( EFI_STATUS EFIAPI ReportStatusCodeWithDevicePath ( - IN EFI_STATUS_CODE_TYPE Type, - IN EFI_STATUS_CODE_VALUE Value, - IN EFI_DEVICE_PATH_PROTOCOL *DevicePath + IN EFI_STATUS_CODE_TYPE Type, + IN EFI_STATUS_CODE_VALUE Value, + IN CONST EFI_DEVICE_PATH_PROTOCOL *DevicePath ); @@ -393,7 +393,7 @@ EFIAPI ReportStatusCodeWithExtendedData ( IN EFI_STATUS_CODE_TYPE Type, IN EFI_STATUS_CODE_VALUE Value, - IN VOID *ExtendedData, + IN CONST VOID *ExtendedData, IN UINTN ExtendedDataSize ); @@ -445,9 +445,9 @@ ReportStatusCodeEx ( IN EFI_STATUS_CODE_TYPE Type, IN EFI_STATUS_CODE_VALUE Value, IN UINT32 Instance, - IN EFI_GUID *CallerId OPTIONAL, - IN EFI_GUID *ExtendedDataGuid OPTIONAL, - IN VOID *ExtendedData OPTIONAL, + IN CONST EFI_GUID *CallerId OPTIONAL, + IN CONST EFI_GUID *ExtendedDataGuid OPTIONAL, + IN CONST VOID *ExtendedData OPTIONAL, IN UINTN ExtendedDataSize ); -- cgit v1.2.3