From 38bbd3d91c38481d18c1a7e2049473c951ee98ed Mon Sep 17 00:00:00 2001
From: yshang1 <yshang1@6f19259b-4bc3-4df7-8a09-765794883524>
Date: Tue, 8 Jul 2008 09:38:43 +0000
Subject: Code scrub: MdePkg/Library/BaseCacheMaintenanceLib
 MdePkg/Library/BaseDebugLibNull MdePkg/Library/BaseIoLibIntrinsic
 MdePkg/Library/BaseLib MdePkg/Library/BaseMemoryLib
 MdePkg/Library/BaseMemoryLibMmx MdePkg/Library/BaseMemoryLibOptDxe
 MdePkg/Library/BaseMemoryLibOptPei MdePkg/Library/BaseMemoryLibRepStr
 MdePkg/Library/BaseMemoryLibSse2 MdePkg/Library/BasePeCoffGetEntryPointLib

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5426 6f19259b-4bc3-4df7-8a09-765794883524
---
 .../BaseCacheMaintenanceLib/BaseCacheMaintenanceLib.inf       |  4 +---
 MdePkg/Library/BaseCacheMaintenanceLib/EbcCache.c             |  8 ++++----
 MdePkg/Library/BaseCacheMaintenanceLib/IpfCache.c             |  8 ++++----
 MdePkg/Library/BaseCacheMaintenanceLib/x86Cache.c             | 11 +++++++----
 4 files changed, 16 insertions(+), 15 deletions(-)

(limited to 'MdePkg/Library/BaseCacheMaintenanceLib')

diff --git a/MdePkg/Library/BaseCacheMaintenanceLib/BaseCacheMaintenanceLib.inf b/MdePkg/Library/BaseCacheMaintenanceLib/BaseCacheMaintenanceLib.inf
index 50e8990010..19ae8032d3 100644
--- a/MdePkg/Library/BaseCacheMaintenanceLib/BaseCacheMaintenanceLib.inf
+++ b/MdePkg/Library/BaseCacheMaintenanceLib/BaseCacheMaintenanceLib.inf
@@ -45,12 +45,10 @@
 [Packages]
   MdePkg/MdePkg.dec
 
-[LibraryClasses]
-  DebugLib
-
 [LibraryClasses.Ipf]
   PalCallLib
 
 [LibraryClasses.common]
   BaseLib
+  DebugLib
 
diff --git a/MdePkg/Library/BaseCacheMaintenanceLib/EbcCache.c b/MdePkg/Library/BaseCacheMaintenanceLib/EbcCache.c
index ccb5010fd0..d9605566fd 100644
--- a/MdePkg/Library/BaseCacheMaintenanceLib/EbcCache.c
+++ b/MdePkg/Library/BaseCacheMaintenanceLib/EbcCache.c
@@ -56,7 +56,7 @@ InvalidateInstructionCache (
 
   @param  Length  The number of bytes to invalidate from the instruction cache.
 
-  @return Address
+  @return Address of cache invalidation.
 
 **/
 VOID *
@@ -111,7 +111,7 @@ WriteBackInvalidateDataCache (
   @param  Length  The number of bytes to write back and invalidate from the
                   data cache.
 
-  @return Address
+  @return Address of cache invalidation.
 
 **/
 VOID *
@@ -165,7 +165,7 @@ WriteBackDataCache (
                   mode, then Address is a virtual address.
   @param  Length  The number of bytes to write back from the data cache.
 
-  @return Address
+  @return Address of cache wrote in main memory.
 
 **/
 VOID *
@@ -222,7 +222,7 @@ InvalidateDataCache (
                   then Address is a virtual address.
   @param  Length  The number of bytes to invalidate from the data cache.
 
-  @return Address
+  @return Address of cache invalidation.
 
 **/
 VOID *
diff --git a/MdePkg/Library/BaseCacheMaintenanceLib/IpfCache.c b/MdePkg/Library/BaseCacheMaintenanceLib/IpfCache.c
index 17ef43d968..a46df59497 100644
--- a/MdePkg/Library/BaseCacheMaintenanceLib/IpfCache.c
+++ b/MdePkg/Library/BaseCacheMaintenanceLib/IpfCache.c
@@ -61,7 +61,7 @@ InvalidateInstructionCache (
 
   @param  Length  The number of bytes to invalidate from the instruction cache.
 
-  @return Address
+  @return Address of cahce invalidation.
 
 **/
 VOID *
@@ -116,7 +116,7 @@ WriteBackInvalidateDataCache (
   @param  Length  The number of bytes to write back and invalidate from the
                   data cache.
 
-  @return Address
+  @return Address of cache invalidation.
 
 **/
 VOID *
@@ -172,7 +172,7 @@ WriteBackDataCache (
                   mode, then Address is a virtual address.
   @param  Length  The number of bytes to write back from the data cache.
 
-  @return Address
+  @return Address of cache wrote in main memory.
 
 **/
 VOID *
@@ -231,7 +231,7 @@ InvalidateDataCache (
                   then Address is a virtual address.
   @param  Length  The number of bytes to invalidate from the data cache.
 
-  @return Address
+  @return Address of cache invalidation.
 
 **/
 VOID *
diff --git a/MdePkg/Library/BaseCacheMaintenanceLib/x86Cache.c b/MdePkg/Library/BaseCacheMaintenanceLib/x86Cache.c
index 7e744698e3..1fc2b95daa 100644
--- a/MdePkg/Library/BaseCacheMaintenanceLib/x86Cache.c
+++ b/MdePkg/Library/BaseCacheMaintenanceLib/x86Cache.c
@@ -64,7 +64,7 @@ InvalidateInstructionCache (
 
   @param  Length  The number of bytes to invalidate from the instruction cache.
 
-  @return Address
+  @return Address of cache invalidation.
 
 **/
 VOID *
@@ -120,7 +120,7 @@ WriteBackInvalidateDataCache (
   @param  Length  The number of bytes to write back and invalidate from the
                   data cache.
 
-  @return Address
+  @return Address of cache invalidation.
 
 **/
 VOID *
@@ -139,6 +139,9 @@ WriteBackInvalidateDataCacheRange (
   }
 
   Start = (UINTN)Address;
+  //
+  // Calculate the cache line alignment
+  // 
   End = (Start + Length + (CACHE_LINE_SIZE - 1)) & ~(CACHE_LINE_SIZE - 1);
   Start &= ~(CACHE_LINE_SIZE - 1);
 
@@ -189,7 +192,7 @@ WriteBackDataCache (
                   mode, then Address is a virtual address.
   @param  Length  The number of bytes to write back from the data cache.
 
-  @return Address
+  @return Address of cache wrote in main memory.
 
 **/
 VOID *
@@ -246,7 +249,7 @@ InvalidateDataCache (
                   then Address is a virtual address.
   @param  Length  The number of bytes to invalidate from the data cache.
 
-  @return Address
+  @return Address of cache invalidation.
 
 **/
 VOID *
-- 
cgit v1.2.3