From abea19dbe10720a4ef4f9e688996d71a493cebe9 Mon Sep 17 00:00:00 2001 From: qhuang8 Date: Tue, 25 Apr 2006 05:51:23 +0000 Subject: =?UTF-8?q?PeiSmbusLib=20&=20DxeSmbusLib=20=09Remove=20Arp=20Relat?= =?UTF-8?q?ed=20interfaces=20=09Change=20the=20return=20type=20of=20SmbusQ?= =?UTF-8?q?uickWrite=20from=20=E2=80=9CBOOLEAN=E2=80=9D=20to=20=E2=80=9CVO?= =?UTF-8?q?ID=E2=80=9D=20=09Complete=20interface=20SmBusBlockProcessCall()?= =?UTF-8?q?=20=09Make=20the=20PEC=20bit=20=E2=80=9Cbit=2021=E2=80=9D=20of?= =?UTF-8?q?=20SMBUS=20address.=20If=20data=20show=20that=20MSB=20helps=20t?= =?UTF-8?q?o=20save=20code=20size=20in=20BaseSmbusLib,=20we=20may=20simply?= =?UTF-8?q?=20redefine=20it=20to=20be=20MAX=5FBIT.=20UefiLib=20=09Modify?= =?UTF-8?q?=20the=20interfaces=20in=20UefiNotTiano.c=20to=20sync=20with=20?= =?UTF-8?q?spec=20MemoryAllocationLib=20=09Add=20extra=20checking=20in=20?= =?UTF-8?q?=E2=80=9CAligned=E2=80=9D=20Memory=20services=20to=20prevent=20?= =?UTF-8?q?=E2=80=9CAllocationSize=20+=20OverAllocation=E2=80=9D=20overflo?= =?UTF-8?q?w=20in=20DxeMemoryAllocationLib.?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@23 6f19259b-4bc3-4df7-8a09-765794883524 --- MdePkg/Library/DxeSmbusLib/DxeSmbusLib.c | 70 +------------------------------- 1 file changed, 2 insertions(+), 68 deletions(-) (limited to 'MdePkg/Library/DxeSmbusLib/DxeSmbusLib.c') diff --git a/MdePkg/Library/DxeSmbusLib/DxeSmbusLib.c b/MdePkg/Library/DxeSmbusLib/DxeSmbusLib.c index 4c888370eb..2991350e24 100644 --- a/MdePkg/Library/DxeSmbusLib/DxeSmbusLib.c +++ b/MdePkg/Library/DxeSmbusLib/DxeSmbusLib.c @@ -43,11 +43,7 @@ SmbusLibConstructor ( { EFI_STATUS Status; - Status = gBS->LocateProtocol ( - &gEfiCpuIoProtocolGuid, - NULL, - (VOID**) &mSmbus - ); + Status = gBS->LocateProtocol (&gEfiSmbusProtocolGuid, NULL, (VOID**) &mSmbus); ASSERT_EFI_ERROR (Status); ASSERT (mSmbus != NULL); @@ -80,7 +76,7 @@ InternalSmBusExec ( IN EFI_SMBUS_OPERATION SmbusOperation, IN UINTN SmBusAddress, IN UINTN Length, - IN VOID *Buffer, + IN OUT VOID *Buffer, OUT RETURN_STATUS *Status OPTIONAL ) { @@ -104,65 +100,3 @@ InternalSmBusExec ( return Length; } - -/** - Assigns an SMBUS slave addresses. - - Assigns the SMBUS device specified by Uuid the slave address specified by SmBusAddress. - The status of the executed command is returned. - - @param SmBusAddress Address that encodes the SMBUS Slave Address, - SMBUS Command, SMBUS Data Length, and PEC. - @param Uuid Pointer to the UUID of the device to assign a slave address. - It will assign to all SMBUS slave devices if it is NULL. - - @retval RETURN_SUCCESS The SMBUS command was executed. - @retval RETURN_TIMEOUT A timeout occurred while executing the SMBUS command. - @retval RETURN_DEVICE_ERROR The request was not completed because a failure reflected - in the Host Status Register bit. - Device errors are a result of a transaction collision, illegal command field, - unclaimed cycle (host initiated), or bus errors (collisions). - -**/ -RETURN_STATUS -InternalSmBusArpDevice ( - IN UINTN SmBusAddress, - IN CONST GUID *Uuid OPTIONAL - ) -{ - EFI_SMBUS_DEVICE_ADDRESS SmbusDeviceAddress; - - SmbusDeviceAddress.SmbusDeviceAddress = SMBUS_LIB_SLAVE_ADDRESS (SmBusAddress); - return (RETURN_STATUS) mSmbus->ArpDevice ( - mSmbus, - (BOOLEAN) (Uuid == NULL), - (EFI_SMBUS_UDID *) Uuid, - &SmbusDeviceAddress - ); -} - -/** - Retrieves the mapping of all the SMBus devices. - - The GetArpMap() function returns the mapping of all the SMBus devices - that are enumerated by the SMBus host driver. - - @param Length Size of the buffer that contains the SMBus device map. - @param SmbusDeviceMap The pointer to the device map as enumerated by the SMBus controller driver. - - @retval RETURN_SUCCESS The SMBUS command was executed. - @retval RETURN_TIMEOUT A timeout occurred while executing the SMBUS command. - @retval RETURN_DEVICE_ERROR The request was not completed because a failure reflected - in the Host Status Register bit. - Device errors are a result of a transaction collision, illegal command field, - unclaimed cycle (host initiated), or bus errors (collisions). - -**/ -RETURN_STATUS -InternalGetArpMap ( - OUT UINTN *Length, - OUT EFI_SMBUS_DEVICE_MAP **SmbusDeviceMap - ) -{ - return (RETURN_STATUS) mSmbus->GetArpMap (mSmbus, Length, SmbusDeviceMap); -} -- cgit v1.2.3